From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0877B24023B for ; Mon, 13 Jan 2025 15:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736783053; cv=none; b=hnRUDgj/Ed868Ov1F/ahKtJlRqEKITtFbRK66WM6g32n5C2F1boWBsVQFVVXp8Uq4ePBjNJOkcDWSH0cvyVz5bDl4WER/ydYk/0psSIv9i+BbSwGcnBYxufKvPffFonfCs40jjhJmnG8VIHrp7eNhzloJZk7QpBN5T8IpYLYpHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736783053; c=relaxed/simple; bh=v8ufhLgTXFUvLsVDs8S1eQpwTE1x1xLxrZWWYkjtcAQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=rzzBQ0F7CMHe2mgoBUv7TMryTOxCI+Pujl/LCbY7tR+adlY0A9RzExzeAJilEM0teTQmf7an+qTxxCHlrAxv8Pimf9JucLjLzHJMykQEGvgD/2aAXvR6WQGk2jzLeBbzC5Ol/Rwbf1PQ2FdUxlx0VO6OkqYHMYKugkeFjASTvuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Nlz5vOJ8; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Nlz5vOJ8" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736783050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Phc0agFb9IGS06byHBV7HOmGEG8Ax1qwKhDEggT62bI=; b=Nlz5vOJ8zE7NeizUi4cNzdyq3VcgQGaV+RlxIKCMswKwryJcWflchQ0SixW67SVnI71cUP 4M6BQCMtBb7i0lgJFN8wj5QBH+Av4oIHiGFKxzpTz0VWvfFSV8JfkMVp20+BID2Gr0zgHl NXFhziocZ+sb7TSb4GJ+3l/JDi/e6wY= Date: Mon, 13 Jan 2025 21:14:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Aradhya Bhatia Subject: Re: [PATCH v6 10/12] drm/bridge: cdns-dsi: Move DSI mode check to _atomic_check() To: Dmitry Baryshkov Cc: Tomi Valkeinen , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nishanth Menon , Vignesh Raghavendra , Devarsh Thakkar , Praneeth Bajjuri , Udit Kumar , Jayesh Choudhary , DRI Development List , Linux Kernel List References: <20250111192738.308889-1-aradhya.bhatia@linux.dev> <20250111192738.308889-11-aradhya.bhatia@linux.dev> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/13/25 14:43, Dmitry Baryshkov wrote: > On Sun, Jan 12, 2025 at 12:57:36AM +0530, Aradhya Bhatia wrote: >> From: Aradhya Bhatia >> >> At present, the DSI mode configuration check happens during the >> _atomic_enable() phase, which is not really the best place for this. >> Moreover, if the mode is not valid, the driver gives a warning and >> continues the hardware configuration. >> >> Move the DSI mode configuration check to _atomic_check() instead, which >> can properly report back any invalid mode, before the _enable phase even >> begins. >> >> Signed-off-by: Aradhya Bhatia >> Signed-off-by: Aradhya Bhatia >> --- >> .../gpu/drm/bridge/cadence/cdns-dsi-core.c | 87 +++++++++++++++++-- >> .../gpu/drm/bridge/cadence/cdns-dsi-core.h | 1 + >> 2 files changed, 83 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h >> index 5db5dbbbcaad..b785df45bc59 100644 >> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h >> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.h >> @@ -77,6 +77,7 @@ struct cdns_dsi { >> bool link_initialized; >> bool phy_initialized; >> struct phy *dphy; >> + struct cdns_dsi_cfg dsi_cfg; > > Is this still something necessary / useful? I think the point was to > move dsi_cfg to the state, while this is a non-state struct. No, this isn't necessary. This is a stray piece of code. Looks like I missed it. Thank you! I will drop this in the next revision. Regards Aradhya > >> }; >> >> #endif /* !__CDNS_DSI_H__ */ >> -- >> 2.34.1 >> >