From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition
Date: Tue, 28 May 2019 20:29:34 +0200 [thread overview]
Message-ID: <c947d07c-2a8d-b9a8-b2ac-6c249ac54bca@gmail.com> (raw)
In-Reply-To: <e54d9d29-5daa-fd3a-a5a9-ebd2450882ee@ti.com>
On 5/28/19 8:19 PM, Dan Murphy wrote:
> Jacek
>
> On 5/28/19 12:44 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 5/28/19 7:32 PM, Dan Murphy wrote:
>>> Jacek
>>>
>>> On 5/27/19 3:00 PM, Jacek Anaszewski wrote:
>>>> Hi Dan,
>>>>
>>>> Thank you for the update.
>>>>
>>>> One thing is missing here - we need to document how legacy brightness
>>>> levels map to the sub-LED color levels, i.e. what you do in
>>>> multicolor_set_brightness().
>>>
>>>
>>> Ok so i will need to document the algorithm that is used to determine
>>> the color LED brightness.
>>
>> Right, and please send just an update of that single patch.
>>
>
> So you are asking for v4 with only this patch updated.
Not exactly - I am asking for v4 of this patch. We don't need
to spam the lists with the rest of unaltered patches from the series.
The interface seems to be the most vital part of this patch set,
and it is possible that it will undergo at least slight modifications.
We will move to discussing the code once we achieve a total consensus.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-05-28 18:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 19:08 [PATCH v3 0/9] Multicolor Framework update Dan Murphy
2019-05-23 19:08 ` [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-05-27 10:33 ` Pavel Machek
2019-05-28 0:45 ` Dan Murphy
2019-05-28 11:34 ` Dan Murphy
2019-05-30 19:40 ` Pavel Machek
2019-05-30 20:43 ` Dan Murphy
2019-05-27 20:00 ` Jacek Anaszewski
2019-05-28 17:32 ` Dan Murphy
2019-05-28 17:44 ` Jacek Anaszewski
2019-05-28 18:19 ` Dan Murphy
2019-05-28 18:29 ` Jacek Anaszewski [this message]
2019-05-30 14:30 ` Dan Murphy
2019-05-23 19:08 ` [PATCH v3 2/9] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-06-14 17:00 ` Rob Herring
2019-06-14 17:18 ` Dan Murphy
2019-06-18 15:36 ` Rob Herring
2019-06-18 18:19 ` Jacek Anaszewski
2019-06-18 18:57 ` Rob Herring
2019-05-23 19:08 ` [PATCH v3 3/9] documention: leds: Add multicolor class documentation Dan Murphy
2019-05-23 19:08 ` [PATCH v3 4/9] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-06-14 17:00 ` Rob Herring
2019-05-23 19:08 ` [PATCH v3 5/9] " Dan Murphy
2019-05-23 19:08 ` [PATCH v3 6/9] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-06-20 16:10 ` Jacek Anaszewski
2019-06-20 20:06 ` Dan Murphy
2019-06-20 21:42 ` Jacek Anaszewski
2019-05-23 19:08 ` [PATCH v3 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-05-24 20:50 ` Rob Herring
2019-05-28 0:47 ` Dan Murphy
2019-06-11 21:51 ` Rob Herring
2019-05-23 19:08 ` [PATCH v3 8/9] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-05-23 19:08 ` [PATCH v3 9/9] leds: Update the lp55xx to use the multi color framework Dan Murphy
2019-06-14 7:02 ` [PATCH v3 0/9] Multicolor Framework update Alexander Dahl
2019-06-14 14:23 ` Dan Murphy
2019-06-16 15:49 ` Pavel Machek
2019-06-17 13:47 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c947d07c-2a8d-b9a8-b2ac-6c249ac54bca@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).