From: "luobin (L)" <luobin9@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <luoxianjun@huawei.com>,
<yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>
Subject: Re: [PATCH net v2] hinic: fix a bug of ndo_stop
Date: Mon, 11 May 2020 10:09:14 +0800 [thread overview]
Message-ID: <c94de313-5b54-8f39-b036-22e7aa026c23@huawei.com> (raw)
In-Reply-To: <20200509153758.06f6947f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Will fix. Thanks.
On 2020/5/10 6:37, Jakub Kicinski wrote:
> On Fri, 8 May 2020 20:19:33 +0000 Luo bin wrote:
>> if some function in ndo_stop interface returns failure because of
>> hardware fault, must go on excuting rest steps rather than return
>> failure directly, otherwise will cause memory leak.And bump the
>> timeout for SET_FUNC_STATE to ensure that cmd won't return failure
>> when hw is busy. Otherwise hw may stomp host memory if we free
>> memory regardless of the return value of SET_FUNC_STATE.
>>
>> Signed-off-by: Luo bin <luobin9@huawei.com>
> Doesn't apply to the net tree:
>
> error: patch failed: drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c:353
> error: drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c: patch does not apply
> error: patch failed: drivers/net/ethernet/huawei/hinic/hinic_main.c:504
> error: drivers/net/ethernet/huawei/hinic/hinic_main.c: patch does not apply
> hint: Use 'git am --show-current-patch' to see the failed patch
> Applying: hinic: fix a bug of ndo_stop
>
> Please also include a Fixes tag when you repost.
> .
prev parent reply other threads:[~2020-05-11 2:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 20:19 [PATCH net v2] hinic: fix a bug of ndo_stop Luo bin
2020-05-09 22:37 ` Jakub Kicinski
2020-05-11 2:09 ` luobin (L) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c94de313-5b54-8f39-b036-22e7aa026c23@huawei.com \
--to=luobin9@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox