From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965557AbdKPRON (ORCPT ); Thu, 16 Nov 2017 12:14:13 -0500 Received: from mail-co1nam03on0081.outbound.protection.outlook.com ([104.47.40.81]:4003 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935749AbdKPROD (ORCPT ); Thu, 16 Nov 2017 12:14:03 -0500 Subject: Re: [PATCH v2 3/4] Add support for AMD Core Perf Extension in guest To: Borislav Petkov Cc: kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Paolo Bonzini , Radim Krcmar , Len Brown , Kyle Huey , Kan Liang , Grzegorz Andrejczuk , Tom Lendacky , Tony Luck References: <5113a9d6e76d2c6050c1fba4007068340321521c.1509985085.git.Janakarajan.Natarajan@amd.com> <20171109183425.rhqc5wrltznt5tcf@pd.tnic> <07f23e5e-2747-b0bc-1b93-f83f3982649a@amd.com> <20171115190755.5n2zskcr2d4bmewp@pd.tnic> From: "Natarajan, Janakarajan" Message-ID: Date: Thu, 16 Nov 2017 11:13:47 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171115190755.5n2zskcr2d4bmewp@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: CY4PR13CA0078.namprd13.prod.outlook.com (10.171.162.16) To BN6PR12MB1667.namprd12.prod.outlook.com (10.172.19.18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 730fbdbc-69e5-43ec-5cdb-08d52d156cf4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603258);SRVR:BN6PR12MB1667; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;3:V4BivvVkbGqr/ZGXvCjHk/E7M9l/WEgVqzgZJ0f4BaE77g3YGvRA+a9kNosG/TRJ2A76B37+mdfSHxitWa/ogjz2GGnIr7IgIia/tvwbO9WXv0sxi+6Xx3WokfW91WPUfWv3MsV0wh61HaeCChNKr0NgIp+XUXNsyr2FTCllzWuKF6Wkyoro9Nutg9Y1m72pExOT52RB7zCHiznrmqKUg12+Ip7EPst4IAOYjh+U1sxK8F5OvAiE/WpVQxp34mwF;25:Sc0vk5ZrnQ/fFcJZfacn46golebeLHBPOa9Yozm2umztfiJdtDgVUVivjdsibbT/42o6WqVJb/+LyqBKaCiT8Ii1GJFj102Jf6/e30J7zD7iiZlpDeCdsqn+E2TNPWEF07NbkpE5NuyZJkGP/ZaA2cL6iBThqPKIv3HU/XR4GsnGkf56CCFH7CsA3dzjr9dqHNX7M6/gdcfO5CIN9PFoyTGWhnr2rtzGWLAa7loJ7ZsnxgFiyK/WcvuE1BmU1LaYoMfV3uQsF2CUtoxHla5afO3w0LXKNl/w5TIYqtX82T0fMwHyNJOuC2u2Iz0UcFugH9xKH9YbZESxVvMH+lkq5A==;31:1OGNu1vYG8GrrHyUdiDwMGtRa8CwaYqTnyqzUs+rKYA9JgnpF9DzBEcpo7ERCYATodwsVu6MDtnXq60rlpjIqfk+q2K0tO4PNaFF5fxWNUIfUkQAgAV0qMkdKY92htA45UOxfUbFM27bB+ErJjluGmf/wsLa7MWVS1NXNht78xSxSpf/GqADyvpQjxVy8b6kvOaMJXX1JRxnizTd2SoTcnUc8vAAjeskhOfbsZf5e6s= X-MS-TrafficTypeDiagnostic: BN6PR12MB1667: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;20:NmMUTd51Axyy56TPgRfSh/KsmkkFmaOBHHpx4kH9HCx14zAJNsv9WNxO3lb0LfdQHhXJLdC49wsxlBF4soGw6wv2G5DfHxg3GlDiPzrUk+d427xVIul0JqDCiIFnmuzjAqyCThjuGcguYWiW1+QlYIdSACDuu3tCyfeI+61S9428/HQUGCJZmPYbsI6Vz5uWOUyYczc9NeGszW01RO7zN6BKNGGRCHh+LsJNFiRD9vRJafc+D6PaI2veZ7nWQbD6bCDZToRHD5UVQmDhyPDj59kvHIRLo6LqUdxSS9MbhfuV8OtI6w6jYaI+ftyh9LbZRKDf8T5heSH0rtUyYpVLnhqzP5HPH0lMqrpWTXbNzhfaL+TP0yXDF4FM9m5BlEC/gBV3dc8WXmgljt859Kg69cIP32WhYbWHqxITh5ngzafq7ZVqI5uvI67t8J0MY8z4Z+BAAxU4BFOnTyRYmecaUS2/ZUNSBlhXM3Oycx7mmCT5xs3/DAx0llOVvTJyGaxA;4:8H4yvQCDlSSLaxwxrynOa9O0jI/4SEhP+yn9LxZNsPerNW/e8oTn17ur/z7T3vUs4elHTxAOWnsKSp3aqyvdod0tGotZHYcXZO4J3ToT9PD0EoWelXE0JA1EOTGPJnG2D0hEugP3MTfMtPboqAGeHyjgdQVKH9krWf+la7fMeg91ZdAz8tMlG2BHqo4x+FnVt+klEyGyogRH1SG7vZG+5ZZ3PBCGhW5GZ/HuwUJB76Xgp4mDl4LdvVmLA3DUABwBFUFnpIFRoeoon1YgXKGp1g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(3231022)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR12MB1667;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR12MB1667; X-Forefront-PRVS: 0493852DA9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(39860400002)(346002)(199003)(189002)(24454002)(47776003)(23676003)(229853002)(6486002)(478600001)(72206003)(25786009)(53546010)(5660300001)(31696002)(77096006)(2950100002)(6666003)(90366009)(4326008)(2906002)(7416002)(36756003)(86362001)(53936002)(50466002)(8936002)(65826007)(230700001)(6246003)(6116002)(6916009)(83506002)(64126003)(305945005)(81156014)(7736002)(33646002)(189998001)(8676002)(68736007)(54356999)(58126008)(101416001)(76176999)(50986999)(31686004)(67846002)(16576012)(66066001)(106356001)(65956001)(65806001)(93886005)(316002)(54906003)(81166006)(97736004)(105586002)(16526018)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1667;H:[10.236.68.193];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Janakarajan.Natarajan@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxNjY3OzIzOmVNOFZKQ2d0WVFzMzJkSzlyMGIrVXJsUDE1?= =?utf-8?B?WC9HNUJVa3MzanF2cHlOYXoxSlMxY2lxM2lKZWdZMFIrMGZjRzIzeFBqaEN6?= =?utf-8?B?dkhndTE4d3dDVGlJR0lCQ3BnUVh5T0x2SW5mU0w3QjI2M2pHNHpPS1ZYakhN?= =?utf-8?B?cFFxWXZUK1pSZXM4bHdlV3RIZkc4QkphTng0eFFsbVQyeTMxV2p0TXRlYS9v?= =?utf-8?B?WUVBcEhvalhYWVNtdnFnSDNMMStUNnlCSGNpQ3BGdUZCNjc3SHhsdWJtK0g2?= =?utf-8?B?SXkzT0ZWQjJBT25sL0JQWEJheXF4VTMvMW9SdW5qNHl5Nm55c1h0V2duOWdF?= =?utf-8?B?dk52eTFLYUk2UFFMdWt4ZUEwUDI2eTg0YkVqS3J6NkY3cnJMbkFuMFhGK2g3?= =?utf-8?B?N2N3K2diRmVnVE5ySHhHQTl2T3pDVStTQzkrYnNmekp2ZzZGdGcycTlQQ05U?= =?utf-8?B?WEN3bFh3REdrTklob1J1bXkvUEV2eG9GWHdoYkxRZnZxd2pnY2pLWU9wMmRl?= =?utf-8?B?WnFIdkVPTkNxcVpZb1h3aU9nRGJYdzlPL1pjeHc3TWRGRjgzcnc5TmpoWVlm?= =?utf-8?B?dVdTUmRoSzkrYW56Mzd0bUx3Ky9PRCtJVlc2cGliTEVQQ0lmbUJ0eXNUWVQr?= =?utf-8?B?dnJEakdaem5zUi9RSkhkWThwWG1sWjBCTlV3VVpPT0NVRWNzTVhUYXE0OXV6?= =?utf-8?B?Qmp0UjZ0WGt6K1prcFB6Wm9WdTRnVjZ4dmhzMHB6TUxValJvcklqdm1ReS85?= =?utf-8?B?L2JTV2ZXVTZyMEZ5S29xL2ZPVWl5Tnhxc0F3WHBsZ1oyUTg4OTFZQzJ3ZUpy?= =?utf-8?B?SGRLOXJ4dEdlWjJsdWZITkZCdkdURzJibE5EODNaS3dpa0hPMjRsQXFYYzM2?= =?utf-8?B?Y29VSWVqNnREVFFxZ3dNNDVFZ1F1ekZEby9qRFpRUHpkZnFMaUYycUZOanZU?= =?utf-8?B?NVNQczBpbFVuWGN5WFplbnRXTGhkYjI2VU95T3k0RTRmL05Dd0ZsL3owQjdh?= =?utf-8?B?OUJwUlJEUHVuK1JJVUsvUm9yT1gwOUlXUTJQVUNOd0U2dFc1WFVuSE9oM3o4?= =?utf-8?B?QzQySUllOGhJM0x0T1dGdUg2dytxMmhSWWg2ZCtvZkQzNVhlM3RqdHl1T3BC?= =?utf-8?B?cENicFVsN2ZFNFdNTzVtN2plUnl4Zm1TcFlIQmJ0WWdha2ZSRzBPakMyalNX?= =?utf-8?B?STZGbzUyTFVXcW5RbUFJL2ZpWGhRbHh1TjlSKyt1WW9FTG5GendZd3IxcVJQ?= =?utf-8?B?eHFrZE16dHg1dEdXUnBIcGlMSC9ESEdUU0dPaXBUTkFXOFMxY1FBOWxlSDhx?= =?utf-8?B?d1Q3N3VqQW5CWkpzQUpZam1rOWVURU91QjZwNW9yYmNVNTZuRXNuMHVuVklj?= =?utf-8?B?THYzdHJ1VUJHMFRPakM4TlhkdFVxN0R0NWRVUlNFTWthRjExcmlNTmQ2bEhN?= =?utf-8?B?amZEWlRmUGhIMy9ycEFFb1Y4dk9wWmhoQ2c2WDJWMS9RZ2lZcEx0ZjA2Z3Zv?= =?utf-8?B?ekcrV2lXL21qeDBVM2p6ZkpkME1wc2NBcWtkRWVyYzNuamQ5cksyMG4zb1lW?= =?utf-8?B?aDlpK1BQZXQycCtKUjlpcEtYOFpDMzc2R3RVRE5MdkpqZ2piL2VjZ2JMYjZ6?= =?utf-8?B?cS9CeHlYOXBIcXc2TnhoVUNJT3Bkd21xbFR6WlJVS3Q3NFg3dWJqNUs2M2dn?= =?utf-8?B?NEdCc08xYUlUeXowT3JhSzkxRDBKMGN4UU9oUU1ySGFyYWFvRWJnd3ByWW5P?= =?utf-8?B?L1E1NmZPWTQwb3p3dDM0VWtKeE1RcnZ6WkJ4Yk9za1pwdlU5eGh5OUJ4cmJK?= =?utf-8?B?ekg4cE1Qc2s4MDY3UktuaFJqY1hkMDdJalJzL0Y1K2ZkZWxnSjcwSHhZaXBt?= =?utf-8?B?dVJuNzJ5NHJBYVhMRFk2TmNCcWpxbFllRHJGaTRnUkp1OTliaStXdlQ1UHk1?= =?utf-8?B?Y0VUR1Z4Q0VZWSsyeTRyRU5BWGluWlBab1lHYzZzbDA4SnJVcG1LVkdQOXhh?= =?utf-8?Q?LsL0xF?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;6:gfAc0BQRUme7QhSnKrdoA4zAiS2zJaDdLlXI9097NKiOaa2ADcRR4LOYz/YotXUZ8nvw0T8DYDwcDBWvWwhYaeFDyqXNr3wjUjeH+T2WQSMk0giDYdOXQ6uNv2S898CMrHTX/f2Hc1qSaZey0LpI1ys8VDpqrgubvOCn9MRVVliXUKUhNYSKwjF5TpC9Y0ePpIvbSGZT1EgV/+hsgwSiKJih87wEE2q2A3/ev/Jwu21tkFr8v3oLxE7BzXc8o5qtFM0fBJzH41Pi1Zs8jt0T+op9bV1BmB89aqYG690A+DgGP8zszx2Skc+tCBT4fr9qnf8sMGmDJkwS/bKiOCVesnCOd8cpEXb4Y2b3SvWeu4A=;5:vg1TC5zEHzXFm2WFA9kL7lYzAlv24IFl18q0x8VRvQiXgNWnoaSzl8tuKKTP4ZwoNCUoSmPTH6NQdFHNVxlpCnc5Hj6roYmP1RzIWQy8HTMLKNOt3BxJIktJ9edpBw6UExc1p2S1HBxX3C5MR/91haRrun8D133cvPuR51M3mAY=;24:Xo9Si+9vs+c2IrW7eu3Xc8laioF1Aiqb1/WMYZuoex3iu7LdfltclwsijdrJxCVh6SW1HagM8sFj8qZvsqMCmwsmeKqKzKEWx/U9arSLDYA=;7:OSZUhkm7ikmBe+5eqCe/NvmuW8oDfa7ZQd5kjfyQnwwL1Ejy4WxwwtnyVxdVWs0q5u3H2rBJ5OrJGryormqRE+6EmTckNPzxUA9i37SmZt1NARKy2M/ubfsT2pIRCnZJBtDL18xhk23sBbGgRu1ln5c7CC24qYGoNr7Trc0FavrsMWP4oHlRIqXrmIhYjI9ECvswKglBaYg3e3lTqc70tB4HUZqalheZiFKqgA37Vc/1WgPH3ws3I6O6DWUb5Hgb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1667;20:M1ynpssbqgDUytBu3aNBln0pGZBi8yzxTzbdQRf7hVpIYJnZQx4hSA5vTk1Ht9kQVz+KROuW4Kvse21Bb43t7aMKhYZf3V90I+cpBYw5W7Kj/QXWCj+M0t+RtuxZgSPTh3rQ/TkujlFu8ZzZNMtO5nW41HE6UIM+EeyHXEQeUdb4qSn9jHNdzKVwgACTadfKJoBFk3iivCN09fZQVQ9B9U/hhGIRCEUB+6XkpHWGnfOsRHJu7CR5jZr7sC9Ro3ya X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2017 17:13:52.5028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 730fbdbc-69e5-43ec-5cdb-08d52d156cf4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1667 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/2017 1:07 PM, Borislav Petkov wrote: > On Wed, Nov 15, 2017 at 01:04:03PM -0600, Natarajan, Janakarajan wrote: >> So, when the amd_pmu_init is called, a query to guest_cpuid_family() gives a >> value of -1. > And that is because...? And it can be fixed to give the proper guest family I > presume ...? Qemu initially creates a vcpu with KVM_CREATE_VCPU which in kvm initializes the pmu. Later on the cpuid is set using KVM_SET_CPUID2 which sets all the cpuid entries in kvm and the pmu refresh is called. >