Re: [PATCH v2 1/6] dt-bindings: timers: sp-804: Convert to json-schema

André Przywara
2020-09-09T10:08:14Z

On 08/09/2020 18:28, Rob Herring wrote:
> On Fri, 28 Aug 2020 15:20:13 +0100, Andre Przywara wrote:
>> This converts the DT binding documentation for the ARM SP-804 timer IP
>> over to json-schema.
>> Most properties are just carried over, the clocks property requirement
>> (either one or three clocks) is now formalised and enforced.
>> As the former binding didn't specify clock-names, and there is no
>> common name used by the existing DTs, I refrained from adding them in
>> detail (just allowing the property).
>> The requirement for the APB clock is enforced by the primecell binding
>> already.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>> .../devicetree/bindings/timer/arm,sp804.txt | 29 ------
>> .../devicetree/bindings/timer/arm,sp804.yaml | 93 +++++++++++++++++++
>> 2 files changed, 93 insertions(+), 29 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/timer/arm,sp804.txt
>> create mode 100644 Documentation/devicetree/bindings/timer/arm,sp804.yaml
>>
>
> Applied, thanks!
>
> I dropped the primecell.yaml ref as it is redundant.

Interesting, because I explicitly added it to cover one property that
was only described in primecell.yaml. But I think this one node was
originally missing the actual primecell compatible string.

So I tested it now again and don't see any issues without the explicit
primecell.yaml reference anymore.

Thanks for taking it!

Cheers,
Andre.