From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4306410D0F for ; Wed, 12 Aug 2026 09:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786527029; cv=none; b=amoaUYoZzvb9fBizh5Ir1QSR7WEeTS+MdmQ9JnCxXY5ZAX35mNXEYy+rXCvlUgddS43a0hhJO6f/umafQZe4Ft0qi8mnIRrGd4KVSc3Wb6XxyApYPmwQk4kLybXN00wvnu3tydWluXbjvMeTPjUdm5eBworR6joa8/1h4/sgxS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786527029; c=relaxed/simple; bh=y4qTtJE2/NaMjrWqAw/WcYJ5sFhqOnuEQDddDAWjPNs=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=hBY0Mn2W3hSaHzUMXS3/z8KoEGmTgZb60NcCxHuJw9WH8fIAaEKjotqOKsyZeL+JU6JgV2980Mu549gOQFJE666+WLCx1M5fsJKY1BuZP+Q75p9vee7sS9MniBaO+/+uGBJcr104ghyXGa2XtjvSEsQBp957eLpATdyX6IRAYOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Lo5R6Oaa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lo5R6Oaa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2200F1F00A3A; Wed, 12 Aug 2026 09:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786527028; bh=sCNy7bwSl7GQs5/Abl5un/U19S8NKl7KYsInH1bT2Cw=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=Lo5R6OaamcQYN8WgvHhxuzmC4u4UKBsCcC4IF6ADiGzMveMSAfwYElX8lgwVsz0kf B4f2W7PjM4KETJ7KnQnwvrqR5W4mBbyafq8vFbFzzCM19QnLn+NsAiIj1gld9AjG0r RvK3QX0yb0H3zEm5v5xNCBZ+3C+JohoVBjbtFDN3rLF+3W+Rltb2n7xZ1jou4PQIWP 9TbozClEMsOtCRd2THqjOXl1kpYiGPgUnOEmGfJY2jJWvgqgBNNt62Sfk5G84B74yP M+BoVPaDWbqlRuX1uViNzCZPx8Zljg5jDk+TaQLy6fa9LQAmn0nGd9mgm3PS4CJKxS rQsmy/Lx1/RmQ== Message-ID: Date: Wed, 12 Aug 2026 17:30:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH v2] f2fs: return symlink writeback errors To: Wenjie Qi , jaegeuk@kernel.org References: <20260810133832.3530016-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260810133832.3530016-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/10/26 21:38, Wenjie Qi wrote: > F2FS writes long symlink data with page_symlink() and then flushes the > symlink mapping to reduce the chance of exposing a broken symlink. > > That flush result is currently ignored. If the writeback fails, symlink() > still returns success even though the symlink is not durable and the same > operation can already surface -EIO through syncfs(). > > Return the writeback error to userspace and skip the dirsync flush once the > symlink data flush has failed. > > Fixes: d0cae97cb600 ("f2fs: flush symlink path to avoid broken symlink after POR") > Cc: stable@kernel.org > Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu Thanks,