From: Stephen Boyd <sboyd@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Miaoqian Lin" <linmq006@gmail.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: tegra20: fix gcc-7 constant overflow warning
Date: Wed, 29 Mar 2023 15:32:29 -0700 [thread overview]
Message-ID: <c9bfdce3487b195acc752fb9625c4dd3.sboyd@kernel.org> (raw)
In-Reply-To: <20230227085914.2560984-1-arnd@kernel.org>
Quoting Arnd Bergmann (2023-02-27 00:59:10)
> From: Arnd Bergmann <arnd@arndb.de>
>
> Older gcc versions get confused by comparing a u32 value to a negative
> constant in a switch()/case block:
>
> drivers/clk/tegra/clk-tegra20.c: In function 'tegra20_clk_measure_input_freq':
> drivers/clk/tegra/clk-tegra20.c:581:2: error: case label does not reduce to an integer constant
> case OSC_CTRL_OSC_FREQ_12MHZ:
> ^~~~
> drivers/clk/tegra/clk-tegra20.c:593:2: error: case label does not reduce to an integer constant
> case OSC_CTRL_OSC_FREQ_26MHZ:
>
> Make the constants unsigned instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
prev parent reply other threads:[~2023-03-29 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 8:59 [PATCH] clk: tegra20: fix gcc-7 constant overflow warning Arnd Bergmann
2023-03-29 22:32 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9bfdce3487b195acc752fb9625c4dd3.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linmq006@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox