From: <Tharunkumar.Pasumarthi@microchip.com>
To: <jk@ozlabs.org>, <christophe.jaillet@wanadoo.fr>,
<Kumaravel.Thiagarajan@microchip.com>,
<gregkh@linuxfoundation.org>, <ilpo.jarvinen@linux.intel.com>,
<wander@redhat.com>, <u.kleine-koenig@pengutronix.de>,
<etremblay@distech-controls.com>, <macro@orcam.me.uk>,
<jirislaby@kernel.org>, <johan@kernel.org>,
<andy.shevchenko@gmail.com>, <geert+renesas@glider.be>,
<phil.edworthy@renesas.com>, <lukas@wunner.de>
Cc: <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v2 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for quad-uart support.
Date: Wed, 26 Oct 2022 11:12:27 +0000 [thread overview]
Message-ID: <c9c19aebb2bf28bad7e98c4d8365ea81ec58bc08.camel@microchip.com> (raw)
In-Reply-To: <676c5723-a9b7-9f28-fbb4-27a5c6f6145b@wanadoo.fr>
On Mon, 2022-10-03 at 21:36 +0200, Christophe JAILLET wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> > + }
> > + priv->line[i] = serial8250_register_8250_port(&uart);
>
> In case of error, this should be undone in an error handling path in the
> probe, as done in the remove() function below.
>
> If we break, we still continue and return success. But the last
> priv->line[i] are still 0. Is it an issue when pci1xxxx_serial_remove()
> is called?
This will not cause a problem in pci1xxxx_serial_remove as this condition 'priv-
>line[i] >= 0' will be checked for each of the ports before calling
serial8250_unregister_port API.
Thanks,
Tharun Kumar P
next prev parent reply other threads:[~2022-10-26 11:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 6:15 [PATCH v2 tty-next 0/3] 8250: microchip: pci1xxxx: Add driver for the pci1xxxx's quad-uart function Kumaravel Thiagarajan
2022-10-01 6:15 ` [PATCH v2 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for quad-uart support Kumaravel Thiagarajan
2022-10-03 9:18 ` Ilpo Järvinen
2022-10-03 9:22 ` Andy Shevchenko
2022-10-05 9:51 ` Kumaravel.Thiagarajan
2022-10-26 10:54 ` Tharunkumar.Pasumarthi
2022-10-31 9:24 ` Tharunkumar.Pasumarthi
2022-10-31 14:37 ` Andy Shevchenko
2022-11-01 15:04 ` Tharunkumar.Pasumarthi
2022-11-01 15:17 ` Andy Shevchenko
2022-11-01 17:54 ` Kumaravel.Thiagarajan
2022-10-03 19:36 ` Christophe JAILLET
2022-10-04 9:46 ` Andy Shevchenko
2022-10-26 11:12 ` Tharunkumar.Pasumarthi [this message]
2022-10-26 20:10 ` Christophe JAILLET
2022-10-01 6:15 ` [PATCH v2 tty-next 2/3] 8250: microchip: pci1xxxx: Add rs485 support to quad-uart driver Kumaravel Thiagarajan
2022-10-03 9:04 ` Ilpo Järvinen
2022-11-01 14:53 ` Tharunkumar.Pasumarthi
2022-11-01 15:25 ` Ilpo Järvinen
2022-11-01 15:35 ` Andy Shevchenko
2022-11-01 15:49 ` Ilpo Järvinen
2022-11-01 18:10 ` Tharunkumar.Pasumarthi
2022-10-03 9:20 ` Ilpo Järvinen
2022-10-04 17:51 ` Kumaravel.Thiagarajan
2022-10-05 9:43 ` Ilpo Järvinen
2022-10-01 6:15 ` [PATCH v2 tty-next 3/3] 8250: microchip: pci1xxxx: Add power management functions " Kumaravel Thiagarajan
2022-10-03 9:26 ` Andy Shevchenko
2022-10-04 17:20 ` Kumaravel.Thiagarajan
2022-10-26 11:03 ` Tharunkumar.Pasumarthi
2022-10-31 9:41 ` Tharunkumar.Pasumarthi
2022-11-04 10:23 ` Tharunkumar.Pasumarthi
2022-11-04 12:50 ` Andy Shevchenko
2022-10-03 9:51 ` Ilpo Järvinen
2022-10-04 19:01 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c19aebb2bf28bad7e98c4d8365ea81ec58bc08.camel@microchip.com \
--to=tharunkumar.pasumarthi@microchip.com \
--cc=Kumaravel.Thiagarajan@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=etremblay@distech-controls.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=jk@ozlabs.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=phil.edworthy@renesas.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox