From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54589C2EF; Thu, 22 May 2025 10:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747910155; cv=none; b=hN5oNR0/aHbscqPHz4Pn8oz33gx9Cfh6a1CAvIKxTkPKUrnafyJQC3BJ1l7Ayry1UHkbiOSG7poIa1GvNXY2AIHSmLeHJBYbOt86hARpLNp08bx70b5p8nwrW0Hn9wMLGSfDf+Z71zbgoIHfWp2uAX0I0UbGVVZ6SrIOV1ev3lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747910155; c=relaxed/simple; bh=HfSoJkOb2VFyqKcxw7pJZAp9sgXXlthrjBP9L0gsEQg=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=RKiKd/cGXfmhHllxOmWGAJafXwYT9GHfa3SXHkvBDGQI17dx5m90BxSnLOysHmZgf5oBAiH2m3oMsRZ8t3fefQUtM031V+cyliLGyu8MQojTL6Z0I2AJnVwhK/j9Bb7v2wi+hK/JbdNqVDoje2v4RTbHLMrR7uUT0maK4Qhm1SE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svenpeter.dev; spf=pass smtp.mailfrom=svenpeter.dev; dkim=pass (2048-bit key) header.d=svenpeter.dev header.i=@svenpeter.dev header.b=d14xGV3S; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=A+NNQzCX; arc=none smtp.client-ip=202.12.124.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svenpeter.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=svenpeter.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=svenpeter.dev header.i=@svenpeter.dev header.b="d14xGV3S"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="A+NNQzCX" Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id EF3EF114027B; Thu, 22 May 2025 06:35:50 -0400 (EDT) Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-04.internal (MEProxy); Thu, 22 May 2025 06:35:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1747910150; x=1747996550; bh=xVWtyDUgJnh0geO6pSrHxWvzURu7bA5K 2oBZ3UTDjCI=; b=d14xGV3SXRmTMfztLAPZ6NvlVMWpTzQg84FTQQkGXBsqstyA mzo7DDnNErbeE0VRKhPZzRjBObcAqqJQHCcwGqCPATVeV0WAjIAeQeu5uxnm063Q FBGio/gg4hKcf3TFVBsEu9UXXG3Lg+3aAkQxmx6DfAVs0d+aXkQ/HCOlB8LLkWb3 hVoyj6hFs5sc+4yEr/v/sQjmqxAZPUg3O1hhkDG06LDzKt1JX8e7/WzFsYyeZzkS 4xen2/CkWfc5YZW2/yLmHYxIpyFudWEoA7+sg3+C+MmDEqk9OZWKPuuBr0OXS6zP I/tdK5Iw6ZYshdlnMqNoWESXSgyYWtovJBFFfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1747910150; x= 1747996550; bh=xVWtyDUgJnh0geO6pSrHxWvzURu7bA5K2oBZ3UTDjCI=; b=A +NNQzCXr/vB9MXDJ4H/QCT+zaG8lFXTw7UrGv0BBjXzmg7tSMxqdgawo9CfOUot8 hPZgoKyYbQQ4ZI6zlVcdZ0Bs4Hw21CsTShvA7PjBdS6LhODzPLdsMPfssE0NLB1d EIY4GnLwb1DRuioNF8ci7+OFj0ANHi4wngIkIkbTvOu1O521fSNVG7cUpCWHPtJd rwMDhAO6qfqzefEDsDOJsaiI8aqTWozVtf6IuLnf946n9hSzyq9cCA5mY9o28zEL a0Lo36PKKdJJR3rezt4NLcNds+SQbBpcqZVWKaU1RU8/3hd9Rc4UMQfPu6ldaRtN 7v8KqiuE1oiSdhpNNlAuw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdehjeegucdltddurdegfedvrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgf nhhsuhgsshgtrhhisggvpdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttd enucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgj fhfutgfgsehtjeertdertddtnecuhfhrohhmpedfufhvvghnucfrvghtvghrfdcuoehsvh gvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrfgrthhtvghrnhepleefteeugedu udeuudeuhfefheegveekueefffdvffektdffffelveffvddvueffnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhvvghnsehsvhgvnhhpvght vghrrdguvghvpdhnsggprhgtphhtthhopeduledpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtoheprhhmkhdokhgvrhhnvghlsegrrhhmlhhinhhugidrohhrghdruhhkpdhrtghp thhtohepsghrghhlsegsghguvghvrdhplhdprhgtphhtthhopehnvggrlhesghhomhhprg druggvvhdprhgtphhtthhopehjsehjrghnnhgruhdrnhgvthdprhgtphhtthhopegtohhn ohhrodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrh hnvghlrdhorhhgpdhrtghpthhtoheplhgvvgeskhgvrhhnvghlrdhorhhgpdhrtghpthht ohepmhgriieskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprhhosghhsehkvghrnhgvlh drohhrgh X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 961FF1060060; Thu, 22 May 2025 06:35:49 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: T3582cb9b01beb853 Date: Thu, 22 May 2025 12:35:29 +0200 From: "Sven Peter" To: "Lee Jones" Cc: "Janne Grunau" , "Alyssa Rosenzweig" , "Neal Gompa" , "Hector Martin" , "Linus Walleij" , "Bartosz Golaszewski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Sebastian Reichel" , "Marc Zyngier" , "Russell King" , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, "open list:GPIO SUBSYSTEM" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Message-Id: In-Reply-To: <20250522085906.GA1199143@google.com> References: <20250515-smc-6-15-v6-0-c47b1ef4b0ae@svenpeter.dev> <20250515-smc-6-15-v6-5-c47b1ef4b0ae@svenpeter.dev> <20250522085906.GA1199143@google.com> Subject: Re: [PATCH v6 05/10] mfd: Add Apple Silicon System Management Controller Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, On Thu, May 22, 2025, at 10:59, Lee Jones wrote: > On Thu, 15 May 2025, Sven Peter via B4 Relay wrote: > >> From: Sven Peter >> >> The System Management Controller (SMC) on Apple Silicon machines is a >> piece of hardware that exposes various functionalities such as >> temperature sensors, voltage/power meters, shutdown/reboot handling, >> GPIOs and more. >> >> Communication happens via a shared mailbox using the RTKit protocol >> which is also used for other co-processors. The SMC protocol then allows >> reading and writing many different keys which implement the various >> features. The MFD core device handles this protocol and exposes it >> to the sub-devices. >> >> Some of the sub-devices are potentially also useful on pre-M1 Apple >> machines and support for SMCs on these machines can be added at a later >> time. >> >> Co-developed-by: Hector Martin >> Signed-off-by: Hector Martin >> Reviewed-by: Alyssa Rosenzweig >> Reviewed-by: Neal Gompa >> Signed-off-by: Sven Peter >> --- >> MAINTAINERS | 2 + >> drivers/mfd/Kconfig | 18 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/macsmc.c | 498 +++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/mfd/macsmc.h | 279 +++++++++++++++++++++++++ >> 5 files changed, 798 insertions(+) > > Arghhh, so close! > > [...] > >> +static struct platform_driver apple_smc_driver = { >> + .driver = { >> + .name = "mfd-macsmc", > > Drop the 'mfd-' part please. Ack. > >> + .of_match_table = apple_smc_of_match, >> + }, >> + .probe = apple_smc_probe, >> +}; >> +module_platform_driver(apple_smc_driver); >> + >> +MODULE_AUTHOR("Hector Martin "); >> +MODULE_AUTHOR("Sven Peter "); >> +MODULE_LICENSE("Dual MIT/GPL"); >> +MODULE_DESCRIPTION("Apple SMC driver"); > > I plan to apply this set after the merge-window. > > What else are you waiting on? The only thing missing is a review/ack from the power/reset maintainers. I will send v7 after the merge window rebased on -rc1 then. Thanks, Sven