From: Jiri Slaby <jirislaby@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
peterz@infradead.org, linux-kernel@vger.kernel.org,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Mike Rapoport <rppt@kernel.org>,
Pengfei Xu <pengfei.xu@intel.com>,
John Allen <john.allen@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] x86: Let AS_WRUSS depend on X86_64
Date: Tue, 31 Oct 2023 15:10:38 +0100 [thread overview]
Message-ID: <c9f43a23-9202-41f3-b8fb-bf48f74e8a1e@kernel.org> (raw)
In-Reply-To: <20231031140504.GCZUEJkMPXSrEDh3MA@fat_crate.local>
On 31. 10. 23, 15:05, Borislav Petkov wrote:
> On Tue, Oct 31, 2023 at 02:59:39PM +0100, Jiri Slaby wrote:
>> As I wrote, we have a config which maintainers feed through oldconfig when
>> updating the kernel. This time we got WRUSS=y. It was stored in git and
>> later passed to build the kernel. And we received a different config from
>> the build (WRUSS=n).
>>
>> We diff the two and error out if the built kernel differs from the passed
>> configuration. Which is the case here.
>
> I sure hope that diffing script can ignore Kconfig items.
Definitely, I can add an ignore on that level.
> Because this
> doesn't sound like a reason to "fix" the upstream kernel and as Masahiro
> says, it doesn't change anything anyway.
It changes what's in .config and corresponds 1:1 to what is used during
the build.
Now, I have a .config from "make oldconfig". But "make all" will read it
and flips the value. (That is IMHO misleading, but I can live with that,
provided I now know. Not sure about others though.)
thanks,
--
js
suse labs
next prev parent reply other threads:[~2023-10-31 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 10:21 [PATCH] x86: Let AS_WRUSS depend on X86_64 Jiri Slaby (SUSE)
2023-10-31 11:25 ` Borislav Petkov
2023-10-31 12:20 ` Masahiro Yamada
2023-10-31 13:34 ` Borislav Petkov
2023-10-31 13:59 ` Jiri Slaby
2023-10-31 14:05 ` Borislav Petkov
2023-10-31 14:10 ` Jiri Slaby [this message]
2023-10-31 13:53 ` Dave Hansen
2023-10-31 14:04 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f43a23-9202-41f3-b8fb-bf48f74e8a1e@kernel.org \
--to=jirislaby@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=john.allen@amd.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=pengfei.xu@intel.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox