From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2DDEC433FE for ; Fri, 21 Oct 2022 19:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbiJUTLN (ORCPT ); Fri, 21 Oct 2022 15:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiJUTLJ (ORCPT ); Fri, 21 Oct 2022 15:11:09 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B298257618 for ; Fri, 21 Oct 2022 12:11:06 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id by36so5010041ljb.4 for ; Fri, 21 Oct 2022 12:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q9N0quDGynabuTnZpTH6+L+PseJlLMHF0ftpq0x+i50=; b=ivJnr3EVAaMbX/61XT9Fla7Vz4RzD/bdgG0NFNWNPvmqymlecs7UvVuOneEF3LGdH5 yMmishz/tlU6bbaO4oztwg4OJ7zO3pOb0/BYueOK+lc57zJoNu99JkYAfICUqGXDSBIN GWJG/Vid6uT5K0KDGrwuxX0HxceB/4U2mHwx7SjxY5ucX4aqOAi6DDN3B8M7zMR95Djd 8xr6CBymWaOTplhYIa1fgjAEPZwLqGXpP+fuvnfna2WOms7MkOjR1Wc2XkQE+7w+mFKZ jSQJqaPdouyIJoVGdcNanb1ZG/5oTv1DeinUCUPq3uNIvKWDF60NOkRnznkhd1i9o/fp DTwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q9N0quDGynabuTnZpTH6+L+PseJlLMHF0ftpq0x+i50=; b=l0edRObbFdxz9W4MY5T8H+FdBWEA0RYQVxMm6Pdh1YK4xLxQ5IB7xYhRlf9+YX2WlN P3KWMR4BdT6XEG5TCTLNrqUPtxmKewjpD+nKps3mIUnOpEBGq/tuqLHK42csagcBa3tP miKrjTEpw77kBlVfo7VHxH2Z9W4hMHh1uyPCDjVW0y+IUaVwXyQjGqMNSpRVbFQg/Dnp UaEDw6N3ev7SKJgvKvK9BCKoRvomWzSm2bpaQFngUTSD43102rn+e3mJlWQNeqf8ylsK iCW9aN6TqTF61Zodid7/CgtlVwiLxDhjVIiD5A/SQxLCICe5joS4x5txj4afcWPAq0Zx uJHw== X-Gm-Message-State: ACrzQf0izdwvhouPXXZrNytTicOHuFcByV1nYwmc8ukuNc5hkodUxnDo OO4KX3dXUdeMq+StNwtzot96ALGQPQ6ZvQ== X-Google-Smtp-Source: AMsMyM7Om9Qo99zfePmjfmWjdKbj+bCXywZjrwsrk5ZvhWF4xm1XxXNXvV8YGUWm8+TmpewkgEdfzA== X-Received: by 2002:a17:907:7f1c:b0:78d:ddc7:dfb1 with SMTP id qf28-20020a1709077f1c00b0078dddc7dfb1mr17382708ejc.189.1666379453437; Fri, 21 Oct 2022 12:10:53 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:25b:e73e:85eb:ae6e? ([2a05:6e02:1041:c10:25b:e73e:85eb:ae6e]) by smtp.googlemail.com with ESMTPSA id fe7-20020a056402390700b004587c2b5048sm14014709edb.52.2022.10.21.12.10.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 12:10:52 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 21:10:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RESEND PATCH 2/2] thermal: qcom: tsens: simplify debugfs init function Content-Language: en-US To: Christian Marangi Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Zhang Rui , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20221021181906.16647-1-ansuelsmth@gmail.com> <20221021181906.16647-2-ansuelsmth@gmail.com> <6352eb65.050a0220.3eb5e.14c7@mx.google.com> From: Daniel Lezcano In-Reply-To: <6352eb65.050a0220.3eb5e.14c7@mx.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/10/2022 20:56, Christian Marangi wrote: [ ... ] > Hi, > thanks for the review! I have to be honest and do not create some fake > excuse for this. This patch is a bit old and was pending from a long > time so out of despair i just tried to RESEND this hoping someone would > pick it up. And it seems it have worked... Sooo sorry for making you > asking this. > > On rechecking the change here, the entire debug_init logic seems > wrong... I don't know if it's possible but what if in the system there > are multiple version of tsens istance? Looks wrong to overwrite the > version with the last one... It sounds not logical to have different versions, a quick look at the DT seems to confirm this. However, it is an assumption and it may be safer to assume the opposite can happen > I think the original idea of this was to create a directory for each > istance and put in there version and sensors debugfs. > > I will propose this in the next version if it's ok for you and you agree > with this logic. Also I think I will split this in 2 different patch one > for the version fixup and one for this new logic. I don't have a strong opinion on that but it seems reasonable > Waiting for your feedback and again sorry for the noise. No worries ;) >>> debugfs_create_file("sensors", 0444, priv->debug, pdev, &dbg_sensors_fops); >>> } >>> #else >> >> >> -- >> Linaro.org │ Open source software for ARM SoCs >> >> Follow Linaro: Facebook | >> Twitter | >> Blog > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog