From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrej Picej <andrej.picej@norik.com>, linux-watchdog@vger.kernel.org
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, Anson.Huang@nxp.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode
Date: Tue, 25 Oct 2022 09:48:57 -0400 [thread overview]
Message-ID: <ca484809-07e4-44ca-0ab3-26947bda7fa8@linaro.org> (raw)
In-Reply-To: <20221025072533.2980154-3-andrej.picej@norik.com>
On 25/10/2022 03:25, Andrej Picej wrote:
> Property "fsl,suspend-in-wait" suspends watchdog in "WAIT" mode which
> corresponds to Linux's Suspend-to-Idle S0 mode. If this property is not
> set and the device is put into Suspend-to-Idle mode, the watchdog
> triggers a reset after 128 seconds.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes in v2:
> - add a commit message,
> - add a list of devices which support this functionality
> ---
> .../bindings/watchdog/fsl-imx-wdt.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index fb7695515be1..9289de97859b 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -55,6 +55,28 @@ properties:
> If present, the watchdog device is configured to assert its
> external reset (WDOG_B) instead of issuing a software reset.
>
> + fsl,suspend-in-wait:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: |
> + If present, the watchdog device is suspended in WAIT mode
> + (Suspend-to-Idle). Only supported on following devices:
> + - "fsl,imx25-wdt",
You need to define such allow/disallow in allOf:if:then, instead. Like
example-schema is doing for foo-supply, just disallow it for some types
or use "if: not: ..."
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-25 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 7:25 [PATCH v2 0/3] Suspending i.MX watchdog in WAIT mode Andrej Picej
2022-10-25 7:25 ` [PATCH v2 1/3] watchdog: imx2_wdg: suspend " Andrej Picej
2022-10-25 9:38 ` Alexander Stein
2022-10-25 11:21 ` Andrej Picej
2022-10-26 6:01 ` Alexander Stein
2022-10-26 7:03 ` Andrej Picej
2022-10-25 12:27 ` Marco Felsch
2022-10-25 13:01 ` Andrej Picej
2022-10-25 14:21 ` Guenter Roeck
2022-10-26 6:59 ` Andrej Picej
2022-10-25 7:25 ` [PATCH v2 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Andrej Picej
2022-10-25 13:48 ` Krzysztof Kozlowski [this message]
2022-10-26 6:38 ` Andrej Picej
2022-10-26 14:12 ` Krzysztof Kozlowski
2022-10-27 7:16 ` Andrej Picej
2022-10-25 7:25 ` [PATCH v2 3/3] ARM: dts: imx6ul/ull: suspend i.MX6UL watchdog " Andrej Picej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca484809-07e4-44ca-0ab3-26947bda7fa8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=andrej.picej@norik.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox