From: Markus Elfring <Markus.Elfring@web.de>
To: make24@iscas.ac.cn, netdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>, Simon Horman <horms@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Vladimir Oltean <olteanv@gmail.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] net: dsa: Fix error handling in dsa_port_parse_of
Date: Sat, 22 Nov 2025 20:58:12 +0100 [thread overview]
Message-ID: <ca517274-9238-4f76-98c5-2fd31276d64f@web.de> (raw)
In-Reply-To: <20251121035130.16020-1-make24@iscas.ac.cn>
…
> returned structure, which should be balanced with a corresponding
> put_device() when the reference is no longer needed.
…
* Would a corresponding imperative wording become helpful for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94
* How do you think about to omit an extra check for the variable “err”
in the affected if branch because it can always be returned here?
* Would it be helpful to append parentheses to the function name in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2025-11-22 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 3:51 [PATCH] net: dsa: Fix error handling in dsa_port_parse_of Ma Ke
2025-11-21 13:40 ` Andrew Lunn
2025-11-21 18:07 ` kernel test robot
2025-11-21 19:13 ` kernel test robot
2025-11-22 19:58 ` Markus Elfring [this message]
2025-11-23 6:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca517274-9238-4f76-98c5-2fd31276d64f@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox