From: Roman Kisel <romank@linux.microsoft.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-hyperv@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
apais@microsoft.com, benhill@microsoft.com,
sunilmut@microsoft.com
Subject: Re: [PATCH hyperv-next] scsi: storvsc: Don't call the packet status the hypercall status
Date: Fri, 28 Feb 2025 14:02:38 -0800 [thread overview]
Message-ID: <ca615c23-fa9a-4cb3-b2bf-150fca2047ef@linux.microsoft.com> (raw)
In-Reply-To: <40d016eb-e701-4872-b0bc-f5ba34093a53@linux.microsoft.com>
On 2/28/2025 12:21 PM, Easwar Hariharan wrote:
> On 2/27/2025 3:31 PM, Roman Kisel wrote:
>> The log statement reports the packet status code as the hypercall
>> status code which causes confusion when debugging.
>>
>> Fix the name of the datum being logged.
>>
>> Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
>> ---
>> drivers/scsi/storvsc_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
>> index a8614e54544e..d7ec79536d9a 100644
>> --- a/drivers/scsi/storvsc_drv.c
>> +++ b/drivers/scsi/storvsc_drv.c
>> @@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device,
>> STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR;
>>
>> storvsc_log_ratelimited(device, loglevel,
>> - "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n",
>> + "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x sts 0x%x\n",
>
> I'd suggest using "host" than the opaque "sts", since this is already part of the different
> levels of status (scsi, srb...) being printed out. With "host", for e.g. the print would be seen
> as the following and clearly point out the offending part of the stack.
>
> hv_storvsc fd1d2cbd-ce7c-535c-966b-eb5f811c95f0: tag#599 cmd 0x28 status: scsi 0x2 srb 0x4 host 0xc0000001
I went with the flow calling this "sts": the rest of the file does that.
Your suggestion is better than that, will implement in the next version.
Appreciate your help very much!
>
> Thanks,
> Easwar (he/him)
--
Thank you,
Roman
next prev parent reply other threads:[~2025-02-28 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 23:31 [PATCH hyperv-next] scsi: storvsc: Don't call the packet status the hypercall status Roman Kisel
2025-02-28 20:21 ` Easwar Hariharan
2025-02-28 22:02 ` Roman Kisel [this message]
2025-02-28 20:55 ` Michael Kelley
2025-02-28 22:54 ` Roman Kisel
2025-02-28 23:53 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca615c23-fa9a-4cb3-b2bf-150fca2047ef@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=apais@microsoft.com \
--cc=benhill@microsoft.com \
--cc=decui@microsoft.com \
--cc=eahariha@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sunilmut@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox