From: Konstantin Shkolnyy <kshk@linux.ibm.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mjrosato@linux.ibm.com
Subject: Re: [PATCH] vsock/test: fix failures due to wrong SO_RCVLOWAT parameter
Date: Thu, 24 Oct 2024 10:00:47 -0500 [thread overview]
Message-ID: <ca6702e0-bdd9-4ab7-8fbc-e8b0404c9ed5@linux.ibm.com> (raw)
In-Reply-To: <k5otzhemrqeau7iilr6j42ytasddatbx53godcm2fm6zckevti@nqnetgj6odmb>
On 10/24/2024 03:43, Stefano Garzarella wrote:
> Other setsockopt() in the tests where we use unsigned long are
> SO_VM_SOCKETS_* but they are expected to be unsigned, so we should be
> fine.
It's actually not "signed vs unsigned", but a "size + endianess" problem.
Also, looking at SO_VM_SOCKETS_* code in the test, it uses unsigned long
and size_t which (I believe) will both shrink to 4 bytes on 32-bit
machines, while the corresponding kernel code in af_vsock.c uses u64. It
looks to me that this kernel code will be unhappy to receive just 4
bytes when it expects 8.
next prev parent reply other threads:[~2024-10-24 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 21:00 [PATCH] vsock/test: fix failures due to wrong SO_RCVLOWAT parameter Konstantin Shkolnyy
2024-10-24 8:43 ` Stefano Garzarella
2024-10-24 15:00 ` Konstantin Shkolnyy [this message]
2024-10-24 15:21 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca6702e0-bdd9-4ab7-8fbc-e8b0404c9ed5@linux.ibm.com \
--to=kshk@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox