The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Xin Gao <gaoxin@cdjrlc.com>,
	daniel@zonque.org, haojian.zhuang@gmail.com,
	robert.jarzmik@free.fr
Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Fix double word in comments
Date: Tue, 16 Aug 2022 00:21:12 +0100	[thread overview]
Message-ID: <ca6e9b7c-416d-dac4-7855-aa22fde3ef8c@arm.com> (raw)
In-Reply-To: <20220815200051.4001-1-gaoxin@cdjrlc.com>

On 2022-08-15 21:00, Xin Gao wrote:
> Delete repeated word "in" in comments.

It is not grammatically incorrect though. The second "in" is the 
preposition here, while the first is an adverb - "fill in" is a term in 
its own right, particularly in the context of information, whereas 
"fill" tends to suggest a more physical context. For instance, one might 
typically say "I filled the bottle" (with liquid), but "I filled in the 
application form" (with data).

Robin.

> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>   arch/arm/mach-pxa/palm27x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c
> index 1a8d25eecac3..116183859357 100644
> --- a/arch/arm/mach-pxa/palm27x.c
> +++ b/arch/arm/mach-pxa/palm27x.c
> @@ -160,7 +160,7 @@ void __init palm27x_lcd_init(int power, struct pxafb_mode_info *mode)
>   #if	defined(CONFIG_USB_PXA27X) || \
>   	defined(CONFIG_USB_PXA27X_MODULE)
>   
> -/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
> +/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
>   static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
>   	.dev_id = "gpio-vbus",
>   	.table = {

  reply	other threads:[~2022-08-16  2:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 20:00 [PATCH] ARM: Fix double word in comments Xin Gao
2022-08-15 23:21 ` Robin Murphy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-29  7:18 [PATCH] arm: " Bo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca6e9b7c-416d-dac4-7855-aa22fde3ef8c@arm.com \
    --to=robin.murphy@arm.com \
    --cc=daniel@zonque.org \
    --cc=gaoxin@cdjrlc.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox