From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31EA640BCA9 for ; Thu, 9 Jul 2026 10:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593977; cv=none; b=TaBsPIrXtHa0EVjX1/7QtU2nPU9Y1GXWK4dyY/mIFvWitZksgjaSSSdxmndA0mS8hV8/lYu90PJdPvN9p4uV/21k8oJssqP2d4Dg8TK/y+bWKhQW/RdGKY9mBvOlS34SnrpyE7ylHm3E+G2IKxUf67XaAZqIs8PKMxOmr+iN5/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783593977; c=relaxed/simple; bh=ALw1vDHV5L4nvGbJoc+jSU8mWvhkA4JdMp1Q/Jp5JGw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U+xoFX3o/BXz6Ni02r+5b1hKgBXPB3gUuUJntNthtjk85VB8CI1QYOhyj1CLJst/THzAIleS9izAaDhNMS7UZSPGE/n3WCtZdooJnPkExc5+7r+4yF7q93L7Iyzq4yFdV/RGq80C+gUsOShKXiSd8AUl2WZPAMjO4+AEeEzDvAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aFiscW7w; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ecF1zYb7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aFiscW7w"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ecF1zYb7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783593971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I49PQ9PyUdCuLERxmFaB0ytRW4SbKdB8bINg9r85uDU=; b=aFiscW7wyFQ9UqB1YgZHk2LV5E5u8a13c4dLfgM5GaFnV7kgCh6iK5mOOrgmHjgnKsL3/w xaBMGWSnqE0T6c2bderXgTbcp7WwIyqW2lWENG69uwu7uxfRa/REUu78W62G98N+4PVM6G DxTQk0UOIXbScPRwsjVXtWaQgF8JazE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-hQfWrUxQOUCE-ONJrgEcsQ-1; Thu, 09 Jul 2026 06:46:08 -0400 X-MC-Unique: hQfWrUxQOUCE-ONJrgEcsQ-1 X-Mimecast-MFC-AGG-ID: hQfWrUxQOUCE-ONJrgEcsQ_1783593967 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-475e540a0ffso417429f8f.3 for ; Thu, 09 Jul 2026 03:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783593967; x=1784198767; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=I49PQ9PyUdCuLERxmFaB0ytRW4SbKdB8bINg9r85uDU=; b=ecF1zYb7w3M4xqQYWX9RKP8KMzzL4+bUF0n5t9qxP9i1nFdFw9i4d/+QuB3HoFMjB/ 1q9lPrW5ekmrSyEequpx6aNt+Abax7MBnR7o8/34prZ64axx+t5m9r1jj1sWBTEh+Ufz 0OKqaEpnlQxR2tDTR7mfORPRXAtBz7q2qmWNbXnnDpLZmVvmUdS5Af3Wp4t1g/xVO3Cp bjhw/+Lmd2+w2F8F5aqg15aKDMUW3V2uQ9JCRCdukge7RhxEpa1oWsTWpZV534CLp4zq ngtRJCEwTbagSM1Blyaj3Pwm6ECQCqZkk0h4grsl65YFckPzKzl9BJV/TalHjrI6zPBA pnEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783593967; x=1784198767; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I49PQ9PyUdCuLERxmFaB0ytRW4SbKdB8bINg9r85uDU=; b=h7aLyJ1O1t3fyxFSLionUdG6pk4xV1OQa9RlSVyILSmlrfOFFYlxpHemqzFAqo7qlK fxj2qMRdaz8Y+llI0cUMDSigP0KQzwcgTSVgFRYIX9fDYDwI9Dfx+5mlVnSPAC9CSYLs hbn5sYG/tqB77JdZ6q3hDdgjk8P0Uz/SyqZUjNCmUzX/0U1V7mMx/blR8EFWP/cYdbdl N8x165bXiI0mw/L7WbRfEURaNSXYC84Tnd8LwDXC6SccDQDr3t3j+oK+/rATR8arF8Hw FzkELo0jbXogJauspi2Ap5sEY/Ia8lTKsTEb0MrZuRJKqTmsQgG6dj3r3k5/oGs/dU/Z jwvQ== X-Forwarded-Encrypted: i=1; AHgh+Rof9jzUC5uBVYQ0eZeFb7hVSkGtywI1YU6i9Iz13cLucbm0F9U0Tm9VLZC+tPIeghPL0miHJFo24ycDLVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzfGLpVZ3aR2UReFYAiojCSCV//W3I/r1pCbxof7HuDrURv5fth VkWkIZzCOII9EkeFKEACWucQucYVO57wsZZeTvV5OGwq0AQWTx+xpWE8I385CbXK6aPDak2+ThM Xk759VxUqICUQwoAQG4B8nNwcSXRvzwg1rY06UJBSvurxpl0BHi4MpMXMsqsp3pQa+Q== X-Gm-Gg: AfdE7clixrqbgOFQRrP6Y/OvSu9aYCezSq1/wMXPbyYUDLovcRRz008ucrOQQmIlmtY JQj/Se6UI4bCYY7SW+l4U6wzP/iUI8Uz39YpbR9WnpF5aVV1zeKTzFTTBkR/0LM1QgBe+TqN4vM QtLLT0WYq6KevRpj9GvpgZA2o4judgyesAQxAvqZe71cefpoQBVzfe2TMudC9i+UgINL+8dCRuL NkiXdkYSYkwTRBebrMhXNNhrH5XQM311TRtFrVC2jhdZHdvmoY1VvxeEajq1Isf+FygMpaohF5N nIZdv9CBZJOP9wLnFDHiZFNDjufn2dXqtejcZ17nRax2wwBtyz7KlKJxBAVu4wpllf2EvdITcKH 4rSpWh0udHYrR+QjJlMHC33f3aVq2YHoaefUq2vkcAlmIUCxiDQJKlL4gCZlKAq/dN5LKfswElS VQ4NW8vdwIQQR/ X-Received: by 2002:a5d:5f50:0:b0:47b:69a5:7263 with SMTP id ffacd0b85a97d-47df071c18fmr7139201f8f.5.1783593966983; Thu, 09 Jul 2026 03:46:06 -0700 (PDT) X-Received: by 2002:a5d:5f50:0:b0:47b:69a5:7263 with SMTP id ffacd0b85a97d-47df071c18fmr7139165f8f.5.1783593966534; Thu, 09 Jul 2026 03:46:06 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960634sm51419282f8f.26.2026.07.09.03.46.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 03:46:06 -0700 (PDT) Message-ID: Date: Thu, 9 Jul 2026 12:46:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] dibs: loopback: validate offset and size in move_data() To: Andrew Lunn , Dust Li Cc: Alexandra Winter , Wenjia Zhang , Wen Gu , Mahanta Jambigi , "D . Wythe" , Sidraya Jayagond , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Federico Kirschbaum References: <20260707074318.1448662-1-dust.li@linux.alibaba.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/7/26 8:31 PM, Andrew Lunn wrote: > On Tue, Jul 07, 2026 at 10:31:00PM +0800, Dust Li wrote: >> On 2026-07-07 15:43:18, Dust Li wrote: >>> The loopback move_data() performs a memcpy into the registered DMB >>> without checking whether offset + size exceeds the DMB length. Unlike >>> real ISM hardware, which enforces memory region bounds natively, the >>> software loopback has no such protection. >>> >>> A peer-supplied out-of-bounds offset or oversized write would result in >>> an OOB write past the allocated kernel buffer. Add an explicit bounds >>> check before the memcpy to reject such requests with -EINVAL. >>> >>> Fixes: f7a22071dbf3("net/smc: implement DMB-related operations of loopback-ism") >>> Cc: stable@vger.kernel.org >>> Reported-by: Federico Kirschbaum >> >> Reported-by: Baul Lee > > Could you provide a link to the report? Since both reporters belong to the same org, I assume they co-partecipated at the initial report. Also there is a problem with the fixes tag that I'll address while applying the patch. /P