[PATCH v1 0/8] Enable video decoder & encoder for MT8189

[PATCH v1 0/8] Enable video decoder & encoder for MT8189

[Kyrie Wu]

This series have the follow changing:
Firstly add mt8189 video decoder compatible, profile and level to support
MT8189 kernel driver.
Secondly fix some bugs, including vp 4K profile2 and media device node
number bug.
Lastly, add mt8189 video encoder compatible.

This series has been tested with MT8189 tast test.
Encoding and decoding worked for this chip.

Patches 1-2 Add decoder compatible.
Patches 3 Add profile and level supporting.
Patches 4 Add core-only VP9 decoding supporting.
Patches 5-6 fix some bugs.
Patches 7-8 Adds encoder compatible.

---
This series patches dependent on:
[1]
https://patchwork.linuxtv.org/project/linux-media/cover/20250510075357.11761-1-yunfei.dong@mediatek.com/
[2]
https://patchwork.linuxtv.org/project/linux-media/cover/20250528063633.14054-1-irui.wang@mediatek.com/

Kyrie Wu (8):
  dt-bindings: media: mediatek: decoder: Add MT8189
    mediatek,vcodec-decoder
  media: mediatek: vcodec: add decoder compatible to support MT8189
  media: mediatek: vcodec: add profile and level supporting for MT8189
  media: mediatek: vcodec: Add core-only VP9 decoding support for MT8189
  media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2
  media: mediatek: vcodec: fix media device node number
  dt-bindings: media: Add MT8189 mediatek,vcodec-encoder
  media: mediatek: encoder: Add MT8189 encoder compatible data

 .../media/mediatek,vcodec-encoder.yaml        |  2 ++
 .../media/mediatek,vcodec-subdev-decoder.yaml |  1 +
 .../vcodec/decoder/mtk_vcodec_dec_drv.c       |  9 +++++-
 .../vcodec/decoder/mtk_vcodec_dec_drv.h       |  1 +
 .../vcodec/decoder/mtk_vcodec_dec_stateless.c |  4 +++
 .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 32 ++++++++++++-------
 .../vcodec/encoder/mtk_vcodec_enc_drv.c       | 14 ++++++++
 7 files changed, 50 insertions(+), 13 deletions(-)

-- 
2.46.0

[PATCH v1 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder

[Kyrie Wu]

Add compatible for video decoder on MT8189 platform, which is a
pure single core architecture.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../bindings/media/mediatek,vcodec-subdev-decoder.yaml           | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
index 74e1d88d3056..1bb5a2485e4c 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
@@ -77,6 +77,7 @@ properties:
       - mediatek,mt8188-vcodec-dec
       - mediatek,mt8195-vcodec-dec
       - mediatek,mt8196-vcodec-dec
+      - mediatek,mt8189-vcodec-dec
 
   reg:
     minItems: 1
-- 
2.46.0

Re: [PATCH v1 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder

[Krzysztof Kozlowski]

On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
> Add compatible for video decoder on MT8189 platform, which is a
> pure single core architecture.

Looks compatible with existing ones and nothing in commit msg explains
why it was not made compatible. Describe the hardware, say something
useful to avoid such questions.

Best regards,
Krzysztof

Re: [PATCH v1 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder

[Kyrie Wu (吴晗)]

On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
> > Add compatible for video decoder on MT8189 platform, which is a
> > pure single core architecture.
> 
> Looks compatible with existing ones and nothing in commit msg
> explains
> why it was not made compatible. Describe the hardware, say something
> useful to avoid such questions.
> 
> Best regards,
> Krzysztof
> 
Dear Krzysztof,

There are two reasons for adding a new compatible string to MT8189:
On the one hand, MT8189 is a pure single-core hardware chip, so the
of_device_id data is different;
On the other hand, the correct chip name can be set through the
compatible strings;
The above two reasons are reflected in the following patch:

https://patchwork.linuxtv.org/project/linux-media/patch/20250721105520.5625-3-kyrie.wu@mediatek.com/

Thanks.

Regards,
Kyrie.

Re: [PATCH v1 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder

[Krzysztof Kozlowski]

On 22/07/2025 10:11, Kyrie Wu (吴晗) wrote:
> On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
>>> Add compatible for video decoder on MT8189 platform, which is a
>>> pure single core architecture.
>>
>> Looks compatible with existing ones and nothing in commit msg
>> explains
>> why it was not made compatible. Describe the hardware, say something
>> useful to avoid such questions.
>>
>> Best regards,
>> Krzysztof
>>
> Dear Krzysztof,
> 
> There are two reasons for adding a new compatible string to MT8189:
> On the one hand, MT8189 is a pure single-core hardware chip, so the
> of_device_id data is different;

Not relevant. Your of_device_id is wrong and based on that you claim the
hardware is different?

Describe the hardware.

Best regards,
Krzysztof

Re: [PATCH v1 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder

[Kyrie Wu (吴晗)]

On Tue, 2025-07-22 at 13:09 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 22/07/2025 10:11, Kyrie Wu (吴晗) wrote:
> > On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
> > > > Add compatible for video decoder on MT8189 platform, which is a
> > > > pure single core architecture.
> > > 
> > > Looks compatible with existing ones and nothing in commit msg
> > > explains
> > > why it was not made compatible. Describe the hardware, say
> > > something
> > > useful to avoid such questions.
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Dear Krzysztof,
> > 
> > There are two reasons for adding a new compatible string to MT8189:
> > On the one hand, MT8189 is a pure single-core hardware chip, so the
> > of_device_id data is different;
> 
> Not relevant. Your of_device_id is wrong and based on that you claim
> the
> hardware is different?
> 
> Describe the hardware.
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

Sorry for the misunderstanding in your reply. I will update the commit
messages in the next version of patchset to introduce the hardware
differences of MT8189.

In summary, compared with other ICs, the MT8189 encoder and decoder use
iommu instead of smmu, and use scp architecture, the frequency is only
406MHZ, and cannot reach more than 700MHZ. At the same time, the
decoder supports the vp9 decoding protocol for the first time.

Thanks.

Regards,
Kyrie.

[PATCH v1 2/8] media: mediatek: vcodec: add decoder compatible to support MT8189

[Kyrie Wu]

MT8189 is pure single core architecture. Support its compatible and
use `mtk_vdec_single_core_pdata` to initialize platform data.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c   | 6 ++++++
 .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h   | 1 +
 2 files changed, 7 insertions(+)

diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
index fabf969bc8a9..e7b6b108f4fb 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
@@ -348,6 +348,8 @@ static void mtk_vcodec_dec_get_chip_name(struct mtk_vcodec_dec_dev *vdec_dev)
 		vdec_dev->chip_name = MTK_VDEC_MT8188;
 	else if (of_device_is_compatible(dev->of_node, "mediatek,mt8196-vcodec-dec"))
 		vdec_dev->chip_name = MTK_VDEC_MT8196;
+	else if (of_device_is_compatible(dev->of_node, "mediatek,mt8189-vcodec-dec"))
+		vdec_dev->chip_name = MTK_VDEC_MT8189;
 	else
 		vdec_dev->chip_name = MTK_VDEC_INVAL;
 }
@@ -575,6 +577,10 @@ static const struct of_device_id mtk_vcodec_match[] = {
 		.compatible = "mediatek,mt8196-vcodec-dec",
 		.data = &mtk_lat_sig_core_pdata,
 	},
+	{
+		.compatible = "mediatek,mt8189-vcodec-dec",
+		.data = &mtk_vdec_single_core_pdata,
+	},
 	{},
 };
 
diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
index 6bdde600a167..856d12aa84d8 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
@@ -25,6 +25,7 @@ enum mtk_vcodec_dec_chip_name {
 	MTK_VDEC_MT8183 = 8183,
 	MTK_VDEC_MT8186 = 8186,
 	MTK_VDEC_MT8188 = 8188,
+	MTK_VDEC_MT8189 = 8189,
 	MTK_VDEC_MT8192 = 8192,
 	MTK_VDEC_MT8195 = 8195,
 	MTK_VDEC_MT8196 = 8196,
-- 
2.46.0

[PATCH v1 3/8] media: mediatek: vcodec: add profile and level supporting for MT8189

[Kyrie Wu]

add profile and level supporting for H264 and vp9 of MT8189

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c        | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
index c1cef78471a9..0a9bdc5316f9 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
@@ -552,6 +552,7 @@ static void mtk_vcodec_dec_fill_h264_level(struct v4l2_ctrl_config *cfg,
 	switch (ctx->dev->chip_name) {
 	case MTK_VDEC_MT8192:
 	case MTK_VDEC_MT8188:
+	case MTK_VDEC_MT8189:
 		cfg->max = V4L2_MPEG_VIDEO_H264_LEVEL_5_2;
 		break;
 	case MTK_VDEC_MT8195:
@@ -573,6 +574,7 @@ static void mtk_vcodec_dec_fill_h264_profile(struct v4l2_ctrl_config *cfg,
 {
 	switch (ctx->dev->chip_name) {
 	case MTK_VDEC_MT8188:
+	case MTK_VDEC_MT8189:
 	case MTK_VDEC_MT8195:
 	case MTK_VDEC_MT8196:
 		cfg->max = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH_10;
@@ -623,6 +625,7 @@ static void mtk_vcodec_dec_fill_vp9_level(struct v4l2_ctrl_config *cfg,
 	case MTK_VDEC_MT8188:
 		cfg->max = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1;
 		break;
+	case MTK_VDEC_MT8189:
 	case MTK_VDEC_MT8195:
 	case MTK_VDEC_MT8196:
 		cfg->max = V4L2_MPEG_VIDEO_VP9_LEVEL_5_2;
@@ -641,6 +644,7 @@ static void mtk_vcodec_dec_fill_vp9_profile(struct v4l2_ctrl_config *cfg,
 {
 	switch (ctx->dev->chip_name) {
 	case MTK_VDEC_MT8188:
+	case MTK_VDEC_MT8189:
 	case MTK_VDEC_MT8195:
 	case MTK_VDEC_MT8196:
 		cfg->max = V4L2_MPEG_VIDEO_VP9_PROFILE_2;
-- 
2.46.0

[PATCH v1 4/8] media: mediatek: vcodec: Add core-only VP9 decoding support for MT8189

[Kyrie Wu]

Implemented core-only VP9 decoding functions for MT8189.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 27 +++++++++++--------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
index fa0f406f7726..04197164fb82 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
@@ -23,6 +23,7 @@
 
 #define VP9_TILE_BUF_SIZE 4096
 #define VP9_PROB_BUF_SIZE 2560
+#define VP9_PROB_BUF_4K_SIZE 3840
 #define VP9_COUNTS_BUF_SIZE 16384
 
 #define HDR_FLAG(x) (!!((hdr)->flags & V4L2_VP9_FRAME_FLAG_##x))
@@ -616,7 +617,10 @@ static int vdec_vp9_slice_alloc_working_buffer(struct vdec_vp9_slice_instance *i
 	}
 
 	if (!instance->prob.va) {
-		instance->prob.size = VP9_PROB_BUF_SIZE;
+		instance->prob.size = ((ctx->dev->chip_name == MTK_VDEC_MT8196) ||
+				       (ctx->dev->chip_name == MTK_VDEC_MT8189)) ?
+					VP9_PROB_BUF_4K_SIZE : VP9_PROB_BUF_SIZE;
+
 		if (mtk_vcodec_mem_alloc(ctx, &instance->prob))
 			goto err;
 	}
@@ -696,21 +700,22 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
 	return min(offset, mi_num);
 }
 
-static
-int vdec_vp9_slice_setup_single_from_src_to_dst(struct vdec_vp9_slice_instance *instance)
+static int vdec_vp9_slice_setup_single_from_src_to_dst(struct vdec_vp9_slice_instance *instance,
+						       struct mtk_vcodec_mem *bs,
+						       struct vdec_fb *fb)
 {
-	struct vb2_v4l2_buffer *src;
-	struct vb2_v4l2_buffer *dst;
+	struct mtk_video_dec_buf *src_buf_info;
+	struct mtk_video_dec_buf *dst_buf_info;
 
-	src = v4l2_m2m_next_src_buf(instance->ctx->m2m_ctx);
-	if (!src)
+	src_buf_info = container_of(bs, struct mtk_video_dec_buf, bs_buffer);
+	if (!src_buf_info)
 		return -EINVAL;
 
-	dst = v4l2_m2m_next_dst_buf(instance->ctx->m2m_ctx);
-	if (!dst)
+	dst_buf_info = container_of(fb, struct mtk_video_dec_buf, frame_buffer);
+	if (!dst_buf_info)
 		return -EINVAL;
 
-	v4l2_m2m_buf_copy_metadata(src, dst, true);
+	v4l2_m2m_buf_copy_metadata(&src_buf_info->m2m_buf.vb, &dst_buf_info->m2m_buf.vb, true);
 
 	return 0;
 }
@@ -1800,7 +1805,7 @@ static int vdec_vp9_slice_setup_single(struct vdec_vp9_slice_instance *instance,
 	struct vdec_vp9_slice_vsi *vsi = &pfc->vsi;
 	int ret;
 
-	ret = vdec_vp9_slice_setup_single_from_src_to_dst(instance);
+	ret = vdec_vp9_slice_setup_single_from_src_to_dst(instance, bs, fb);
 	if (ret)
 		goto err;
 
-- 
2.46.0

[PATCH v1 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2

[Kyrie Wu]

The dram addr of vp9 decoder tile number, which use dram mode
to set tile information, may reach to 36bits for 4096x2176.
It needs to get the highest 4bit of tile buffer address to
set tile buffer address.

Fixes: 5d418351ca8f1 ("media: mediatek: vcodec: support stateless VP9 decoding")
Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c       | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
index 04197164fb82..416d8c0c04ce 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
@@ -1140,7 +1140,10 @@ static int vdec_vp9_slice_setup_tile_buffer(struct vdec_vp9_slice_instance *inst
 			tiles->size[i][j] = size;
 			if (tiles->mi_rows[i]) {
 				*tb++ = (size << 3) + ((offset << 3) & 0x7f);
-				*tb++ = pa & ~0xf;
+				*tb = pa & ~0xf;
+				if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT))
+					*tb |= (pa >> 32) & 0xf;
+				tb++;
 				*tb++ = (pa << 3) & 0x7f;
 				mi_row = (tiles->mi_rows[i] - 1) & 0x1ff;
 				mi_col = (tiles->mi_cols[j] - 1) & 0x3f;
-- 
2.46.0

[PATCH v1 6/8] media: mediatek: vcodec: fix media device node number

[Kyrie Wu]

change media register device node number to a correct value

Fixes: 41f03c673cb7b ("media: mediatek: vcodec: replace pr_* with dev_* for v4l2 debug message")
Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
index e7b6b108f4fb..bc0a66c26cda 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c
@@ -517,7 +517,8 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
 			goto err_media_reg;
 		}
 
-		dev_dbg(&pdev->dev, "media registered as /dev/media%d", vfd_dec->minor);
+		dev_dbg(&pdev->dev, "media registered as /dev/media%d",
+			dev->mdev_dec.devnode->minor);
 	}
 
 	mtk_vcodec_dbgfs_init(dev, false);
-- 
2.46.0

[PATCH v1 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

[Kyrie Wu]

Add MT8189 encoder compatible string, which will reference SCP device.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml      | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index 7675391d7eb0..faee838d684e 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -25,6 +25,7 @@ properties:
               - mediatek,mt8192-vcodec-enc
               - mediatek,mt8195-vcodec-enc
               - mediatek,mt8196-vcodec-enc
+              - mediatek,mt8189-vcodec-enc
       - items:
           - const: mediatek,mt8186-vcodec-enc
           - const: mediatek,mt8183-vcodec-enc
@@ -97,6 +98,7 @@ allOf:
               - mediatek,mt8188-vcodec-enc
               - mediatek,mt8192-vcodec-enc
               - mediatek,mt8195-vcodec-enc
+              - mediatek,mt8189-vcodec-enc
 
     then:
       required:
-- 
2.46.0

Re: [PATCH v1 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

[Krzysztof Kozlowski]

On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
> Add MT8189 encoder compatible string, which will reference SCP device.

And the device is not compatible or is different because of what?

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v1 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

[Kyrie Wu (吴晗)]

On Tue, 2025-07-22 at 09:26 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
> > Add MT8189 encoder compatible string, which will reference SCP
> > device.
> 
> And the device is not compatible or is different because of what?
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 
Dear Krzysztof,

The reason, adding a new compatible strings for the MT8189 encoder, is
same as for decoder, to use different of_device_id data and to
distinguish the chip name.

Thanks.

Regards,
Kyrie.

Re: [PATCH v1 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

[Krzysztof Kozlowski]

On 22/07/2025 10:16, Kyrie Wu (吴晗) wrote:
> On Tue, 2025-07-22 at 09:26 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
>>> Add MT8189 encoder compatible string, which will reference SCP
>>> device.
>>
>> And the device is not compatible or is different because of what?
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Best regards,
>> Krzysztof
>>
> Dear Krzysztof,
> 
> The reason, adding a new compatible strings for the MT8189 encoder, is
> same as for decoder, to use different of_device_id data and to
> distinguish the chip name.

You speak about drivers, this is not relevant. Explain the hardware -
WHY it is not compatible, what is the difference

Best regards,
Krzysztof

Re: [PATCH v1 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

[Kyrie Wu (吴晗)]

On Tue, 2025-07-22 at 13:09 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 22/07/2025 10:16, Kyrie Wu (吴晗) wrote:
> > On Tue, 2025-07-22 at 09:26 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
> > > > Add MT8189 encoder compatible string, which will reference SCP
> > > > device.
> > > 
> > > And the device is not compatible or is different because of what?
> > > 
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Dear Krzysztof,
> > 
> > The reason, adding a new compatible strings for the MT8189 encoder,
> > is
> > same as for decoder, to use different of_device_id data and to
> > distinguish the chip name.
> 
> You speak about drivers, this is not relevant. Explain the hardware -
> WHY it is not compatible, what is the difference
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

For encoder, the hardware differences are shown as follow:
Compared with MT8196, the maximum resolution of MT8189 encoder is only
4K, and the fps is only 30, which cannot reach the highest parameter of
MT8196: level6.2, 8K@60fps.
Compared with MT8188, the level can only support 5.1, which is less
than 5.2 of MT8188. But the maximum bitrate is 100Mbps, which is twice
that of MT8188.

The above informations will be updated to the commit messages in the
coming version.

Thanks.

Regards,
Kyire.

[PATCH v1 8/8] media: mediatek: encoder: Add MT8189 encoder compatible data

[Kyrie Wu]

add compatible data to support MT8189 encoding.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c   | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c
index c869c4245ebc..4f5c2d8d2855 100644
--- a/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c
@@ -468,6 +468,19 @@ static const struct mtk_vcodec_enc_pdata mt8196_pdata = {
 	.set_dma_bit_mask = true,
 };
 
+static const struct mtk_vcodec_enc_pdata mt8189_pdata = {
+	.venc_model_num = 8189,
+	.capture_formats = mtk_video_formats_capture_h264,
+	.num_capture_formats = ARRAY_SIZE(mtk_video_formats_capture_h264),
+	.output_formats = mtk_video_formats_output,
+	.num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
+	.min_bitrate = 64,
+	.max_bitrate = 100000000,
+	.core_id = VENC_SYS,
+	.uses_common_fw_iface = true,
+	.set_dma_bit_mask = true,
+};
+
 static const struct of_device_id mtk_vcodec_enc_match[] = {
 	{.compatible = "mediatek,mt8173-vcodec-enc",
 			.data = &mt8173_avc_pdata},
@@ -478,6 +491,7 @@ static const struct of_device_id mtk_vcodec_enc_match[] = {
 	{.compatible = "mediatek,mt8192-vcodec-enc", .data = &mt8192_pdata},
 	{.compatible = "mediatek,mt8195-vcodec-enc", .data = &mt8195_pdata},
 	{.compatible = "mediatek,mt8196-vcodec-enc", .data = &mt8196_pdata},
+	{.compatible = "mediatek,mt8189-vcodec-enc", .data = &mt8189_pdata},
 	{},
 };
 MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);
-- 
2.46.0

Re: [PATCH v1 0/8] Enable video decoder & encoder for MT8189

[Nicolas Dufresne]

[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]

Hi,

Le lundi 21 juillet 2025 à 18:55 +0800, Kyrie Wu a écrit :
> This series have the follow changing:
> Firstly add mt8189 video decoder compatible, profile and level to support
> MT8189 kernel driver.
> Secondly fix some bugs, including vp 4K profile2 and media device node
> number bug.
> Lastly, add mt8189 video encoder compatible.

Since its a new hardware, please provide v4l2-compliance test results along with
relevant fluster result for the decoder part. Please also provide a link to your
submission of the related SCP firmware to the linux-firmware project. This way I
don't have to ask if/when the firmware will land.

cheers,
Nicolas

> 
> This series has been tested with MT8189 tast test.
> Encoding and decoding worked for this chip.
> 
> Patches 1-2 Add decoder compatible.
> Patches 3 Add profile and level supporting.
> Patches 4 Add core-only VP9 decoding supporting.
> Patches 5-6 fix some bugs.
> Patches 7-8 Adds encoder compatible.
> 
> ---
> This series patches dependent on:
> [1]
> https://patchwork.linuxtv.org/project/linux-media/cover/20250510075357.11761-1-yunfei.dong@mediatek.com/
> [2]
> https://patchwork.linuxtv.org/project/linux-media/cover/20250528063633.14054-1-irui.wang@mediatek.com/
> 
> Kyrie Wu (8):
>   dt-bindings: media: mediatek: decoder: Add MT8189
>     mediatek,vcodec-decoder
>   media: mediatek: vcodec: add decoder compatible to support MT8189
>   media: mediatek: vcodec: add profile and level supporting for MT8189
>   media: mediatek: vcodec: Add core-only VP9 decoding support for MT8189
>   media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2
>   media: mediatek: vcodec: fix media device node number
>   dt-bindings: media: Add MT8189 mediatek,vcodec-encoder
>   media: mediatek: encoder: Add MT8189 encoder compatible data
> 
>  .../media/mediatek,vcodec-encoder.yaml        |  2 ++
>  .../media/mediatek,vcodec-subdev-decoder.yaml |  1 +
>  .../vcodec/decoder/mtk_vcodec_dec_drv.c       |  9 +++++-
>  .../vcodec/decoder/mtk_vcodec_dec_drv.h       |  1 +
>  .../vcodec/decoder/mtk_vcodec_dec_stateless.c |  4 +++
>  .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 32 ++++++++++++-------
>  .../vcodec/encoder/mtk_vcodec_enc_drv.c       | 14 ++++++++
>  7 files changed, 50 insertions(+), 13 deletions(-)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH v1 0/8] Enable video decoder & encoder for MT8189

[Kyrie Wu (吴晗)]

On Mon, 2025-07-28 at 16:31 -0400, Nicolas Dufresne wrote:
> Hi,
> 
> Le lundi 21 juillet 2025 à 18:55 +0800, Kyrie Wu a écrit :
> > This series have the follow changing:
> > Firstly add mt8189 video decoder compatible, profile and level to
> > support
> > MT8189 kernel driver.
> > Secondly fix some bugs, including vp 4K profile2 and media device
> > node
> > number bug.
> > Lastly, add mt8189 video encoder compatible.
> 
> Since its a new hardware, please provide v4l2-compliance test results
> along with
> relevant fluster result for the decoder part. Please also provide a
> link to your
> submission of the related SCP firmware to the linux-firmware project.
> This way I
> don't have to ask if/when the firmware will land.
> 
> cheers,
> Nicolas

Dear Nicolas,

I will provide v4l2-compliance test results and SCP firmware upstream
link in the next version.

Thanks.

Regards,
Kyire.
> 
> > 
> > This series has been tested with MT8189 tast test.
> > Encoding and decoding worked for this chip.
> > 
> > Patches 1-2 Add decoder compatible.
> > Patches 3 Add profile and level supporting.
> > Patches 4 Add core-only VP9 decoding supporting.
> > Patches 5-6 fix some bugs.
> > Patches 7-8 Adds encoder compatible.
> > 
> > ---
> > This series patches dependent on:
> > [1]
> > 
https://patchwork.linuxtv.org/project/linux-media/cover/20250510075357.11761-1-yunfei.dong@mediatek.com/
> > [2]
> > 
https://patchwork.linuxtv.org/project/linux-media/cover/20250528063633.14054-1-irui.wang@mediatek.com/
> > 
> > Kyrie Wu (8):
> >   dt-bindings: media: mediatek: decoder: Add MT8189
> >     mediatek,vcodec-decoder
> >   media: mediatek: vcodec: add decoder compatible to support MT8189
> >   media: mediatek: vcodec: add profile and level supporting for
> > MT8189
> >   media: mediatek: vcodec: Add core-only VP9 decoding support for
> > MT8189
> >   media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2
> >   media: mediatek: vcodec: fix media device node number
> >   dt-bindings: media: Add MT8189 mediatek,vcodec-encoder
> >   media: mediatek: encoder: Add MT8189 encoder compatible data
> > 
> >  .../media/mediatek,vcodec-encoder.yaml        |  2 ++
> >  .../media/mediatek,vcodec-subdev-decoder.yaml |  1 +
> >  .../vcodec/decoder/mtk_vcodec_dec_drv.c       |  9 +++++-
> >  .../vcodec/decoder/mtk_vcodec_dec_drv.h       |  1 +
> >  .../vcodec/decoder/mtk_vcodec_dec_stateless.c |  4 +++
> >  .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 32 ++++++++++++---
> > ----
> >  .../vcodec/encoder/mtk_vcodec_enc_drv.c       | 14 ++++++++
> >  7 files changed, 50 insertions(+), 13 deletions(-)

[PATCH v1 0/8] Enable video decoder & encoder for MT8189

[Kyrie Wu]

This series have the follow changing:
Firstly add mt8189 video decoder compatible, profile and level to support
MT8196 kernel driver.
Secondly fix some bugs, including vp 4K profile2 and media device node
number bug.
Lastly, add mt8189 video encoder compatible.

This series has been tested with MT8189 tast test.
Encoding and decoding worked for this chip.

Patches 1-2 Add decoder compatible.
Patches 3 Add profile and level supporting.
Patches 4 Add core-only VP9 decoding supporting.
Patches 5-6 fix some bugs.
Patches 7-8 Adds encoder compatible.

---
This series patches dependent on:
[1]
https://patchwork.linuxtv.org/project/linux-media/cover/20250510075357.11761-1-yunfei.dong@mediatek.com/
[2]
https://patchwork.linuxtv.org/project/linux-media/cover/20250528063633.14054-1-irui.wang@mediatek.com/

Kyrie Wu (8):
  dt-bindings: media: mediatek: decoder: Add MT8189
    mediatek,vcodec-decoder
  media: mediatek: vcodec: add decoder compatible to support MT8189
  media: mediatek: vcodec: add profile and level supporting for MT8189
  media: mediatek: vcodec: Add core-only VP9 decoding support for MT8189
  media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2
  media: mediatek: vcodec: fix media device node number
  dt-bindings: media: Add MT8189 mediatek,vcodec-encoder
  media: mediatek: encoder: Add MT8189 encoder compatible data

 .../media/mediatek,vcodec-encoder.yaml        |  2 ++
 .../media/mediatek,vcodec-subdev-decoder.yaml |  1 +
 .../vcodec/decoder/mtk_vcodec_dec_drv.c       |  9 +++++-
 .../vcodec/decoder/mtk_vcodec_dec_drv.h       |  1 +
 .../vcodec/decoder/mtk_vcodec_dec_stateless.c |  4 +++
 .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 32 ++++++++++++-------
 .../vcodec/encoder/mtk_vcodec_enc_drv.c       | 14 ++++++++
 7 files changed, 50 insertions(+), 13 deletions(-)

-- 
2.46.0

[PATCH v1 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

[Kyrie Wu]

Add MT8189 encoder compatible string, which will reference SCP device.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml      | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index 7675391d7eb0..faee838d684e 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -25,6 +25,7 @@ properties:
               - mediatek,mt8192-vcodec-enc
               - mediatek,mt8195-vcodec-enc
               - mediatek,mt8196-vcodec-enc
+              - mediatek,mt8189-vcodec-enc
       - items:
           - const: mediatek,mt8186-vcodec-enc
           - const: mediatek,mt8183-vcodec-enc
@@ -97,6 +98,7 @@ allOf:
               - mediatek,mt8188-vcodec-enc
               - mediatek,mt8192-vcodec-enc
               - mediatek,mt8195-vcodec-enc
+              - mediatek,mt8189-vcodec-enc
 
     then:
       required:
-- 
2.46.0