From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Dmitry Baryshkov" <lumag@kernel.org>
Subject: Re: [PATCH v5 08/11] drm/vc4: hdmi: switch to generic CEC helpers
Date: Tue, 15 Apr 2025 12:04:41 +0300 [thread overview]
Message-ID: <ca85e5e1-9887-4cea-91f5-3c312680506d@oss.qualcomm.com> (raw)
In-Reply-To: <20250414-thundering-marmoset-of-promotion-c8e0dc@houat>
On 14/04/2025 17:41, Maxime Ripard wrote:
> On Mon, Apr 07, 2025 at 06:11:05PM +0300, Dmitry Baryshkov wrote:
>> +static const struct drm_connector_hdmi_cec_adapter_ops vc4_hdmi_cec_adap_ops = {
>> + .base.unregister = drm_connector_hdmi_cec_unregister,
>> + .init = vc4_hdmi_cec_init,
>> + .enable = vc4_hdmi_cec_adap_enable,
>> + .log_addr = vc4_hdmi_cec_adap_log_addr,
>> + .transmit = vc4_hdmi_cec_adap_transmit,
>> +};
>
> Did you compile it? it looks like drm_connector_hdmi_cec_adapter_ops has been renamed, and it
> doesn't have a base.unregister field anymore?
It seems, I've changed my build tree config and this got disabled. I'll
make sure that it is enabled for the next iteration.
>
> Maxime
--
With best wishes
Dmitry
next prev parent reply other threads:[~2025-04-15 9:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 15:10 [PATCH v5 00/11] drm/display: generic HDMI CEC helpers Dmitry Baryshkov
2025-04-07 15:10 ` [PATCH v5 01/11] drm/bridge: move private data to the end of the struct Dmitry Baryshkov
2025-04-07 15:10 ` [PATCH v5 02/11] drm/bridge: allow limiting I2S formats Dmitry Baryshkov
2025-04-07 15:11 ` [PATCH v5 03/11] drm/connector: add CEC-related fields Dmitry Baryshkov
2025-04-14 14:52 ` Maxime Ripard
2025-04-15 9:10 ` Dmitry Baryshkov
2025-04-28 16:42 ` Dmitry Baryshkov
2025-04-29 15:33 ` Maxime Ripard
2025-04-07 15:11 ` [PATCH v5 04/11] drm/connector: unregister CEC data Dmitry Baryshkov
2025-04-14 14:44 ` Maxime Ripard
2025-04-14 14:47 ` Maxime Ripard
2025-04-15 9:03 ` Dmitry Baryshkov
2025-04-29 15:35 ` Maxime Ripard
2025-04-29 16:46 ` Dmitry Baryshkov
2025-04-07 15:11 ` [PATCH v5 05/11] drm/display: move CEC_CORE selection to DRM_DISPLAY_HELPER Dmitry Baryshkov
2025-04-14 14:36 ` Maxime Ripard
2025-04-07 15:11 ` [PATCH v5 06/11] drm/display: add CEC helpers code Dmitry Baryshkov
2025-04-14 14:58 ` Maxime Ripard
2025-04-15 16:01 ` Dmitry Baryshkov
2025-04-29 15:40 ` Maxime Ripard
2025-04-30 11:25 ` Jani Nikula
2025-04-07 15:11 ` [PATCH v5 07/11] drm/display: hdmi-state-helper: handle CEC physical address Dmitry Baryshkov
2025-04-07 15:11 ` [PATCH v5 08/11] drm/vc4: hdmi: switch to generic CEC helpers Dmitry Baryshkov
2025-04-14 14:41 ` Maxime Ripard
2025-04-15 9:04 ` Dmitry Baryshkov [this message]
2025-04-07 15:11 ` [PATCH v5 09/11] drm/display: bridge-connector: hook in CEC notifier support Dmitry Baryshkov
2025-04-14 14:59 ` Maxime Ripard
2025-04-07 15:11 ` [PATCH v5 10/11] drm/display: bridge-connector: handle CEC adapters Dmitry Baryshkov
2025-04-14 15:05 ` Maxime Ripard
2025-04-07 15:11 ` [PATCH v5 11/11] drm/bridge: adv7511: switch to the HDMI connector helpers Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca85e5e1-9887-4cea-91f5-3c312680506d@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-list@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox