From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D1052FD695 for ; Mon, 9 Mar 2026 18:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773080002; cv=none; b=FrlQiLlhB1s1VFszy62uvp7s4i/S9IbK07dpJuW9l2d0LIixQ4ItwsYPWbpVru46K7okhZvrHfCqTzvuNu72OkRH/SYA/IbJurSM1ayyoVgOVPCVeSE1GAkeo0IzyIcLpdeA1aZxmZNVzDUdLY2AJX4WuBYAUUe6lmW77msTINk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773080002; c=relaxed/simple; bh=axqGcRwX0ViFNb4WK9g3weO0SCpswRADdojCcvjft6c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OcmvD+oOQzydC0V46V1PVGfmorsy8zEFbZyFP8qJwKArtJVT3YoVCphYJ+1A1bC+nDuYMDwYp+tkn2Xoq+BNmUxar1FeuoFRXrgr7oxEZ73Tusudyg4t8V6oj0LBfID4DrNC8gWSvQIarzxlsDxOPc7mQy2XunUI8kqfzJwaXtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lwPb1y0b; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lwPb1y0b" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48535a0ef86so14283075e9.1 for ; Mon, 09 Mar 2026 11:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773080000; x=1773684800; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WVxctQB+E2ufIakKyx4ZMHmU69iMfXN6iBRw68NKW9Q=; b=lwPb1y0b3Mz3kmVLx+A5jTx13QjNemdBi/Ls6ckr+EGZRYdfGzWcS032UpdvbaL9qj Iz80Do1CJZUh1Ai0EvhP/BYl/TS+LYxDZSfk8qZXw5h/FlFEd/yt6BrN8e//5UYuhgQI G3xAn6JBpGl4EmSByusVVTxLWHHPuPaOkqqLccCMQSqtWbLv+IGwV8ZMdFEzwlp5mA+s ZrS+f+eebUr5E1GPbgrELpUk4j3AK516yJ/tE7EVv3mPE0aaz/yWV/Gjs37PmJYz2OO6 rs5IXtnhyVkf5VwJ9QRMgG8PcyGN8lvkK3v8tdhPGaZX04w9w6SjQZQGr3UP6cz3MECJ qy6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773080000; x=1773684800; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WVxctQB+E2ufIakKyx4ZMHmU69iMfXN6iBRw68NKW9Q=; b=hEHg8aSzgVDhwqfCAQCDMJfniBj5lEBLnj/HTAghwdu9BnFVOc2bjZEOfz+W/kUzLy FtN2MC9MVMQ2NNqHXCzKIqbDQCkHsHvLEY4tadlWxMhJeZdTTFOOZA/6VfcvR4Im+weq OmT9GEjUvhjXxK5F5Gr5670f+UMzc2R7FDNoGvNisFueWiKnJyfzYdgOqNTSd3YbyM+s rV0hymgBz1BiOrFFAjWoCo+gKwiXiBhWWZqEO5ysrEXCQ5Pvevrnq4fuI+iAlLOVbfH4 r7Sm51E1rIJ3Kyq6tqAnyMgq2/nyMTtt3FGjOieS43iprMPpj13HTKsFO5SRbsXY+7R9 kGww== X-Forwarded-Encrypted: i=1; AJvYcCXw4+8PgG9UYwo+/cjzf/G8FHYG7nqXz76ZS9BdRgrPib6WPbgaSm3s46x9+szogC5OmQSpMxVLV4mfNzQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzGTIGypv76KYqQn7TiQxYCPBjug6sQe5AsrigWIDf55TC5gFhO 4AlKx5q597LVKb0Jp+zCxHKhomPtG3fIqbRWDT7sWDgUMVG4PUDm59eP X-Gm-Gg: ATEYQzxUwUrF0F+nZRFPovOVoTkDQVsGOtfViTY2h4Y6Muem5AQarCdmOCqtITFBX/R f8Z9lyXxNU5V7euFKEXnVHyeItI7bYJVIIuTAFtTR9xZdyJEK36Z8PnQ2EPN8O0jQg6bMYLzu82 MdK71dfpCW0ClzLgBBJ0PPZdXNBmyrBSuE0oT34kujDfj0O01i1QiRI/UDO5lp18HPjfkzEd+3K P03syXz2TO3rpGowMCBFXRx2hhqGa2rAIoQ/AT+AHPMlq1wXqQw4bwUHChdd1H4zLd4wPWzGSsW F5X13H2TMEp9G4ujScOkbPOugLcdX5qGRt5enfSvdQzvGds11Rh3CwUFaNF9hSf2fq/QpMEtMQV VZE3gWWI6y8VD3EVDe+v4yIFnAYPZpRsOgJ7oZMLcbjCtyXIl7rvfxwvh1MIxxefOu2rtSpTYKD 5KL+sNSOZatFWJ4FubcRdZdDYAUe7nYmpN+EWE+itNsmnXMEWc4zEVEMi4ccTqyz5sTdwsbSxPE wjV9zal X-Received: by 2002:a05:600c:64c7:b0:483:c12b:fe4a with SMTP id 5b1f17b1804b1-48526922beemr188871065e9.11.1773079999495; Mon, 09 Mar 2026 11:13:19 -0700 (PDT) Received: from [192.168.50.249] (host-79-30-45-36.retail.telecomitalia.it. [79.30.45.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae4b860sm31280494f8f.36.2026.03.09.11.13.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 11:13:19 -0700 (PDT) Message-ID: Date: Mon, 9 Mar 2026 19:13:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] nfc: nxp-nci: remove interrupt trigger type To: Carl Lee , Krzysztof Kozlowski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, peter.shen@amd.com, colin.huang2@amd.com References: <20260205-fc-nxp-nci-remove-interrupt-trigger-type-v2-1-79d2ed4a7e42@amd.com> Content-Language: en-US From: Luca Stefani In-Reply-To: <20260205-fc-nxp-nci-remove-interrupt-trigger-type-v2-1-79d2ed4a7e42@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/02/2026 12:11, Carl Lee wrote: > For NXP NCI devices (e.g. PN7150), the interrupt is level-triggered and > active high, not edge-triggered. > > Using IRQF_TRIGGER_RISING in the driver can cause interrupts to fail > to trigger correctly. > > Remove IRQF_TRIGGER_RISING and rely on the IRQ trigger type configured > via Device Tree. > > Signed-off-by: Carl Lee > --- > This v2 of the series includes Krzysztof Kozlowski in the review list > for NXP-NCI NFC. > > This series removes IRQF_TRIGGER_RISING in nxp-nci driver, > relying on the IRQ trigger type specified via Device Tree. > --- > Changes in v2: > - Include Krzysztof Kozlowski in the review list for NXP-NCI NFC. > - Link to v1: https://lore.kernel.org/r/20260204-fc-nxp-nci-remove-interrupt-trigger-type-v1-1-3bde91593173@amd.com > --- > drivers/nfc/nxp-nci/i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c > index 049662ffdf97..6a5ce8ff91f0 100644 > --- a/drivers/nfc/nxp-nci/i2c.c > +++ b/drivers/nfc/nxp-nci/i2c.c > @@ -305,7 +305,7 @@ static int nxp_nci_i2c_probe(struct i2c_client *client) > > r = request_threaded_irq(client->irq, NULL, > nxp_nci_i2c_irq_thread_fn, > - IRQF_TRIGGER_RISING | IRQF_ONESHOT, > + IRQF_ONESHOT, This is causing an IRQ storm on my ACPI device that eats away a core of my cpu... I'm not sure how this should be fixed but by looking at other drivers they all use irq_get_trigger_type() and then apply extra bits on top. If there's no clear path that handles both ACPI+DT I'll upload a revert. > NXP_NCI_I2C_DRIVER_NAME, phy); > if (r < 0) > nfc_err(&client->dev, "Unable to register IRQ handler\n"); > > --- > base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f > change-id: 20260204-fc-nxp-nci-remove-interrupt-trigger-type-d778323b3b81 > > Best regards,