From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBotrVoOoNJUtgd3wWm/GI++/5AXLMueH4lpKu8SF4zoNKe1WAfmtWlZYBeMB88wfNwIwRCQB ARC-Seal: i=1; a=rsa-sha256; t=1516212042; cv=none; d=google.com; s=arc-20160816; b=h1V0jBQxO4Dw+CLwbsFgxwqYocrt7yr3J3a4tib01inWtt5SQwc94WCyPcvZ9shSZP USgNK795WyT2TNJubK0hAXorm2Dd55lrBuIcbM2WeMSt5mSbedTRjW96aeqn6KR4doDg tKipW/RkCTIRMVy/m8X1NIwTr9d71SZ5RiCFNVZgP4o4aKPfaDF4sf3+rOOcxBOPJPAL UWeda3s/eIEaSSLKiPrdOZExxuxUTq2zFqpuTHlt34Y5wfTjlvRKuKtHTknCjUEY8hnX Zx0ssT/5Jycc6JzCbAUWaWnxdBslpPyCDpm1JeaQFisdPTX4tl+dgsFdmURD/SvijBD6 kZow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject :cc:arc-authentication-results; bh=gc9NRXjM0GSVLXYoMWNuR2xSn+dnsR3TuDjdE7nM61Y=; b=R5W9vwAS/JWtvAANl8lSAoduNxaqzJwtADX8SHK5yPABCu3rVeQOngiq5UfqhSTcjy e1iFqXJpGM/EtgbQbUS7k+nnPvnfClRvSv7jgvVoL3EcsMdQh6o4+msPGEQ57QhI6dMj P/4bkRiBbOpfAjjc9/PhvwNbyp7XeDoLrf2MpduzFP18ssNobb9lqp2LJo4Y8IprpnDH JrwCE1KV/vLuF2zK2Dqh5r0eCiPrvm4+fV3jReGPbiRVbewntNENFwHuopUnFMKZg5sw SLPzgmYULWoKjvMe8SCVu0QegQNVTFzZ+T6m0NlUd8NVFc0LJ3vWhrl7dKwcf41jrgQC VqIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of sudeep.holla@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=sudeep.holla@arm.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of sudeep.holla@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=sudeep.holla@arm.com Cc: Sudeep Holla , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hanjun.guo@linaro.org, lorenzo.pieralisi@arm.com, rjw@rjwysocki.net, will.deacon@arm.com, catalin.marinas@arm.com, gregkh@linuxfoundation.org, viresh.kumar@linaro.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, jhugo@codeaurora.org, wangxiongfeng2@huawei.com, Jonathan.Zhang@cavium.com, ahs3@redhat.com, Jayachandran.Nair@cavium.com, austinwc@codeaurora.org, lenb@kernel.org, vkilari@codeaurora.org, morten.rasmussen@arm.com Subject: Re: [PATCH v6 05/12] ACPI/PPTT: Add Processor Properties Topology Table parsing To: Jeremy Linton References: <20180113005920.28658-1-jeremy.linton@arm.com> <20180113005920.28658-6-jeremy.linton@arm.com> <20180115154813.GB17664@e107155-lin> <096cdff0-d160-68ba-4cd2-0691dd04eac6@arm.com> From: Sudeep Holla Organization: ARM Message-ID: Date: Wed, 17 Jan 2018 18:00:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <096cdff0-d160-68ba-4cd2-0691dd04eac6@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589437003514361687?= X-GMAIL-MSGID: =?utf-8?q?1589863558793659005?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 16/01/18 20:22, Jeremy Linton wrote: > Hi, > [..] >> >> I forgot to mention this earlier, I see you have used parentheses too >> liberally at quite some place in this file like the above 4 line. >> Please drop those unnecessary parentheses. > > Yes, those tend to get leftover when I remove code, I realized not long > after posting this that in one of the previous patches I actually added > a pair where there wasn't one because I first shuffled something into > the if condition, then a few revisions later dropped it, and when I > squashed it before posting the result was some pointless churn. > > I will rescan the whole set for this. > Better, just to avoid keeping such things until the end, resulting in churning up series just for that. -- Regards, Sudeep