Re: [PATCH v13 2/5] usb: renesas-xhci: Add the renesas xhci driver

Heikki Krogerus
2020-05-20T13:27:45Z

On Tue, May 19, 2020 at 10:19:03PM +0200, Christian Lamparter wrote:
> Hello,
>
> On Tue, May 19, 2020 at 1:45 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> > On Wed, May 06, 2020 at 11:30:22AM +0530, Vinod Koul wrote:
> > > From: Christian Lamparter <chunkeey@googlemail.com>
> > >
> > > This add a new driver for renesas xhci which is basically a firmware
> > > loader for uPD720201 and uPD720202 w/o ROM. The xhci-pci driver will
> > > invoke this driver for loading/unloading on relevant devices.
> > >
> > > This patch adds a firmware loader for the uPD720201K8-711-BAC-A
> > > and uPD720202K8-711-BAA-A variant. Both of these chips are listed
> > > in Renesas' R19UH0078EJ0500 Rev.5.00 "User's Manual: Hardware" as
> > > devices which need the firmware loader on page 2 in order to
> > > work as they "do not support the External ROM".
> > >
> > > The "Firmware Download Sequence" is describe in chapter
> > > "7.1 FW Download Interface" R19UH0078EJ0500 Rev.5.00 page 131.
> > >
> > > The firmware "K2013080.mem" is available from a USB3.0 Host to
> > > PCIe Adapter (PP2U-E card) "Firmware download" archive. An
> > > alternative version can be sourced from Netgear's WNDR4700 GPL
> > > archives.
> > >
> > > The release notes of the PP2U-E's "Firmware Download" ver 2.0.1.3
> > > (2012-06-15) state that the firmware is for the following devices:
> > > - uPD720201 ES 2.0 sample whose revision ID is 2.
> > > - uPD720201 ES 2.1 sample & CS sample & Mass product, ID is 3.
> > > - uPD720202 ES 2.0 sample & CS sample & Mass product, ID is 2.
> >
> > You wouldn't happen to have access to the documentation of the
> > "original" uPD720200 USB 3.0 controller?
> >
> > It would be cool if we could support that too with this driver.
>
> ???. I have one of those "original" uPD720200(A) working "just fine"
> in my Laptop currently.
> It's an really old HP dv6-6003eg from around 2011 that came with two
> USB 3.0 Ports, which
> are driven by a "NEC Corporation uPD720200 USB 3.0 Host Controller"
> 1033:0194 (Rev 04).
>
> As for supporting the uPD720200 (flasher) with this serises.... There
> are some bad news:
>
> "In addition, the programming interface for the uPD720200 and uPD720200A
> is different from the uPD720202, needs different programming tools, and relies
> on proprietary chip features that cannot be disclosed outside of Renesas."
> <https://mail.coreboot.org/pipermail/flashrom/2013-February/010498.html> :-(

Too bad. That's what I was hoping to do with this driver. There are
still boards out there equipped with uPD720200/uPD720200A that have
older firmware. If you don't have the latest firmware (which is also
from 2012), then PME and a few other things will not work (so resume
from D3 does not work for example).

thanks,

--
heikki