Re: [PATCH v13 0/5] usb: xhci: Add support for Renesas USB controllers

Vinod Koul
2020-05-13T12:58:05Z

On 13-05-20, 14:52, Greg Kroah-Hartman wrote:
> On Wed, May 13, 2020 at 03:51:28PM +0300, Mathias Nyman wrote:
> > On 13.5.2020 15.40, Greg Kroah-Hartman wrote:
> > > On Wed, May 13, 2020 at 03:19:29PM +0300, Mathias Nyman wrote:
> > >> On 6.5.2020 9.00, Vinod Koul wrote:
> > >>> This series add support for Renesas USB controllers uPD720201 and uPD720202.
> > >>> These require firmware to be loaded and in case devices have ROM those can
> > >>> also be programmed if empty. If ROM is programmed, it runs from ROM as well.
> > >>>
> > >>> This includes patches from Christian which supported these controllers w/o
> > >>> ROM and later my patches for ROM support and debugfs hook for rom erase and
> > >>> export of xhci-pci functions.
> > >>>
> > >>
> > >> First four patches look ok to me, but 5/5 that adds rom erase debugfs support
> > >> still needs some work.
> > >>
> > >> If you prefer I can take the first four, maybe we can get them to 5.8, and then
> > >> later add that debugs rom erase support.
> > >>
> > >> Let me know what you prefer
> > >
> > > Oops, I just added all of these to my testing tree :)
> > >
> > > What's wrong with the debugfs patch? I can drop it, but it seemed
> > > simple enough to me.
> >
> > Added "usb_renesas" directory under debugfs root when we have easily accessible
> > debugfs/usb/xhci directory to use as parent.
>
> I've responded to the patch now, sorry I missed that.

I can send an update on top of this to use xhci root, or respin this
patch, either ways is fine by me.

> > Also not checking if adding directory failed (if debufs not supported)
>
> That's fine and encouraged to do :)

Yes, I have known you 'encouraging' folks for that, hence coded it :)

Thanks
--
~Vinod