From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932637AbeAROiR (ORCPT ); Thu, 18 Jan 2018 09:38:17 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:39368 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932601AbeAROiK (ORCPT ); Thu, 18 Jan 2018 09:38:10 -0500 X-Google-Smtp-Source: ACJfBouG6x8I8yh+mpSRPZaaMuOmNAdJRFzXQ7Nz4iw68tjukMypUhZE1/uqsvu9us2gZPQxvS8+9E/jgP4XvoZ36NA= From: Sumit Saxena References: <20180117144859.2382521-1-arnd@arndb.de> In-Reply-To: <20180117144859.2382521-1-arnd@arndb.de> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQEJpXCzFQ904vwKJvq9tnaSCkkkO6UNiIJw Date: Thu, 18 Jan 2018 20:08:08 +0530 Message-ID: Subject: RE: [PATCH] [RESEND] megaraid: use ktime_get_real for firmware time To: Arnd Bergmann , Kashyap Desai , Shivasharan Srikanteshwara , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Tomas Henzl , Hannes Reinecke , "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----Original Message----- From: Arnd Bergmann [mailto:arnd@arndb.de] Sent: Wednesday, January 17, 2018 8:19 PM To: Kashyap Desai; Sumit Saxena; Shivasharan S; James E.J. Bottomley; Martin K. Petersen Cc: Arnd Bergmann; Tomas Henzl; Hannes Reinecke; megaraidlinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] [RESEND] megaraid: use ktime_get_real for firmware time do_gettimeofday() overflows in 2038 on 32-bit architectures and is deprecated, so convert this driver to call ktime_get_real() directly. This also simplifies the calculation. Signed-off-by: Arnd Bergmann --- Sent originally in Nov 2017, no comments. Please apply --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index 0a85f3c48ef6..97fae28c8374 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -983,7 +983,7 @@ megasas_ioc_init_fusion(struct megasas_instance *instance) MFI_CAPABILITIES *drv_ops; u32 scratch_pad_2; unsigned long flags; - struct timeval tv; + ktime_t time; bool cur_fw_64bit_dma_capable; fusion = instance->ctrl_context; @@ -1042,10 +1042,9 @@ megasas_ioc_init_fusion(struct megasas_instance *instance) IOCInitMessage->HostMSIxVectors = instance->msix_vectors; IOCInitMessage->HostPageSize = MR_DEFAULT_NVME_PAGE_SHIFT; - do_gettimeofday(&tv); + time = ktime_get_real(); /* Convert to milliseconds as per FW requirement */ - IOCInitMessage->TimeStamp = cpu_to_le64((tv.tv_sec * 1000) + - (tv.tv_usec / 1000)); + IOCInitMessage->TimeStamp = cpu_to_le64(ktime_to_ms(time)); init_frame = (struct megasas_init_frame *)cmd->frame; memset(init_frame, 0, IOC_INIT_FRAME_SIZE); Looks good to me. Acked-by: Sumit Saxena -- 2.9.0