From: Krzysztof Kozlowski <krzk@kernel.org>
To: niravkumar.l.rabara@intel.com, Dinh Nguyen <dinguyen@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
nirav.rabara@altera.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: socfpga: agilex5: add TB daughter board support
Date: Wed, 19 Feb 2025 08:04:39 +0100 [thread overview]
Message-ID: <cab7b294-a27c-438a-b6e1-b8928a8ad202@kernel.org> (raw)
In-Reply-To: <20250218094434.3574060-3-niravkumar.l.rabara@intel.com>
On 18/02/2025 10:44, niravkumar.l.rabara@intel.com wrote:
> @@ -0,0 +1,27 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2025, Altera Corporation
> + */
> +#include "socfpga_agilex5_socdk.dts"
> +
> +/ {
> + model = "SoCFPGA Agilex5 SoCDK - TB";
> + compatible = "intel,socfpga-agilex5-socdk-tb", "intel,socfpga-agilex5";
> +
> + leds {
> + led-0 {
> + label = "hps_led0";
> + gpios = <&portb 12 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +};
> +
> +&spi0 {
> + status = "okay";
> +
> + spidev@0{
> + compatible = "rohm,dh2228fv";
NAK. You do not have such device there.
Also, follow DTS coding style and fix all white space issues here.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-02-19 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 9:44 [PATCH 0/2] Add TB daughter board support niravkumar.l.rabara
2025-02-18 9:44 ` [PATCH 1/2] dt-bindings: intel: document Agilex5 TB daughter board niravkumar.l.rabara
2025-02-18 9:44 ` [PATCH 2/2] arm64: dts: socfpga: agilex5: add TB daughter board support niravkumar.l.rabara
2025-02-19 7:04 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cab7b294-a27c-438a-b6e1-b8928a8ad202@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nirav.rabara@altera.com \
--cc=niravkumar.l.rabara@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).