Re: [PATCH v2 0/3] Add Rust Rockchip PHY driver

Andrew Lunn
2024-02-01T21:33:29Z

On Thu, Feb 01, 2024 at 07:06:57PM +0100, Christina Quast wrote:
> Based on the example shown in drivers/net/phy/ax88796b_rust.rs, I ported
> the rockchip phy driver to Rust. The code in drivers/net/phy/rockchip.c
> was basically rewritten in Rust. The patchset includes changes to
> phy.rs, adding more struct driver functions for the abstraction with
> Rust.
>
> The driver was not tested on real hardware, because I do not have a
> board with this phy, and I would appreciate it if somebody could try
> out the driver on their board.

As a general point, please post such code RFT. Also adding RFC would
be good, and explain what sort of comments you are requesting.

Andrew

---
pw-bot: cr