linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)
@ 2025-07-21 20:17 Erik Beck
  2025-07-22 16:18 ` Rob Herring (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Erik Beck @ 2025-07-21 20:17 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Erik Beck, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel


Signed-off-by: Erik Beck <xunil@tahomasoft.com>
---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../rockchip/rk3568-linkstar-h68k-1432v1.dts  | 740 ++++++++++++++++++
 2 files changed, 741 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts

diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 4bf84622db47..baae5a9a3f06 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -128,6 +128,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r68s.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-linkstar-h68k-1432v1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-lubancat-2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-mecsbc.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5c.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
new file mode 100644
index 000000000000..53f8980225a3
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
@@ -0,0 +1,740 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2022 AmadeusGhost <amadeus@jmu.edu.cn>
+ * Copyright (c) 2025 TahomaSoft xunil@tahomasoft.com
+*/
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3568.dtsi"
+
+/ {
+        model = "Seeed LinkStar H68K-1432V1 (RK3568) DDR4 Board";
+        compatible = "seeed,rk3568-linkstar-h68k-1432v1", "rockchip,rk3568";
+
+        aliases {
+               ethernet0 = &gmac0;
+               ethernet1 = &gmac1;
+
+               /* fixed eMMC */
+               mmc0 = &sdhci;
+
+               /* removable uSD/TF Card */
+               mmc1 = &sdmmc0;
+
+               rtc0 = &rk809;
+        };
+
+        chosen {
+                stdout-path = "serial2:1500000n8";
+        };
+
+        hdmi-con {
+                compatible = "hdmi-connector";
+                type = "a";
+
+                port {
+                        hdmi_con_in: endpoint {
+                                remote-endpoint = <&hdmi_out_con>;
+                        };
+                };
+        };
+
+        gpio-keys {
+                compatible = "gpio-keys";
+                pinctrl-0 = <&reset_button_pin>;
+                pinctrl-names = "default";
+
+        /* Middle inset/recessed button,
+                  marked by clockwise arrow/circle */
+
+                button-reset {
+                        label = "button:system:reset";
+                        gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_LOW>;
+                        linux,code = <KEY_RESTART>;
+                        debounce-interval = <50>;
+                };
+        };
+
+        gpio-leds {
+                compatible = "gpio-leds";
+                pinctrl-names = "default";
+                pinctrl-0 = <&led_white_pin>, <&led_green_pin>,
+                         <&led_amber_pin>, <&led_blue_pin>;
+
+                /* White LED inset in power button */
+
+                led_white: led-0   {
+                        color = <LED_COLOR_ID_WHITE>;
+                        default-state = "on";
+                        function = LED_FUNCTION_POWER;
+                        gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
+                        linux,default-trigger = "default-on";
+                };
+
+                led_green: led-1 {
+                        color = <LED_COLOR_ID_GREEN>;
+                        default-state = "off";
+                        function = LED_FUNCTION_STATUS;
+                        gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_HIGH>;
+                        linux,default-trigger = "none";
+                };
+
+                led_amber: led-2 {
+                        color = <LED_COLOR_ID_AMBER>;
+                        default-state = "off";
+                        function = LED_FUNCTION_STATUS;
+                        gpios = <&gpio3 RK_PA7 GPIO_ACTIVE_HIGH>;
+                        linux,default-trigger = "none";
+                };
+
+                led_blue: led-3 {
+                        color = <LED_COLOR_ID_BLUE>;
+                        default-state = "off";
+                        function = LED_FUNCTION_STATUS;
+                        gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>;
+                        linux,default-trigger = "heartbeat";
+                };
+        };
+
+        vcc12v_dcin: regulator-vcc12v-dcin {
+                compatible = "regulator-fixed";
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-min-microvolt = <12000000>;
+                regulator-max-microvolt = <12000000>;
+                regulator-name = "vcc12v_dcin";
+        };
+
+        vcc3v3_sys: regulator-vcc3v3-sys {
+                compatible = "regulator-fixed";
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-min-microvolt = <3300000>;
+                regulator-max-microvolt = <3300000>;
+                regulator-name = "vcc3v3_sys";
+                vin-supply = <&vcc12v_dcin>;
+        };
+
+        vcc5v0_sys: regulator-vcc5v0-sys {
+                compatible = "regulator-fixed";
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-min-microvolt = <5000000>;
+                regulator-max-microvolt = <5000000>;
+                regulator-name = "vcc5v0_sys";
+                vin-supply = <&vcc12v_dcin>;
+        };
+
+        vcc5v0_usb: regulator-vcc5v0-usb {
+                compatible = "regulator-fixed";
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-min-microvolt = <5000000>;
+                regulator-max-microvolt = <5000000>;
+                regulator-name = "vcc5v0_usb";
+                vin-supply = <&vcc12v_dcin>;
+        };
+
+        vcc5v0_usb_host: regulator-vcc5v0-usb-host {
+                compatible = "regulator-fixed";
+                enable-active-high;
+                gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
+                pinctrl-names = "default";
+                pinctrl-0 = <&vcc5v0_usb_host_en>;
+                regulator-min-microvolt = <5000000>;
+                regulator-max-microvolt = <5000000>;
+                regulator-name = "vcc5v0_usb_host";
+                vin-supply = <&vcc5v0_usb>;
+        };
+
+        vcc3v3_pcie: regulator-vcc3v3-pcie {
+                compatible = "regulator-fixed";
+                enable-active-high;
+                regulator-min-microvolt = <3300000>;
+                regulator-max-microvolt = <3300000>;
+                regulator-name = "vcc3v3_pcie";
+                startup-delay-us = <5000>;
+                vin-supply = <&vcc5v0_sys>;
+        };
+
+        rk809-sound {
+                compatible = "simple-audio-card";
+                simple-audio-card,format = "i2s";
+                simple-audio-card,name = "Analog RK809";
+                simple-audio-card,mclk-fs = <256>;
+
+                simple-audio-card,cpu {
+                        sound-dai = <&i2s1_8ch>;
+                };
+                simple-audio-card,codec {
+                        sound-dai = <&rk809>;
+                };
+        };
+};
+
+&gmac0 {
+        assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
+        assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
+        assigned-clock-rates = <0>, <125000000>;
+        clock_in_out = "output";
+        phy-mode = "rgmii-id";
+        pinctrl-names = "default";
+        pinctrl-0 = <&gmac0_miim
+                     &gmac0_tx_bus2
+                     &gmac0_rx_bus2
+                     &gmac0_rgmii_clk
+                     &gmac0_rgmii_bus>;
+        snps,reset-gpio = <&gpio2 RK_PD3 GPIO_ACTIVE_LOW>;
+        snps,reset-active-low;
+        snps,reset-delays-us = <0 20000 100000>;
+        phy-handle = <&rgmii_phy0>;
+        status = "okay";
+};
+
+&gmac1 {
+        assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
+        assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>;
+        assigned-clock-rates = <0>, <125000000>;
+        clock_in_out = "output";
+        phy-mode = "rgmii-id";
+        pinctrl-names = "default";
+        pinctrl-0 = <&gmac1m1_miim
+                     &gmac1m1_tx_bus2
+                     &gmac1m1_rx_bus2
+                     &gmac1m1_rgmii_clk
+                     &gmac1m1_rgmii_bus>;
+        snps,reset-gpio = <&gpio1 RK_PB0 GPIO_ACTIVE_LOW>;
+        snps,reset-active-low;
+        snps,reset-delays-us = <0 20000 100000>;
+        phy-handle = <&rgmii_phy1>;
+        status = "okay";
+};
+
+&combphy0 {
+        status = "okay";
+};
+
+&combphy1 {
+        status = "okay";
+};
+
+&combphy2 {
+        status = "okay";
+};
+
+&cpu0 {
+        cpu-supply = <&vdd_cpu>;
+};
+
+&cpu1 {
+        cpu-supply = <&vdd_cpu>;
+};
+
+&cpu2 {
+        cpu-supply = <&vdd_cpu>;
+};
+
+&cpu3 {
+        cpu-supply = <&vdd_cpu>;
+};
+
+&gpu {
+        mali-supply = <&vdd_gpu>;
+        status = "okay";
+};
+
+&hdmi {
+        avdd-0v9-supply = <&vdda0v9_image>;
+        avdd-1v8-supply = <&vcca1v8_image>;
+        status = "okay";
+};
+
+&hdmi_in {
+        hdmi_in_vp0: endpoint {
+                remote-endpoint = <&vp0_out_hdmi>;
+        };
+};
+
+&hdmi_out {
+        hdmi_out_con: endpoint {
+                remote-endpoint = <&hdmi_con_in>;
+        };
+};
+
+&hdmi_sound {
+        status = "okay";
+};
+
+&i2c0 {
+        status = "okay";
+
+        vdd_cpu: regulator@1c {
+                compatible = "tcs,tcs4525";
+                reg = <0x1c>;
+                fcs,suspend-voltage-selector = <1>;
+                regulator-name = "vdd_cpu";
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-min-microvolt = <800000>;
+                regulator-max-microvolt = <1150000>;
+                regulator-ramp-delay = <2300>;
+                vin-supply = <&vcc5v0_sys>;
+
+                regulator-state-mem {
+                        regulator-off-in-suspend;
+                };
+        };
+
+        rk809: pmic@20 {
+                compatible = "rockchip,rk809";
+                reg = <0x20>;
+                interrupt-parent = <&gpio0>;
+                interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
+                assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
+                assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
+                #clock-cells = <1>;
+                clock-names = "mclk";
+                clocks = <&cru I2S1_MCLKOUT_TX>;
+                pinctrl-names = "default";
+                pinctrl-0 = <&pmic_int>, <&i2s1m0_mclk>;
+                rockchip,system-power-controller;
+                #sound-dai-cells = <0>;
+                wakeup-source;
+
+                vcc1-supply = <&vcc3v3_sys>;
+                vcc2-supply = <&vcc3v3_sys>;
+                vcc3-supply = <&vcc3v3_sys>;
+                vcc4-supply = <&vcc3v3_sys>;
+                vcc5-supply = <&vcc3v3_sys>;
+                vcc6-supply = <&vcc3v3_sys>;
+                vcc7-supply = <&vcc3v3_sys>;
+                vcc8-supply = <&vcc3v3_sys>;
+                vcc9-supply = <&vcc3v3_sys>;
+
+                regulators {
+                        vdd_logic: DCDC_REG1 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-initial-mode = <0x2>;
+                                regulator-min-microvolt = <500000>;
+                                regulator-max-microvolt = <1350000>;
+                                regulator-name = "vdd_logic";
+                                regulator-ramp-delay = <6001>;
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vdd_gpu: DCDC_REG2 {
+                                regulator-always-on;
+                                regulator-initial-mode = <0x2>;
+                                regulator-min-microvolt = <500000>;
+                                regulator-max-microvolt = <1350000>;
+                                regulator-name = "vdd_gpu";
+                                regulator-ramp-delay = <6001>;
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vcc_ddr: DCDC_REG3 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-initial-mode = <0x2>;
+                                regulator-name = "vcc_ddr";
+
+                                regulator-state-mem {
+                                        regulator-on-in-suspend;
+                                };
+                        };
+
+                        vdd_npu: DCDC_REG4 {
+                                regulator-initial-mode = <0x2>;
+                                regulator-min-microvolt = <500000>;
+                                regulator-max-microvolt = <1350000>;
+                                regulator-name = "vdd_npu";
+                                regulator-ramp-delay = <6001>;
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vcc_1v8: DCDC_REG5 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-min-microvolt = <1800000>;
+                                regulator-max-microvolt = <1800000>;
+                                regulator-name = "vcc_1v8";
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vdda0v9_image: LDO_REG1 {
+                                regulator-name = "vdda0v9_image";
+                                regulator-min-microvolt = <900000>;
+                                regulator-max-microvolt = <900000>;
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vdda_0v9: LDO_REG2 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-min-microvolt = <900000>;
+                                regulator-max-microvolt = <900000>;
+                                regulator-name = "vdda_0v9";
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vdda0v9_pmu: LDO_REG3 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-min-microvolt = <900000>;
+                                regulator-max-microvolt = <900000>;
+                                regulator-name = "vdda0v9_pmu";
+
+                                regulator-state-mem {
+                                        regulator-on-in-suspend;
+                                        regulator-suspend-microvolt = <900000>;
+                                };
+                        };
+
+                        vccio_acodec: LDO_REG4 {
+                                regulator-always-on;
+                                regulator-min-microvolt = <3300000>;
+                                regulator-max-microvolt = <3300000>;
+                                regulator-name = "vccio_acodec";
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vccio_sd: LDO_REG5 {
+                                regulator-min-microvolt = <1800000>;
+                                regulator-max-microvolt = <3300000>;
+                                regulator-name = "vccio_sd";
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vcc3v3_pmu: LDO_REG6 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-min-microvolt = <3300000>;
+                                regulator-max-microvolt = <3300000>;
+                                regulator-name = "vcc3v3_pmu";
+
+                                regulator-state-mem {
+                                        regulator-on-in-suspend;
+                                        regulator-suspend-microvolt = <3300000>;
+                                };
+                        };
+
+                        vcca_1v8: LDO_REG7 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-min-microvolt = <1800000>;
+                                regulator-max-microvolt = <1800000>;
+                                regulator-name = "vcca_1v8";
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vcca1v8_pmu: LDO_REG8 {
+                                regulator-always-on;
+                                regulator-boot-on;
+                                regulator-min-microvolt = <1800000>;
+                                regulator-max-microvolt = <1800000>;
+                                regulator-name = "vcca1v8_pmu";
+
+                                regulator-state-mem {
+                                        regulator-on-in-suspend;
+                                        regulator-suspend-microvolt = <1800000>;
+                                };
+                        };
+
+                        vcca1v8_image: LDO_REG9 {
+                                regulator-min-microvolt = <1800000>;
+                                regulator-max-microvolt = <1800000>;
+                                regulator-name = "vcca1v8_image";
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vcc_3v3: SWITCH_REG1 {
+                                regulator-name = "vcc_3v3";
+                                regulator-always-on;
+                                regulator-boot-on;
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+
+                        vcc3v3_sd: SWITCH_REG2 {
+                                regulator-name = "vcc3v3_sd";
+
+                                regulator-state-mem {
+                                        regulator-off-in-suspend;
+                                };
+                        };
+                };
+
+                codec {
+                        rockchip,mic-in-differential;
+                };
+        };
+};
+
+&i2s0_8ch {
+        status = "okay";
+};
+
+&i2s1_8ch {
+        rockchip,trcm-sync-tx-only;
+        status = "okay";
+};
+
+&mdio0 {
+        rgmii_phy0: ethernet-phy@0 {
+                compatible = "ethernet-phy-ieee802.3-c22";
+                reg = <0x0>;
+        };
+};
+
+&mdio1 {
+        rgmii_phy1: ethernet-phy@0 {
+                compatible = "ethernet-phy-ieee802.3-c22";
+                reg = <0x0>;
+        };
+};
+
+&pcie30phy {
+         data-lanes = <1 2>;
+         status = "okay";
+};
+
+&pcie2x1 {
+         reset-gpios = <&gpio2 RK_PD6 GPIO_ACTIVE_HIGH>;
+         vpcie3v3-supply = <&vcc3v3_pcie>;
+         status = "okay";
+};
+
+&pcie3x1 {
+         num-lanes= <1>;
+         bus-range = <0x10 0x1f>;
+         reset-gpios = <&gpio3 RK_PA4 GPIO_ACTIVE_HIGH>;
+         vpcie3v3-supply = <&vcc3v3_pcie>;
+         status = "okay";
+
+};
+
+&pcie3x2 {
+         num-lanes= <1>;
+         bus-range = <0x20 0x2f>;
+         reset-gpios = <&gpio2 RK_PD0 GPIO_ACTIVE_HIGH>;
+         vpcie3v3-supply = <&vcc3v3_pcie>;
+         status = "okay";
+};
+
+&pinctrl {
+        button {
+                reset_button_pin: reset-button-pin {
+                        rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
+                };
+        };
+
+        bluetooth {
+                bt_wake_host_h: bt-wake-host-h {
+                        rockchip,pins = <3 RK_PA1 RK_FUNC_GPIO &pcfg_pull_down>;
+                };
+
+                host_wake_bt_h: host-wake-bt-h {
+                        rockchip,pins = <3 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
+                };
+        };
+
+        gpio-leds {
+             led_white_pin: led-white-pin  {
+                    rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
+             };
+
+             led_green_pin: led-green-pin {
+                    rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+             };
+
+             led_amber_pin: led-amber-pin {
+                    rockchip,pins = <3 RK_PA7 RK_FUNC_GPIO &pcfg_pull_none>;
+             };
+
+             led_blue_pin: led-blue-pin {
+                    rockchip,pins = <3 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
+             };
+
+        };
+
+        pmic {
+                pmic_int: pmic_int {
+                        rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
+                };
+        };
+
+        usb {
+                vcc5v0_usb_host_en: vcc5v0_usb_host_en {
+                        rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
+                };
+        };
+};
+
+&pmu_io_domains {
+        pmuio1-supply = <&vcc3v3_pmu>;
+        pmuio2-supply = <&vcc3v3_pmu>;
+        vccio1-supply = <&vccio_acodec>;
+        vccio2-supply = <&vcc_1v8>;
+        vccio3-supply = <&vccio_sd>;
+        vccio4-supply = <&vcc_1v8>;
+        vccio5-supply = <&vcc_3v3>;
+        vccio6-supply = <&vcc_1v8>;
+        vccio7-supply = <&vcc_3v3>;
+        status = "okay";
+};
+
+&rng {
+        status = "okay";
+};
+
+&saradc {
+        vref-supply = <&vcca_1v8>;
+        status = "okay";
+};
+
+&sata0 {
+        status = "disabled";
+};
+
+&sata1 {
+        status = "disabled";
+};
+
+&sata2 {
+        status = "disabled";
+};
+
+&sdhci {
+        bus-width = <8>;
+        max-frequency = <200000000>;
+        non-removable;
+        pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
+        status = "okay";
+};
+
+&sdmmc0 {
+        bus-width = <4>;
+        cap-sd-highspeed;
+        cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
+        disable-wp;
+        pinctrl-names = "default";
+        pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
+        sd-uhs-sdr104;
+        vmmc-supply = <&vcc3v3_sd>;
+        vqmmc-supply = <&vccio_sd>;
+        status = "okay";
+};
+
+&tsadc {
+        rockchip,hw-tshut-mode = <1>;
+        rockchip,hw-tshut-polarity = <0>;
+        status = "okay";
+};
+
+&uart2 {
+        status = "okay";
+};
+
+&usb_host0_ehci {
+        status = "okay";
+};
+
+&usb_host1_ehci {
+        status = "okay";
+};
+
+&usb_host0_ohci {
+        status = "okay";
+};
+
+&usb_host1_ohci {
+        status = "okay";
+};
+
+&usb_host0_xhci {
+        phys = <&combphy0 PHY_TYPE_USB3>;
+        phy-names = "usb3-phy";
+        status = "okay";
+};
+
+&usb_host1_xhci {
+        status = "okay";
+};
+
+&usb2phy0 {
+        status = "okay";
+};
+
+&usb2phy0_host {
+        phy-supply = <&vcc5v0_usb_host>;
+        status = "okay";
+};
+
+&usb2phy1 {
+        status = "okay";
+};
+
+&usb2phy1_host {
+        phy-supply = <&vcc5v0_usb_host>;
+        status = "okay";
+};
+
+&usb2phy1_otg {
+        phy-supply = <&vcc5v0_usb_host>;
+        status = "okay";
+};
+
+&vop {
+        assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
+        assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
+        status = "okay";
+};
+
+&vop_mmu {
+        status = "okay";
+};
+
+&vp0 {
+        vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+                reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+                remote-endpoint = <&hdmi_in_vp0>;
+        };
+};
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)
  2025-07-21 20:17 [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568) Erik Beck
@ 2025-07-22 16:18 ` Rob Herring (Arm)
  2025-07-23  6:45 ` Krzysztof Kozlowski
  2025-07-23 13:50 ` Chukun Pan
  2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2025-07-22 16:18 UTC (permalink / raw)
  To: Erik Beck
  Cc: linux-kernel, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-rockchip, Heiko Stuebner, Conor Dooley


On Mon, 21 Jul 2025 16:17:12 -0400, Erik Beck wrote:
> 
> Signed-off-by: Erik Beck <xunil@tahomasoft.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../rockchip/rk3568-linkstar-h68k-1432v1.dts  | 740 ++++++++++++++++++
>  2 files changed, 741 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.16-rc3-17-g404dcaa62651 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250721201714.233962-1-xunil@tahomasoft.com:

arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dtb: / (seeed,rk3568-linkstar-h68k-1432v1): compatible: 'oneOf' conditional failed, one must be fixed:
	['seeed,rk3568-linkstar-h68k-1432v1', 'rockchip,rk3568'] is too short
	'vamrs,ficus' was expected
	'vamrs,rock960' was expected
	'amarula,vyasa-rk3288' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['anbernic,rg351m', 'anbernic,rg351v']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['anbernic,rg353p', 'anbernic,rg353ps', 'anbernic,rg353v', 'anbernic,rg353vs', 'anbernic,rg503', 'anbernic,rg-arc-d', 'anbernic,rg-arc-s']
	'ariaboard,photonicat' was expected
	'armsom,sige5' was expected
	'armsom,sige7' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['armsom,w3']
	'asus,rk3288-tinker' was expected
	'asus,rk3288-tinker-s' was expected
	'azw,beelink-a1' was expected
	'bigtreetech,cb2-manta' was expected
	'bigtreetech,pi2' was expected
	'mundoreader,bq-curie2' was expected
	'mundoreader,bq-edison2qc' was expected
	'chipspark,popmetal-rk3288' was expected
	'chipspark,rayeager-px2' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['coolpi,pi-cm5-evb']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['coolpi,pi-cm5-genbook']
	'coolpi,pi-4b' was expected
	'edgeble,neural-compute-module-2-io' was expected
	'edgeble,neural-compute-module-6a-io' was expected
	'elgin,rv1108-r1' was expected
	'embedfire,lubancat-1' was expected
	'embedfire,lubancat-2' was expected
	'engicam,px30-core-ctouch2' was expected
	'engicam,px30-core-ctouch2-of10' was expected
	'engicam,px30-core-edimm2.2' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['mntre,reform2-rcore']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,itx-3588j']
	'firefly,px30-jd4-core-mb' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,firefly-rk3288', 'firefly,firefly-rk3288-beta']
	'firefly,firefly-rk3288-reload' was expected
	'firefly,firefly-rk3399' was expected
	'firefly,roc-rk3308-cc' was expected
	'firefly,roc-rk3328-cc' was expected
	'firefly,roc-rk3328-pc' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,roc-rk3399-pc', 'firefly,roc-rk3399-pc-mezzanine']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,roc-rk3399-pc-plus']
	'firefly,roc-rk3576-pc' was expected
	'firefly,rk3566-roc-pc' was expected
	'firefly,rk3568-roc-pc' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['forlinx,ok3588-c']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r2c', 'friendlyarm,nanopi-r2c-plus', 'friendlyarm,nanopi-r2s', 'friendlyarm,nanopi-r2s-plus']
	'friendlyarm,nanopi-r3s' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopc-t4', 'friendlyarm,nanopi-m4', 'friendlyarm,nanopi-m4b', 'friendlyarm,nanopi-neo4', 'friendlyarm,nanopi-r4s', 'friendlyarm,nanopi-r4s-enterprise']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r5c', 'friendlyarm,nanopi-r5s']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r6c', 'friendlyarm,nanopi-r6s']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopc-t6', 'friendlyarm,nanopc-t6-lts']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,cm3588-nas']
	'gameforce,ace' was expected
	'gameforce,chi' was expected
	'geekbuying,geekbox' was expected
	'geniatech,xpi-3128' was expected
	'google,bob-rev13' was expected
	'google,veyron-brain-rev0' was expected
	'google,veyron-fievel-rev8' was expected
	'google,gru-rev15' was expected
	'google,veyron-jaq-rev5' was expected
	'google,veyron-jerry-rev15' was expected
	'google,kevin-rev15' was expected
	'google,veyron-mickey-rev8' was expected
	'google,veyron-mighty-rev5' was expected
	'google,veyron-minnie-rev4' was expected
	'google,veyron-pinky-rev2' was expected
	'google,scarlet-rev15-sku0' was expected
	'google,scarlet-rev15-sku7' was expected
	'google,scarlet-rev15-sku2' was expected
	'google,veyron-speedy-rev9' was expected
	'google,veyron-tiger-rev8' was expected
	'haochuangyi,h96-max-v58' was expected
	'haoyu,marsboard-rk3066' was expected
	'hardkernel,rk3326-odroid-go2' was expected
	'hardkernel,rk3326-odroid-go2-v11' was expected
	'hardkernel,rk3326-odroid-go3' was expected
	'hardkernel,odroid-m1' was expected
	'hardkernel,odroid-m1s' was expected
	'hardkernel,odroid-m2' was expected
	'hugsun,x99' was expected
	'indiedroid,nova' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['khadas,edge', 'khadas,edge-captain', 'khadas,edge-v']
	'khadas,edge2' was expected
	'kobol,helios64' was expected
	'mecer,xms6' was expected
	'leez,p710' was expected
	'lckfb,tspi-rk3566' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['lunzn,fastrhino-r66s', 'lunzn,fastrhino-r68s']
	'mqmaker,miqi' was expected
	'neardi,lba3368' was expected
	'netxeon,r89' was expected
	'openailab,eaidk-610' was expected
	'xunlong,rk3399-orangepi' was expected
	'phytec,rk3288-pcm-947' was expected
	'pine64,pinebook-pro' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,pinenote-v1.1', 'pine64,pinenote-v1.2']
	'pine64,pinephone-pro' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,pinetab2-v0.1', 'pine64,pinetab2-v2.0']
	'pine64,rock64' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,rockpro64-v2.1', 'pine64,rockpro64-v2.0']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,quartz64-a', 'pine64,quartz64-b']
	'pine64,quartzpro64' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,soquartz-blade', 'pine64,soquartz-cm4io', 'pine64,soquartz-model-a']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['powkiddy,rgb10max3', 'powkiddy,rgb20sx', 'powkiddy,rgb30', 'powkiddy,rk2023', 'powkiddy,x55']
	'prt,mecsbc' was expected
	'qnap,ts433' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,cm3-io']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,e25']
	'radxa,e20c' was expected
	'radxa,e52c' was expected
	'radxa,rock' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,rockpi4a', 'radxa,rockpi4a-plus', 'radxa,rockpi4b', 'radxa,rockpi4b-plus', 'radxa,rockpi4c']
	'radxa,rock-4c-plus' was expected
	'radxa,rock-4d' was expected
	'radxa,rock-4se' was expected
	'radxa,rockpi-e' was expected
	'radxa,rockpi-n8' was expected
	'radxa,rockpi-n10' was expected
	'radxa,rockpis' was expected
	'radxa,rock2-square' was expected
	'radxa,rock3a' was expected
	'radxa,rock-3b' was expected
	'radxa,rock-3c' was expected
	'radxa,rock-5-itx' was expected
	'radxa,rock-5a' was expected
	'radxa,rock-5b' was expected
	'radxa,rock-5b-plus' was expected
	'radxa,rock-5c' was expected
	'radxa,rock-s0' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,zero-3e', 'radxa,zero-3w']
	'relfor,saib' was expected
	'rikomagic,mk808' was expected
	'rockchip,rk3036-kylin' was expected
	'rockchip,px3-evb' was expected
	'rockchip,px30-evb' was expected
	'rockchip,px5-evb' was expected
	'rockchip,r88' was expected
	'rockchip,rk3036-evb' was expected
	'rockchip,rk3128-evb' was expected
	'rockchip,rk3228-evb' was expected
	'rockchip,rk3229-evb' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['rockchip,rk3288-evb-act8846', 'rockchip,rk3288-evb-rk808']
	'rockchip,rk3308-evb' was expected
	'rockchip,rk3328-evb' was expected
	'rockchip,rk3368-evb-act8846' was expected
	'rockchip,rk3399-evb' was expected
	'rockchip,rk3399-evb-ind' was expected
	'rockchip,rk3399-sapphire' was expected
	'rockchip,rk3399-sapphire-excavator' was expected
	'rockchip,rk3562-evb2-v10' was expected
	'rockchip,rk3566-box-demo' was expected
	'rockchip,rk3568-evb1-v10' was expected
	'rockchip,rk3576-evb1-v10' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['rockchip,rk3588-evb1-v10', 'rockchip,rk3588-evb2-v10']
	'rockchip,rk3588s-evb1-v10' was expected
	'rockchip,rv1108-evb' was expected
	'rockchip,rk3588-toybrick-x0' was expected
	'sinovoip,rk3308-bpi-p2pro' was expected
	'sinovoip,rk3568-bpi-r2pro' was expected
	'itead,sonoff-ihost' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['tsd,px30-cobra-ltk050h3146w', 'tsd,px30-cobra-ltk050h3146w-a2', 'tsd,px30-cobra-ltk050h3148w', 'tsd,px30-cobra-ltk500hd1829']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['tsd,px30-pp1516-ltk050h3146w-a2', 'tsd,px30-pp1516-ltk050h3148w']
	'tsd,px30-ringneck-haikou' was expected
	'tsd,rk3368-lion-haikou' was expected
	'tsd,rk3399-puma-haikou' was expected
	'tsd,rk3588-jaguar' was expected
	'tsd,rk3588-tiger-haikou' was expected
	'tronsmart,orion-r68-meta' was expected
	'turing,rk1' was expected
	'wolfvision,rk3568-pf5' was expected
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-3b-v1.1', 'xunlong,orangepi-3b-v2.1']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-5-max', 'xunlong,orangepi-5-plus', 'xunlong,orangepi-5-ultra']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-r1-plus', 'xunlong,orangepi-r1-plus-lts']
	'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-5', 'xunlong,orangepi-5b']
	'zkmagic,a95x-z2' was expected
	'rockchip,rk3399' was expected
	'rockchip,rk3288' was expected
	'rockchip,rk3326' was expected
	'rockchip,rk3566' was expected
	'rockchip,rk3576' was expected
	'rockchip,rk3588' was expected
	'armsom,lm7' was expected
	'rockchip,rk3328' was expected
	'bigtreetech,cb2' was expected
	'rockchip,rk3066a' was expected
	'rockchip,rk3188' was expected
	'coolpi,pi-cm5' was expected
	'rockchip,rk3588s' was expected
	'edgeble,neural-compute-module-2' was expected
	'rockchip,rk3568' is not one of ['edgeble,neural-compute-module-6a', 'edgeble,neural-compute-module-6b']
	'rockchip,rv1108' was expected
	'engicam,px30-core' was expected
	'firefly,icore-3588q' was expected
	'firefly,core-3588j' was expected
	'firefly,px30-jd4-core' was expected
	'rockchip,rk3308' was expected
	'forlinx,fet3588-c' was expected
	'friendlyarm,cm3588' was expected
	'rockchip,rk3368' was expected
	'rockchip,rk3128' was expected
	'google,bob-rev12' was expected
	'google,veyron-brain' was expected
	'google,veyron-fievel-rev7' was expected
	'google,gru-rev14' was expected
	'google,veyron-jaq-rev4' was expected
	'google,veyron-jerry-rev14' was expected
	'google,kevin-rev14' was expected
	'google,veyron-mickey-rev7' was expected
	'google,veyron-mighty-rev4' was expected
	'google,veyron-minnie-rev3' was expected
	'google,veyron-pinky' was expected
	'google,scarlet-rev15' was expected
	'google,scarlet-rev15-sku4' was expected
	'google,veyron-speedy-rev8' was expected
	'google,veyron-tiger-rev7' was expected
	'rockchip,rk3229' was expected
	'phytec,rk3288-phycore-som' was expected
	'pine64,pinenote' was expected
	'pine64,pinetab2' was expected
	'pine64,rockpro64' was expected
	'pine64,soquartz' was expected
	'radxa,cm3' was expected
	'radxa,cm3i' was expected
	'rockchip,rk3528' was expected
	'rockchip,rk3582' was expected
	'radxa,rockpi4' was expected
	'vamrs,rk3288-vmarc-som' was expected
	'vamrs,rk3399pro-vmarc-som' was expected
	'rockchip,rv1109' was expected
	'rockchip,rk3036' was expected
	'rockchip,px3' was expected
	'rockchip,px30' was expected
	'rockchip,px5' was expected
	'rockchip,rk3228' was expected
	'rockchip,rk3562' was expected
	'rockchip,rk3568' is not one of ['rockchip,rv1126', 'rockchip,rv1109']
	'tsd,px30-cobra' was expected
	'tsd,px30-pp1516' was expected
	'tsd,rk3588-tiger' was expected
	'xunlong,orangepi-3b' was expected
	'rockchip,rk3318' was expected
	from schema $id: http://devicetree.org/schemas/arm/rockchip.yaml#
arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dtb: /: failed to match any schema with compatible: ['seeed,rk3568-linkstar-h68k-1432v1', 'rockchip,rk3568']






^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)
@ 2025-07-22 16:49 Erik Beck
  2025-07-22 18:44 ` Heiko Stübner
  0 siblings, 1 reply; 6+ messages in thread
From: Erik Beck @ 2025-07-22 16:49 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-kernel, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-rockchip, Heiko Stuebner, Conor Dooley

Thanks Rob;

I had these errors too before I applied my patch to rockchip.yaml. My runs of dtbs_check came up ok after that; I'll double check that my dtschema is up-to-date.

Also, I wound up patching against Heiko's tree, as its rockchip.yaml had more recent additions than Linus' master.

Thanks for the review and information; I'll stay tuned as this goes through further reviews.

Regards,

Erik

Sent from my iPhone

> On Jul 22, 2025, at 12:39, Rob Herring (Arm) <robh@kernel.org> wrote:
> 
> On Mon, 21 Jul 2025 16:17:12 -0400, Erik Beck wrote:
>> 
>> Signed-off-by: Erik Beck <xunil@tahomasoft.com>
>> ---
>> arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>> .../rockchip/rk3568-linkstar-h68k-1432v1.dts  | 740 ++++++++++++++++++
>> 2 files changed, 741 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>  pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
> Base: attempting to guess base-commit...
> Base: tags/v6.16-rc3-17-g404dcaa62651 (exact match)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250721201714.233962-1-xunil@tahomasoft.com:
> 
> arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dtb: / (seeed,rk3568-linkstar-h68k-1432v1): compatible: 'oneOf' conditional failed, one must be fixed:
>    ['seeed,rk3568-linkstar-h68k-1432v1', 'rockchip,rk3568'] is too short
>    'vamrs,ficus' was expected
>    'vamrs,rock960' was expected
>    'amarula,vyasa-rk3288' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['anbernic,rg351m', 'anbernic,rg351v']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['anbernic,rg353p', 'anbernic,rg353ps', 'anbernic,rg353v', 'anbernic,rg353vs', 'anbernic,rg503', 'anbernic,rg-arc-d', 'anbernic,rg-arc-s']
>    'ariaboard,photonicat' was expected
>    'armsom,sige5' was expected
>    'armsom,sige7' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['armsom,w3']
>    'asus,rk3288-tinker' was expected
>    'asus,rk3288-tinker-s' was expected
>    'azw,beelink-a1' was expected
>    'bigtreetech,cb2-manta' was expected
>    'bigtreetech,pi2' was expected
>    'mundoreader,bq-curie2' was expected
>    'mundoreader,bq-edison2qc' was expected
>    'chipspark,popmetal-rk3288' was expected
>    'chipspark,rayeager-px2' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['coolpi,pi-cm5-evb']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['coolpi,pi-cm5-genbook']
>    'coolpi,pi-4b' was expected
>    'edgeble,neural-compute-module-2-io' was expected
>    'edgeble,neural-compute-module-6a-io' was expected
>    'elgin,rv1108-r1' was expected
>    'embedfire,lubancat-1' was expected
>    'embedfire,lubancat-2' was expected
>    'engicam,px30-core-ctouch2' was expected
>    'engicam,px30-core-ctouch2-of10' was expected
>    'engicam,px30-core-edimm2.2' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['mntre,reform2-rcore']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,itx-3588j']
>    'firefly,px30-jd4-core-mb' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,firefly-rk3288', 'firefly,firefly-rk3288-beta']
>    'firefly,firefly-rk3288-reload' was expected
>    'firefly,firefly-rk3399' was expected
>    'firefly,roc-rk3308-cc' was expected
>    'firefly,roc-rk3328-cc' was expected
>    'firefly,roc-rk3328-pc' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,roc-rk3399-pc', 'firefly,roc-rk3399-pc-mezzanine']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,roc-rk3399-pc-plus']
>    'firefly,roc-rk3576-pc' was expected
>    'firefly,rk3566-roc-pc' was expected
>    'firefly,rk3568-roc-pc' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['forlinx,ok3588-c']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r2c', 'friendlyarm,nanopi-r2c-plus', 'friendlyarm,nanopi-r2s', 'friendlyarm,nanopi-r2s-plus']
>    'friendlyarm,nanopi-r3s' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopc-t4', 'friendlyarm,nanopi-m4', 'friendlyarm,nanopi-m4b', 'friendlyarm,nanopi-neo4', 'friendlyarm,nanopi-r4s', 'friendlyarm,nanopi-r4s-enterprise']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r5c', 'friendlyarm,nanopi-r5s']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r6c', 'friendlyarm,nanopi-r6s']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopc-t6', 'friendlyarm,nanopc-t6-lts']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,cm3588-nas']
>    'gameforce,ace' was expected
>    'gameforce,chi' was expected
>    'geekbuying,geekbox' was expected
>    'geniatech,xpi-3128' was expected
>    'google,bob-rev13' was expected
>    'google,veyron-brain-rev0' was expected
>    'google,veyron-fievel-rev8' was expected
>    'google,gru-rev15' was expected
>    'google,veyron-jaq-rev5' was expected
>    'google,veyron-jerry-rev15' was expected
>    'google,kevin-rev15' was expected
>    'google,veyron-mickey-rev8' was expected
>    'google,veyron-mighty-rev5' was expected
>    'google,veyron-minnie-rev4' was expected
>    'google,veyron-pinky-rev2' was expected
>    'google,scarlet-rev15-sku0' was expected
>    'google,scarlet-rev15-sku7' was expected
>    'google,scarlet-rev15-sku2' was expected
>    'google,veyron-speedy-rev9' was expected
>    'google,veyron-tiger-rev8' was expected
>    'haochuangyi,h96-max-v58' was expected
>    'haoyu,marsboard-rk3066' was expected
>    'hardkernel,rk3326-odroid-go2' was expected
>    'hardkernel,rk3326-odroid-go2-v11' was expected
>    'hardkernel,rk3326-odroid-go3' was expected
>    'hardkernel,odroid-m1' was expected
>    'hardkernel,odroid-m1s' was expected
>    'hardkernel,odroid-m2' was expected
>    'hugsun,x99' was expected
>    'indiedroid,nova' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['khadas,edge', 'khadas,edge-captain', 'khadas,edge-v']
>    'khadas,edge2' was expected
>    'kobol,helios64' was expected
>    'mecer,xms6' was expected
>    'leez,p710' was expected
>    'lckfb,tspi-rk3566' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['lunzn,fastrhino-r66s', 'lunzn,fastrhino-r68s']
>    'mqmaker,miqi' was expected
>    'neardi,lba3368' was expected
>    'netxeon,r89' was expected
>    'openailab,eaidk-610' was expected
>    'xunlong,rk3399-orangepi' was expected
>    'phytec,rk3288-pcm-947' was expected
>    'pine64,pinebook-pro' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,pinenote-v1.1', 'pine64,pinenote-v1.2']
>    'pine64,pinephone-pro' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,pinetab2-v0.1', 'pine64,pinetab2-v2.0']
>    'pine64,rock64' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,rockpro64-v2.1', 'pine64,rockpro64-v2.0']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,quartz64-a', 'pine64,quartz64-b']
>    'pine64,quartzpro64' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,soquartz-blade', 'pine64,soquartz-cm4io', 'pine64,soquartz-model-a']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['powkiddy,rgb10max3', 'powkiddy,rgb20sx', 'powkiddy,rgb30', 'powkiddy,rk2023', 'powkiddy,x55']
>    'prt,mecsbc' was expected
>    'qnap,ts433' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,cm3-io']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,e25']
>    'radxa,e20c' was expected
>    'radxa,e52c' was expected
>    'radxa,rock' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,rockpi4a', 'radxa,rockpi4a-plus', 'radxa,rockpi4b', 'radxa,rockpi4b-plus', 'radxa,rockpi4c']
>    'radxa,rock-4c-plus' was expected
>    'radxa,rock-4d' was expected
>    'radxa,rock-4se' was expected
>    'radxa,rockpi-e' was expected
>    'radxa,rockpi-n8' was expected
>    'radxa,rockpi-n10' was expected
>    'radxa,rockpis' was expected
>    'radxa,rock2-square' was expected
>    'radxa,rock3a' was expected
>    'radxa,rock-3b' was expected
>    'radxa,rock-3c' was expected
>    'radxa,rock-5-itx' was expected
>    'radxa,rock-5a' was expected
>    'radxa,rock-5b' was expected
>    'radxa,rock-5b-plus' was expected
>    'radxa,rock-5c' was expected
>    'radxa,rock-s0' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,zero-3e', 'radxa,zero-3w']
>    'relfor,saib' was expected
>    'rikomagic,mk808' was expected
>    'rockchip,rk3036-kylin' was expected
>    'rockchip,px3-evb' was expected
>    'rockchip,px30-evb' was expected
>    'rockchip,px5-evb' was expected
>    'rockchip,r88' was expected
>    'rockchip,rk3036-evb' was expected
>    'rockchip,rk3128-evb' was expected
>    'rockchip,rk3228-evb' was expected
>    'rockchip,rk3229-evb' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['rockchip,rk3288-evb-act8846', 'rockchip,rk3288-evb-rk808']
>    'rockchip,rk3308-evb' was expected
>    'rockchip,rk3328-evb' was expected
>    'rockchip,rk3368-evb-act8846' was expected
>    'rockchip,rk3399-evb' was expected
>    'rockchip,rk3399-evb-ind' was expected
>    'rockchip,rk3399-sapphire' was expected
>    'rockchip,rk3399-sapphire-excavator' was expected
>    'rockchip,rk3562-evb2-v10' was expected
>    'rockchip,rk3566-box-demo' was expected
>    'rockchip,rk3568-evb1-v10' was expected
>    'rockchip,rk3576-evb1-v10' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['rockchip,rk3588-evb1-v10', 'rockchip,rk3588-evb2-v10']
>    'rockchip,rk3588s-evb1-v10' was expected
>    'rockchip,rv1108-evb' was expected
>    'rockchip,rk3588-toybrick-x0' was expected
>    'sinovoip,rk3308-bpi-p2pro' was expected
>    'sinovoip,rk3568-bpi-r2pro' was expected
>    'itead,sonoff-ihost' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['tsd,px30-cobra-ltk050h3146w', 'tsd,px30-cobra-ltk050h3146w-a2', 'tsd,px30-cobra-ltk050h3148w', 'tsd,px30-cobra-ltk500hd1829']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['tsd,px30-pp1516-ltk050h3146w-a2', 'tsd,px30-pp1516-ltk050h3148w']
>    'tsd,px30-ringneck-haikou' was expected
>    'tsd,rk3368-lion-haikou' was expected
>    'tsd,rk3399-puma-haikou' was expected
>    'tsd,rk3588-jaguar' was expected
>    'tsd,rk3588-tiger-haikou' was expected
>    'tronsmart,orion-r68-meta' was expected
>    'turing,rk1' was expected
>    'wolfvision,rk3568-pf5' was expected
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-3b-v1.1', 'xunlong,orangepi-3b-v2.1']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-5-max', 'xunlong,orangepi-5-plus', 'xunlong,orangepi-5-ultra']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-r1-plus', 'xunlong,orangepi-r1-plus-lts']
>    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-5', 'xunlong,orangepi-5b']
>    'zkmagic,a95x-z2' was expected
>    'rockchip,rk3399' was expected
>    'rockchip,rk3288' was expected
>    'rockchip,rk3326' was expected
>    'rockchip,rk3566' was expected
>    'rockchip,rk3576' was expected
>    'rockchip,rk3588' was expected
>    'armsom,lm7' was expected
>    'rockchip,rk3328' was expected
>    'bigtreetech,cb2' was expected
>    'rockchip,rk3066a' was expected
>    'rockchip,rk3188' was expected
>    'coolpi,pi-cm5' was expected
>    'rockchip,rk3588s' was expected
>    'edgeble,neural-compute-module-2' was expected
>    'rockchip,rk3568' is not one of ['edgeble,neural-compute-module-6a', 'edgeble,neural-compute-module-6b']
>    'rockchip,rv1108' was expected
>    'engicam,px30-core' was expected
>    'firefly,icore-3588q' was expected
>    'firefly,core-3588j' was expected
>    'firefly,px30-jd4-core' was expected
>    'rockchip,rk3308' was expected
>    'forlinx,fet3588-c' was expected
>    'friendlyarm,cm3588' was expected
>    'rockchip,rk3368' was expected
>    'rockchip,rk3128' was expected
>    'google,bob-rev12' was expected
>    'google,veyron-brain' was expected
>    'google,veyron-fievel-rev7' was expected
>    'google,gru-rev14' was expected
>    'google,veyron-jaq-rev4' was expected
>    'google,veyron-jerry-rev14' was expected
>    'google,kevin-rev14' was expected
>    'google,veyron-mickey-rev7' was expected
>    'google,veyron-mighty-rev4' was expected
>    'google,veyron-minnie-rev3' was expected
>    'google,veyron-pinky' was expected
>    'google,scarlet-rev15' was expected
>    'google,scarlet-rev15-sku4' was expected
>    'google,veyron-speedy-rev8' was expected
>    'google,veyron-tiger-rev7' was expected
>    'rockchip,rk3229' was expected
>    'phytec,rk3288-phycore-som' was expected
>    'pine64,pinenote' was expected
>    'pine64,pinetab2' was expected
>    'pine64,rockpro64' was expected
>    'pine64,soquartz' was expected
>    'radxa,cm3' was expected
>    'radxa,cm3i' was expected
>    'rockchip,rk3528' was expected
>    'rockchip,rk3582' was expected
>    'radxa,rockpi4' was expected
>    'vamrs,rk3288-vmarc-som' was expected
>    'vamrs,rk3399pro-vmarc-som' was expected
>    'rockchip,rv1109' was expected
>    'rockchip,rk3036' was expected
>    'rockchip,px3' was expected
>    'rockchip,px30' was expected
>    'rockchip,px5' was expected
>    'rockchip,rk3228' was expected
>    'rockchip,rk3562' was expected
>    'rockchip,rk3568' is not one of ['rockchip,rv1126', 'rockchip,rv1109']
>    'tsd,px30-cobra' was expected
>    'tsd,px30-pp1516' was expected
>    'tsd,rk3588-tiger' was expected
>    'xunlong,orangepi-3b' was expected
>    'rockchip,rk3318' was expected
>    from schema $id: http://devicetree.org/schemas/arm/rockchip.yaml#
> arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dtb: /: failed to match any schema with compatible: ['seeed,rk3568-linkstar-h68k-1432v1', 'rockchip,rk3568']

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)
  2025-07-22 16:49 Erik Beck
@ 2025-07-22 18:44 ` Heiko Stübner
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2025-07-22 18:44 UTC (permalink / raw)
  To: Rob Herring, Erik Beck
  Cc: linux-kernel, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-rockchip, Conor Dooley

Hi Erik,

Am Dienstag, 22. Juli 2025, 18:49:03 Mitteleuropäische Sommerzeit schrieb Erik Beck:
> Thanks Rob;
> 
> I had these errors too before I applied my patch to rockchip.yaml. My runs of dtbs_check came up ok after that; I'll double check that my dtschema is up-to-date.

please don't top-post, see [0]


> Also, I wound up patching against Heiko's tree, as its rockchip.yaml had more recent additions than Linus' master.

the issue here is more that your mail structure is still broken

I see git-send-email as sender, but somehow you lost the threading.
Normally git-send-email automatically sends the patches 1+2 as
"in-reply-to" to the cover-letter. This would mark them as belonging
together and Robs bot would then handle both patches together.

As it stands now, you "just" sent two completely separate patches.


While we're on the topic of structure, the patch subject (first line)
should reflect the "subsystem" it gets applied to.

So the patch to rockchip.yaml should be something like [1]
	dt-bindings: arm: rockchip: add LinkStar-H68k-1432v1
and the patch adding the devicetree should be like [2]
	arm64: dts: rockchip: add LinkStar-H68k-1432v1

Afterwards a blank line, then a commit message, see all the other
patches in [1] and [2]. We do expect some short description of the
device you're adding.

Hope that helps a bit
Heiko


[0] https://www.kernel.org/doc/html/v6.14-rc4/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/Documentation/devicetree/bindings/arm/rockchip.yaml
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/arch/arm64/boot/dts/rockchip
> 
> Thanks for the review and information; I'll stay tuned as this goes through further reviews.
> 
> Regards,
> 
> Erik
> 
> Sent from my iPhone
> 
> > On Jul 22, 2025, at 12:39, Rob Herring (Arm) <robh@kernel.org> wrote:
> > 
> > On Mon, 21 Jul 2025 16:17:12 -0400, Erik Beck wrote:
> >> 
> >> Signed-off-by: Erik Beck <xunil@tahomasoft.com>
> >> ---
> >> arch/arm64/boot/dts/rockchip/Makefile         |   1 +
> >> .../rockchip/rk3568-linkstar-h68k-1432v1.dts  | 740 ++++++++++++++++++
> >> 2 files changed, 741 insertions(+)
> >> create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> > 
> > 
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> > 
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to reply
> > unless the platform maintainer has comments.
> > 
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> > 
> >  pip3 install dtschema --upgrade
> > 
> > 
> > This patch series was applied (using b4) to base:
> > Base: attempting to guess base-commit...
> > Base: tags/v6.16-rc3-17-g404dcaa62651 (exact match)
> > 
> > If this is not the correct base, please add 'base-commit' tag
> > (or use b4 which does this automatically)
> > 
> > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250721201714.233962-1-xunil@tahomasoft.com:
> > 
> > arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dtb: / (seeed,rk3568-linkstar-h68k-1432v1): compatible: 'oneOf' conditional failed, one must be fixed:
> >    ['seeed,rk3568-linkstar-h68k-1432v1', 'rockchip,rk3568'] is too short
> >    'vamrs,ficus' was expected
> >    'vamrs,rock960' was expected
> >    'amarula,vyasa-rk3288' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['anbernic,rg351m', 'anbernic,rg351v']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['anbernic,rg353p', 'anbernic,rg353ps', 'anbernic,rg353v', 'anbernic,rg353vs', 'anbernic,rg503', 'anbernic,rg-arc-d', 'anbernic,rg-arc-s']
> >    'ariaboard,photonicat' was expected
> >    'armsom,sige5' was expected
> >    'armsom,sige7' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['armsom,w3']
> >    'asus,rk3288-tinker' was expected
> >    'asus,rk3288-tinker-s' was expected
> >    'azw,beelink-a1' was expected
> >    'bigtreetech,cb2-manta' was expected
> >    'bigtreetech,pi2' was expected
> >    'mundoreader,bq-curie2' was expected
> >    'mundoreader,bq-edison2qc' was expected
> >    'chipspark,popmetal-rk3288' was expected
> >    'chipspark,rayeager-px2' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['coolpi,pi-cm5-evb']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['coolpi,pi-cm5-genbook']
> >    'coolpi,pi-4b' was expected
> >    'edgeble,neural-compute-module-2-io' was expected
> >    'edgeble,neural-compute-module-6a-io' was expected
> >    'elgin,rv1108-r1' was expected
> >    'embedfire,lubancat-1' was expected
> >    'embedfire,lubancat-2' was expected
> >    'engicam,px30-core-ctouch2' was expected
> >    'engicam,px30-core-ctouch2-of10' was expected
> >    'engicam,px30-core-edimm2.2' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['mntre,reform2-rcore']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,itx-3588j']
> >    'firefly,px30-jd4-core-mb' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,firefly-rk3288', 'firefly,firefly-rk3288-beta']
> >    'firefly,firefly-rk3288-reload' was expected
> >    'firefly,firefly-rk3399' was expected
> >    'firefly,roc-rk3308-cc' was expected
> >    'firefly,roc-rk3328-cc' was expected
> >    'firefly,roc-rk3328-pc' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,roc-rk3399-pc', 'firefly,roc-rk3399-pc-mezzanine']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['firefly,roc-rk3399-pc-plus']
> >    'firefly,roc-rk3576-pc' was expected
> >    'firefly,rk3566-roc-pc' was expected
> >    'firefly,rk3568-roc-pc' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['forlinx,ok3588-c']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r2c', 'friendlyarm,nanopi-r2c-plus', 'friendlyarm,nanopi-r2s', 'friendlyarm,nanopi-r2s-plus']
> >    'friendlyarm,nanopi-r3s' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopc-t4', 'friendlyarm,nanopi-m4', 'friendlyarm,nanopi-m4b', 'friendlyarm,nanopi-neo4', 'friendlyarm,nanopi-r4s', 'friendlyarm,nanopi-r4s-enterprise']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r5c', 'friendlyarm,nanopi-r5s']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopi-r6c', 'friendlyarm,nanopi-r6s']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,nanopc-t6', 'friendlyarm,nanopc-t6-lts']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['friendlyarm,cm3588-nas']
> >    'gameforce,ace' was expected
> >    'gameforce,chi' was expected
> >    'geekbuying,geekbox' was expected
> >    'geniatech,xpi-3128' was expected
> >    'google,bob-rev13' was expected
> >    'google,veyron-brain-rev0' was expected
> >    'google,veyron-fievel-rev8' was expected
> >    'google,gru-rev15' was expected
> >    'google,veyron-jaq-rev5' was expected
> >    'google,veyron-jerry-rev15' was expected
> >    'google,kevin-rev15' was expected
> >    'google,veyron-mickey-rev8' was expected
> >    'google,veyron-mighty-rev5' was expected
> >    'google,veyron-minnie-rev4' was expected
> >    'google,veyron-pinky-rev2' was expected
> >    'google,scarlet-rev15-sku0' was expected
> >    'google,scarlet-rev15-sku7' was expected
> >    'google,scarlet-rev15-sku2' was expected
> >    'google,veyron-speedy-rev9' was expected
> >    'google,veyron-tiger-rev8' was expected
> >    'haochuangyi,h96-max-v58' was expected
> >    'haoyu,marsboard-rk3066' was expected
> >    'hardkernel,rk3326-odroid-go2' was expected
> >    'hardkernel,rk3326-odroid-go2-v11' was expected
> >    'hardkernel,rk3326-odroid-go3' was expected
> >    'hardkernel,odroid-m1' was expected
> >    'hardkernel,odroid-m1s' was expected
> >    'hardkernel,odroid-m2' was expected
> >    'hugsun,x99' was expected
> >    'indiedroid,nova' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['khadas,edge', 'khadas,edge-captain', 'khadas,edge-v']
> >    'khadas,edge2' was expected
> >    'kobol,helios64' was expected
> >    'mecer,xms6' was expected
> >    'leez,p710' was expected
> >    'lckfb,tspi-rk3566' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['lunzn,fastrhino-r66s', 'lunzn,fastrhino-r68s']
> >    'mqmaker,miqi' was expected
> >    'neardi,lba3368' was expected
> >    'netxeon,r89' was expected
> >    'openailab,eaidk-610' was expected
> >    'xunlong,rk3399-orangepi' was expected
> >    'phytec,rk3288-pcm-947' was expected
> >    'pine64,pinebook-pro' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,pinenote-v1.1', 'pine64,pinenote-v1.2']
> >    'pine64,pinephone-pro' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,pinetab2-v0.1', 'pine64,pinetab2-v2.0']
> >    'pine64,rock64' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,rockpro64-v2.1', 'pine64,rockpro64-v2.0']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,quartz64-a', 'pine64,quartz64-b']
> >    'pine64,quartzpro64' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['pine64,soquartz-blade', 'pine64,soquartz-cm4io', 'pine64,soquartz-model-a']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['powkiddy,rgb10max3', 'powkiddy,rgb20sx', 'powkiddy,rgb30', 'powkiddy,rk2023', 'powkiddy,x55']
> >    'prt,mecsbc' was expected
> >    'qnap,ts433' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,cm3-io']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,e25']
> >    'radxa,e20c' was expected
> >    'radxa,e52c' was expected
> >    'radxa,rock' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,rockpi4a', 'radxa,rockpi4a-plus', 'radxa,rockpi4b', 'radxa,rockpi4b-plus', 'radxa,rockpi4c']
> >    'radxa,rock-4c-plus' was expected
> >    'radxa,rock-4d' was expected
> >    'radxa,rock-4se' was expected
> >    'radxa,rockpi-e' was expected
> >    'radxa,rockpi-n8' was expected
> >    'radxa,rockpi-n10' was expected
> >    'radxa,rockpis' was expected
> >    'radxa,rock2-square' was expected
> >    'radxa,rock3a' was expected
> >    'radxa,rock-3b' was expected
> >    'radxa,rock-3c' was expected
> >    'radxa,rock-5-itx' was expected
> >    'radxa,rock-5a' was expected
> >    'radxa,rock-5b' was expected
> >    'radxa,rock-5b-plus' was expected
> >    'radxa,rock-5c' was expected
> >    'radxa,rock-s0' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['radxa,zero-3e', 'radxa,zero-3w']
> >    'relfor,saib' was expected
> >    'rikomagic,mk808' was expected
> >    'rockchip,rk3036-kylin' was expected
> >    'rockchip,px3-evb' was expected
> >    'rockchip,px30-evb' was expected
> >    'rockchip,px5-evb' was expected
> >    'rockchip,r88' was expected
> >    'rockchip,rk3036-evb' was expected
> >    'rockchip,rk3128-evb' was expected
> >    'rockchip,rk3228-evb' was expected
> >    'rockchip,rk3229-evb' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['rockchip,rk3288-evb-act8846', 'rockchip,rk3288-evb-rk808']
> >    'rockchip,rk3308-evb' was expected
> >    'rockchip,rk3328-evb' was expected
> >    'rockchip,rk3368-evb-act8846' was expected
> >    'rockchip,rk3399-evb' was expected
> >    'rockchip,rk3399-evb-ind' was expected
> >    'rockchip,rk3399-sapphire' was expected
> >    'rockchip,rk3399-sapphire-excavator' was expected
> >    'rockchip,rk3562-evb2-v10' was expected
> >    'rockchip,rk3566-box-demo' was expected
> >    'rockchip,rk3568-evb1-v10' was expected
> >    'rockchip,rk3576-evb1-v10' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['rockchip,rk3588-evb1-v10', 'rockchip,rk3588-evb2-v10']
> >    'rockchip,rk3588s-evb1-v10' was expected
> >    'rockchip,rv1108-evb' was expected
> >    'rockchip,rk3588-toybrick-x0' was expected
> >    'sinovoip,rk3308-bpi-p2pro' was expected
> >    'sinovoip,rk3568-bpi-r2pro' was expected
> >    'itead,sonoff-ihost' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['tsd,px30-cobra-ltk050h3146w', 'tsd,px30-cobra-ltk050h3146w-a2', 'tsd,px30-cobra-ltk050h3148w', 'tsd,px30-cobra-ltk500hd1829']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['tsd,px30-pp1516-ltk050h3146w-a2', 'tsd,px30-pp1516-ltk050h3148w']
> >    'tsd,px30-ringneck-haikou' was expected
> >    'tsd,rk3368-lion-haikou' was expected
> >    'tsd,rk3399-puma-haikou' was expected
> >    'tsd,rk3588-jaguar' was expected
> >    'tsd,rk3588-tiger-haikou' was expected
> >    'tronsmart,orion-r68-meta' was expected
> >    'turing,rk1' was expected
> >    'wolfvision,rk3568-pf5' was expected
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-3b-v1.1', 'xunlong,orangepi-3b-v2.1']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-5-max', 'xunlong,orangepi-5-plus', 'xunlong,orangepi-5-ultra']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-r1-plus', 'xunlong,orangepi-r1-plus-lts']
> >    'seeed,rk3568-linkstar-h68k-1432v1' is not one of ['xunlong,orangepi-5', 'xunlong,orangepi-5b']
> >    'zkmagic,a95x-z2' was expected
> >    'rockchip,rk3399' was expected
> >    'rockchip,rk3288' was expected
> >    'rockchip,rk3326' was expected
> >    'rockchip,rk3566' was expected
> >    'rockchip,rk3576' was expected
> >    'rockchip,rk3588' was expected
> >    'armsom,lm7' was expected
> >    'rockchip,rk3328' was expected
> >    'bigtreetech,cb2' was expected
> >    'rockchip,rk3066a' was expected
> >    'rockchip,rk3188' was expected
> >    'coolpi,pi-cm5' was expected
> >    'rockchip,rk3588s' was expected
> >    'edgeble,neural-compute-module-2' was expected
> >    'rockchip,rk3568' is not one of ['edgeble,neural-compute-module-6a', 'edgeble,neural-compute-module-6b']
> >    'rockchip,rv1108' was expected
> >    'engicam,px30-core' was expected
> >    'firefly,icore-3588q' was expected
> >    'firefly,core-3588j' was expected
> >    'firefly,px30-jd4-core' was expected
> >    'rockchip,rk3308' was expected
> >    'forlinx,fet3588-c' was expected
> >    'friendlyarm,cm3588' was expected
> >    'rockchip,rk3368' was expected
> >    'rockchip,rk3128' was expected
> >    'google,bob-rev12' was expected
> >    'google,veyron-brain' was expected
> >    'google,veyron-fievel-rev7' was expected
> >    'google,gru-rev14' was expected
> >    'google,veyron-jaq-rev4' was expected
> >    'google,veyron-jerry-rev14' was expected
> >    'google,kevin-rev14' was expected
> >    'google,veyron-mickey-rev7' was expected
> >    'google,veyron-mighty-rev4' was expected
> >    'google,veyron-minnie-rev3' was expected
> >    'google,veyron-pinky' was expected
> >    'google,scarlet-rev15' was expected
> >    'google,scarlet-rev15-sku4' was expected
> >    'google,veyron-speedy-rev8' was expected
> >    'google,veyron-tiger-rev7' was expected
> >    'rockchip,rk3229' was expected
> >    'phytec,rk3288-phycore-som' was expected
> >    'pine64,pinenote' was expected
> >    'pine64,pinetab2' was expected
> >    'pine64,rockpro64' was expected
> >    'pine64,soquartz' was expected
> >    'radxa,cm3' was expected
> >    'radxa,cm3i' was expected
> >    'rockchip,rk3528' was expected
> >    'rockchip,rk3582' was expected
> >    'radxa,rockpi4' was expected
> >    'vamrs,rk3288-vmarc-som' was expected
> >    'vamrs,rk3399pro-vmarc-som' was expected
> >    'rockchip,rv1109' was expected
> >    'rockchip,rk3036' was expected
> >    'rockchip,px3' was expected
> >    'rockchip,px30' was expected
> >    'rockchip,px5' was expected
> >    'rockchip,rk3228' was expected
> >    'rockchip,rk3562' was expected
> >    'rockchip,rk3568' is not one of ['rockchip,rv1126', 'rockchip,rv1109']
> >    'tsd,px30-cobra' was expected
> >    'tsd,px30-pp1516' was expected
> >    'tsd,rk3588-tiger' was expected
> >    'xunlong,orangepi-3b' was expected
> >    'rockchip,rk3318' was expected
> >    from schema $id: http://devicetree.org/schemas/arm/rockchip.yaml#
> > arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dtb: /: failed to match any schema with compatible: ['seeed,rk3568-linkstar-h68k-1432v1', 'rockchip,rk3568']
> 





^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)
  2025-07-21 20:17 [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568) Erik Beck
  2025-07-22 16:18 ` Rob Herring (Arm)
@ 2025-07-23  6:45 ` Krzysztof Kozlowski
  2025-07-23 13:50 ` Chukun Pan
  2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-23  6:45 UTC (permalink / raw)
  To: Erik Beck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

On 21/07/2025 22:17, Erik Beck wrote:
> 
> Signed-off-by: Erik Beck <xunil@tahomasoft.com>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.


Please version your patches correctly, e.g. use b4 or git format-patch
-vX, and add changelog in cover letter or under '---' of individual
patches describing changes from previous version.


> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../rockchip/rk3568-linkstar-h68k-1432v1.dts  | 740 ++++++++++++++++++
>  2 files changed, 741 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> 

...

> +        hdmi-con {
> +                compatible = "hdmi-connector";
> +                type = "a";
> +
> +                port {
> +                        hdmi_con_in: endpoint {
> +                                remote-endpoint = <&hdmi_out_con>;
> +                        };
> +                };
> +        };
> +
> +        gpio-keys {
> +                compatible = "gpio-keys";
> +                pinctrl-0 = <&reset_button_pin>;
> +                pinctrl-names = "default";
> +
> +        /* Middle inset/recessed button,
> +                  marked by clockwise arrow/circle */

Messed indentation


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568)
  2025-07-21 20:17 [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568) Erik Beck
  2025-07-22 16:18 ` Rob Herring (Arm)
  2025-07-23  6:45 ` Krzysztof Kozlowski
@ 2025-07-23 13:50 ` Chukun Pan
  2 siblings, 0 replies; 6+ messages in thread
From: Chukun Pan @ 2025-07-23 13:50 UTC (permalink / raw)
  To: xunil
  Cc: conor+dt, devicetree, heiko, krzk+dt, linux-arm-kernel,
	linux-kernel, linux-rockchip, Chukun Pan

Hi,

> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> @@ -0,0 +1,740 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2022 AmadeusGhost <amadeus@jmu.edu.cn>

Please do not add my copyright.
I don't know if your board is the same as my HINLINK H68K board.

> +        model = "Seeed LinkStar H68K-1432V1 (RK3568) DDR4 Board";
> +        compatible = "seeed,rk3568-linkstar-h68k-1432v1", "rockchip,rk3568";

Seeed is the name of the agent, not the actual manufacturer.
LinkStar is an alias given by HINLINK. Their versions and names
are quite confusing, like 1432V1 here.

--
2.25.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-07-23 13:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 20:17 [PATCH 2/2 v2a]: New board support,LinkStar-H68k-1432v1 (RK3568) Erik Beck
2025-07-22 16:18 ` Rob Herring (Arm)
2025-07-23  6:45 ` Krzysztof Kozlowski
2025-07-23 13:50 ` Chukun Pan
  -- strict thread matches above, loose matches on Subject: below --
2025-07-22 16:49 Erik Beck
2025-07-22 18:44 ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).