public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 2/5] pinctrl: pinconf-generic: Add API for pinmux propertity in DTS file
Date: Wed, 8 Jan 2025 11:14:48 +0800	[thread overview]
Message-ID: <cabfb078-8aed-4e4e-8eec-194f2a24df93@amlogic.com> (raw)
In-Reply-To: <CACRpkdYrUDK9RsJ0VzksUNAyZ=grdQLAkMN1_BjeqQumY8bjSw@mail.gmail.com>

Hi Linus,
    Thanks for your reply.

On 2025/1/7 23:18, Linus Walleij wrote:
> [ EXTERNAL EMAIL ]
> 
> On Thu, Dec 26, 2024 at 8:57 AM Xianwei Zhao via B4 Relay
> <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote:
> 
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> When describing pin mux func through pinmux propertity,
>> a standard API is added for support. The pinmux contains pin
>> identification and mux values, which can include multiple
>> pins. And groups configuration use other word. DTS such as:
>>
>> func-name {
>>          group_alias: group-name{
>>                  pinmux= <pin_id << 8 | mux_value)>,
>>                          <pin_id << 8 | mux_value)>;
>>                  bias-pull-up;
>>                  drive-strength-microamp = <4000>;
>>          };
>> };
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> 
> There are some build errors, but I really like the path taken with
> the utility function here!
> 
I will fix the issue Reported by kernel test robot next version.
> Yours,
> Linus Walleij

  reply	other threads:[~2025-01-08  3:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26  7:57 [PATCH v2 0/5] Pinctrl: Add Amlogic pinctrl driver Xianwei Zhao via B4 Relay
2024-12-26  7:57 ` [PATCH v2 1/5] dt-bindings: pinctrl: Add support for Amlogic SoCs Xianwei Zhao via B4 Relay
2025-01-02 21:24   ` Rob Herring
2025-01-09  2:32     ` Xianwei Zhao
2024-12-26  7:57 ` [PATCH v2 2/5] pinctrl: pinconf-generic: Add API for pinmux propertity in DTS file Xianwei Zhao via B4 Relay
2024-12-26 10:15   ` kernel test robot
2025-01-07 15:18   ` Linus Walleij
2025-01-08  3:14     ` Xianwei Zhao [this message]
2025-01-07 16:47   ` Jerome Brunet
2025-01-14  6:46     ` Xianwei Zhao
2024-12-26  7:57 ` [PATCH v2 3/5] pinctrl: Add driver support for Amlogic SoCs Xianwei Zhao via B4 Relay
2024-12-27 21:11   ` Martin Blumenstingl
2025-01-10  6:09     ` Xianwei Zhao
2024-12-26  7:57 ` [PATCH v2 4/5] arm64: dts: amlogic: a4: add pinctrl node Xianwei Zhao via B4 Relay
2024-12-26  7:57 ` [PATCH v2 5/5] MAINTAINERS: Add an entry for Amlogic pinctrl driver Xianwei Zhao via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cabfb078-8aed-4e4e-8eec-194f2a24df93@amlogic.com \
    --to=xianwei.zhao@amlogic.com \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox