From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prashanth K <quic_prashk@quicinc.com>,
stable@vger.kernel.org, Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Tejas Joglekar <joglekar@synopsys.com>,
linux-kernel@vger.kernel.org, linux-usbyy@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'xhci-sg-trb-cache-size-quirk'
Date: Mon, 20 Nov 2023 10:14:06 +0100 [thread overview]
Message-ID: <caccb6a2-643f-427e-a601-590a1ce88802@kernel.org> (raw)
In-Reply-To: <20231120055803.224634-3-quic_prashk@quicinc.com>
On 20/11/2023 06:58, Prashanth K wrote:
> Add a new 'xhci-sg-trb-cache-size-quirk' DT quirk to dwc3 core
> for preventing xhci hang issue while using SG buffers.
Neither commit msg nor property describes the hardware feature. Please
describe the hardware, not OS behavior, in the property. Both in the
property name and in its description.
>
> Cc: <stable@vger.kernel.org> # 5.11
> Fixes: bac1ec551434 ("usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK")
> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
> ---
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Also, use proper order of patches - first bindings, then their user.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-20 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 5:58 [PATCH v2 0/2] Add support for xhci-sg-trb-cache-size-quirk Prashanth K
2023-11-20 5:58 ` [PATCH v2 1/2] usb: dwc3: core: " Prashanth K
2023-11-20 5:58 ` [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'xhci-sg-trb-cache-size-quirk' Prashanth K
2023-11-20 9:14 ` Krzysztof Kozlowski [this message]
2023-11-20 9:15 ` Krzysztof Kozlowski
2023-11-20 9:30 ` [PATCH v2 0/2] Add support for xhci-sg-trb-cache-size-quirk Krzysztof Kozlowski
2023-11-21 12:34 ` Prashanth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caccb6a2-643f-427e-a601-590a1ce88802@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=joglekar@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usbyy@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=quic_prashk@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox