Re: [PATCH v3 1/3] dt-binding: display: Add ITE IT61620 MIPI DSI to HDMI bridge

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/10/2025 23:13, Krzysztof Kozlowski wrote:
> On 09/10/2025 17:02, Pet Weng wrote:
>> +  The HDMI transmitter side supports up to 4Kx2K@30Hz resolutions, and is
>> +  compliant with HDMI 1.4b and HDCP 1.4.
>> +
>> +  For audio, the IT61620 supports up to 8-channel LPCM via I2S (multi-line or
>> +  TDM mode), with optional S/PDIF or DSD (for SACD). It supports audio
>> +  sampling rates up to 192kHz.
>> +
>> +allOf:
>> +  - $ref: /schemas/sound/dai-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: ite,it61620
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +    description: interrupt specifier of INT pin
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +    description: GPIO specifier of RESET pin
> 
> 
> If you are going to send new version: drop description, pretty
> redundant. Cannot be anything else.
> 
>> +
>> +  ivdd-supply:
>> +    description: core voltage
>> +
>> +  ovdd-supply:
>> +    description: I/O voltage
>> +
>> +  ovdd1833-supply:
>> +    description: flexible I/O votage
>> +
>> +  pinctrl-names:
>> +    items:
>> +      - const: default
>> +
>> +  pinctrl-0:
>> +    maxItems: 1
> 
> 
> Both pinctrl properties are usually redundant here. Does your driver
> actually require them?

And now I checked and I do not see direct usage in the driver or did I
miss something?

Best regards,
Krzysztof