From: Kevin Cernekee <cernekee@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>, <linux-mips@linux-mips.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] MIPS: Squash pci_fixup_irqs() compiler warning
Date: Sun, 17 Apr 2011 12:01:08 -0700 [thread overview]
Message-ID: <cb01d61712b1374a8c62bc765094ea7e@localhost> (raw)
MIPS Linux is unique in that it uses a "const struct pci_dev *" argument
to discourage bad coding practices in pcibios_map_irq(). Add a cast so
that this warning goes away:
arch/mips/pci/pci.c: In function 'pcibios_init':
arch/mips/pci/pci.c:165:45: warning: passing argument 2 of 'pci_fixup_irqs' from incompatible pointer type
include/linux/pci.h:856:6: note: expected 'int (*)(struct pci_dev *, u8, u8)' but argument is of type 'struct pci_dev *'
Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---
Reference:
http://www.mail-archive.com/gnewsense-dev@nongnu.org/msg00706.html
It's been two years since the original discussion, and the warning is
still there. It is now the only warning left in my kernel build.
I was hoping we could get this resolved for good (one way or another).
arch/mips/pci/pci.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/mips/pci/pci.c b/arch/mips/pci/pci.c
index 33bba7b..9a35cd6 100644
--- a/arch/mips/pci/pci.c
+++ b/arch/mips/pci/pci.c
@@ -157,7 +157,8 @@ static int __init pcibios_init(void)
for (hose = hose_head; hose; hose = hose->next)
pcibios_scanbus(hose);
- pci_fixup_irqs(pci_common_swizzle, pcibios_map_irq);
+ pci_fixup_irqs(pci_common_swizzle,
+ (int (*)(struct pci_dev *, u8, u8))pcibios_map_irq);
pci_initialized = 1;
--
1.7.4.3
next reply other threads:[~2011-04-17 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 19:01 Kevin Cernekee [this message]
2011-04-18 17:27 ` [PATCH] MIPS: Squash pci_fixup_irqs() compiler warning David Daney
2011-05-13 10:17 ` Ralf Baechle
2011-05-19 13:15 ` [PATCH] PCI: Make the struct pci_dev * argument of map_irq const Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb01d61712b1374a8c62bc765094ea7e@localhost \
--to=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox