linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ipc: Add missing sys_ni entries for ipc/compat.c functions
@ 2011-05-14  0:07 Kevin Cernekee
  2011-05-17 10:01 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Cernekee @ 2011-05-14  0:07 UTC (permalink / raw)
  To: Andrew Morton, Al Viro, Stephen Rothwell; +Cc: linux-mips, linux-kernel

When building with:

CONFIG_64BIT=y
CONFIG_MIPS32_COMPAT=y
CONFIG_COMPAT=y
CONFIG_MIPS32_O32=y
CONFIG_MIPS32_N32=y
CONFIG_SYSVIPC is not set
(and implicitly: CONFIG_SYSVIPC_COMPAT is not set)

the final link fails with unresolved symbols for:

compat_sys_semctl, compat_sys_msgsnd, compat_sys_msgrcv,
compat_sys_shmctl, compat_sys_msgctl, compat_sys_semtimedop

The fix is to add cond_syscall declarations for all syscalls in
ipc/compat.c

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
---
 kernel/sys_ni.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
index 25cc41c..1140c12 100644
--- a/kernel/sys_ni.c
+++ b/kernel/sys_ni.c
@@ -69,15 +69,22 @@ cond_syscall(compat_sys_epoll_pwait);
 cond_syscall(sys_semget);
 cond_syscall(sys_semop);
 cond_syscall(sys_semtimedop);
+cond_syscall(compat_sys_semtimedop);
 cond_syscall(sys_semctl);
+cond_syscall(compat_sys_semctl);
 cond_syscall(sys_msgget);
 cond_syscall(sys_msgsnd);
+cond_syscall(compat_sys_msgsnd);
 cond_syscall(sys_msgrcv);
+cond_syscall(compat_sys_msgrcv);
 cond_syscall(sys_msgctl);
+cond_syscall(compat_sys_msgctl);
 cond_syscall(sys_shmget);
 cond_syscall(sys_shmat);
+cond_syscall(compat_sys_shmat);
 cond_syscall(sys_shmdt);
 cond_syscall(sys_shmctl);
+cond_syscall(compat_sys_shmctl);
 cond_syscall(sys_mq_open);
 cond_syscall(sys_mq_unlink);
 cond_syscall(sys_mq_timedsend);
-- 
1.7.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipc: Add missing sys_ni entries for ipc/compat.c functions
  2011-05-14  0:07 [PATCH] ipc: Add missing sys_ni entries for ipc/compat.c functions Kevin Cernekee
@ 2011-05-17 10:01 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2011-05-17 10:01 UTC (permalink / raw)
  To: Kevin Cernekee
  Cc: Andrew Morton, Al Viro, Stephen Rothwell, linux-mips,
	linux-kernel

On Fri, May 13, 2011 at 05:07:28PM -0700, Kevin Cernekee wrote:
> Date:   Fri, 13 May 2011 17:07:28 -0700
> From: Kevin Cernekee <cernekee@gmail.com>
> To: Andrew Morton <akpm@linux-foundation.org>, Al Viro
>  <viro@zeniv.linux.org.uk>, Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
> Subject: [PATCH] ipc: Add missing sys_ni entries for ipc/compat.c functions
> Content-Type: text/plain; charset=us-ascii
> 
> When building with:
> 
> CONFIG_64BIT=y
> CONFIG_MIPS32_COMPAT=y
> CONFIG_COMPAT=y
> CONFIG_MIPS32_O32=y
> CONFIG_MIPS32_N32=y
> CONFIG_SYSVIPC is not set
> (and implicitly: CONFIG_SYSVIPC_COMPAT is not set)
> 
> the final link fails with unresolved symbols for:
> 
> compat_sys_semctl, compat_sys_msgsnd, compat_sys_msgrcv,
> compat_sys_shmctl, compat_sys_msgctl, compat_sys_semtimedop
> 
> The fix is to add cond_syscall declarations for all syscalls in
> ipc/compat.c
> 
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>

Acked-by: Ralf Baechle <ralf@linux-mips.org>

Thanks, Kevin!

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-17 10:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-14  0:07 [PATCH] ipc: Add missing sys_ni entries for ipc/compat.c functions Kevin Cernekee
2011-05-17 10:01 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).