Re: [PATCH net-next v19 1/1] mctp pcc: Implement MCTP over PCC Transport

[Jeremy Kerr <jk@codeconstruct.com.au>]

Hi Adam,

[resend, un-HTMLed. Sorry for the noise!]

One bug in the code, and another couple of notes since we'll need a re-roll:

> +#define MCTP_PAYLOAD_LENGTH     256
> +#define MCTP_CMD_LENGTH         4
> +#define MCTP_PCC_VERSION        0x1 /* DSP0253 defines a single version: 1 */

Mismatched DSP reference above - DSP0253 is serial.

> +static netdev_tx_t mctp_pcc_tx(struct sk_buff *skb, struct net_device *ndev)
> +{
> +       struct mctp_pcc_ndev *mpnd = netdev_priv(ndev);
> +       struct mctp_pcc_hdr  *mctp_pcc_header;

Another double-space has crept in here.

> +       void __iomem *buffer;
> +       unsigned long flags;
> +       int len = skb->len;
> +       int rc;
> +
> +       dev_dstats_tx_add(ndev, len);
> +
> +       spin_lock_irqsave(&mpnd->lock, flags);
> +       rc = skb_cow_head(skb, sizeof(struct mctp_pcc_hdr));
> +       if (rc)
> +               return rc;

This will return with mpdn->lock still held.

And should this return the raw rc value? Or NETDEV_TX_OK?

Cheers,


Jeremy