From: rishabhb@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
Siddharth Gupta <sidgup@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] remoteproc: sysmon: Improve error messages
Date: Tue, 10 Nov 2020 17:04:34 -0800 [thread overview]
Message-ID: <cb2a980190c5fa542c11a3640441886c@codeaurora.org> (raw)
In-Reply-To: <20201105045051.1365780-5-bjorn.andersson@linaro.org>
On 2020-11-04 20:50, Bjorn Andersson wrote:
> Improve the style of a few of the error messages printed by the sysmon
> implementation and fix the copy-pasted shutdown error in the send-event
> function.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - New patch
>
> drivers/remoteproc/qcom_sysmon.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_sysmon.c
> b/drivers/remoteproc/qcom_sysmon.c
> index 1c42f00010d3..47683932512a 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -352,9 +352,9 @@ static bool ssctl_request_shutdown(struct
> qcom_sysmon *sysmon)
>
> ret = qmi_txn_wait(&txn, 5 * HZ);
> if (ret < 0) {
> - dev_err(sysmon->dev, "failed receiving QMI response\n");
> + dev_err(sysmon->dev, "timeout waiting for shutdown response\n");
> } else if (resp.resp.result) {
> - dev_err(sysmon->dev, "shutdown request failed\n");
> + dev_err(sysmon->dev, "shutdown request rejected\n");
> } else {
> dev_dbg(sysmon->dev, "shutdown request completed\n");
> acked = true;
> @@ -397,18 +397,18 @@ static void ssctl_send_event(struct qcom_sysmon
> *sysmon,
> SSCTL_SUBSYS_EVENT_REQ, 40,
> ssctl_subsys_event_req_ei, &req);
> if (ret < 0) {
> - dev_err(sysmon->dev, "failed to send shutdown request\n");
> + dev_err(sysmon->dev, "failed to send subsystem event\n");
> qmi_txn_cancel(&txn);
> return;
> }
>
> ret = qmi_txn_wait(&txn, 5 * HZ);
> if (ret < 0)
> - dev_err(sysmon->dev, "failed receiving QMI response\n");
> + dev_err(sysmon->dev, "timeout waiting for subsystem event
> response\n");
> else if (resp.resp.result)
> - dev_err(sysmon->dev, "ssr event send failed\n");
> + dev_err(sysmon->dev, "subsystem event rejected\n");
> else
> - dev_dbg(sysmon->dev, "ssr event send completed\n");
> + dev_dbg(sysmon->dev, "subsystem event accepted\n");
> }
>
> /**
Reviewed-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
next prev parent reply other threads:[~2020-11-11 1:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 4:50 [PATCH v2 0/4] remoteproc: Improvement for the Qualcomm sysmon Bjorn Andersson
2020-11-05 4:50 ` [PATCH v2 1/4] remoteproc: sysmon: Ensure remote notification ordering Bjorn Andersson
2020-11-11 0:57 ` rishabhb
2020-11-11 5:40 ` Bjorn Andersson
2020-11-05 4:50 ` [PATCH v2 2/4] remoteproc: sysmon: Expose the shutdown result Bjorn Andersson
2020-11-11 1:01 ` rishabhb
2020-11-05 4:50 ` [PATCH v2 3/4] remoteproc: qcom: q6v5: Query sysmon before graceful shutdown Bjorn Andersson
2020-11-11 1:03 ` rishabhb
2020-11-05 4:50 ` [PATCH v2 4/4] remoteproc: sysmon: Improve error messages Bjorn Andersson
2020-11-11 1:04 ` rishabhb [this message]
2020-11-12 18:00 ` [PATCH v2 0/4] remoteproc: Improvement for the Qualcomm sysmon Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2a980190c5fa542c11a3640441886c@codeaurora.org \
--to=rishabhb@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sibis@codeaurora.org \
--cc=sidgup@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox