From: Bean Huo <huobean@gmail.com>
To: Can Guo <cang@codeaurora.org>,
asutoshd@codeaurora.org, nguyenb@codeaurora.org,
hongwus@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Kiwoong Kim <kwmad.kim@samsung.com>,
Satya Tangirala <satyat@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] scsi: ufs: Introduce hba performance monitor sysfs nodes
Date: Wed, 12 May 2021 22:21:38 +0200 [thread overview]
Message-ID: <cb32c4e786ac73681b80b8af556543f08f076687.camel@gmail.com> (raw)
In-Reply-To: <1619058521-35307-2-git-send-email-cang@codeaurora.org>
On Wed, 2021-04-21 at 19:28 -0700, Can Guo wrote:
> +
>
> +static DEVICE_ATTR_RW(monitor_enable);
>
> +static DEVICE_ATTR_RW(monitor_chunk_size);
>
> +static DEVICE_ATTR_RO(read_total_sectors);
>
> +static DEVICE_ATTR_RO(read_total_busy);
>
> +static DEVICE_ATTR_RO(read_nr_requests);
>
> +static DEVICE_ATTR_RO(read_req_latency_avg);
>
> +static DEVICE_ATTR_RO(read_req_latency_max);
>
> +static DEVICE_ATTR_RO(read_req_latency_min);
>
> +static DEVICE_ATTR_RO(read_req_latency_sum);
>
> +static DEVICE_ATTR_RO(write_total_sectors);
>
> +static DEVICE_ATTR_RO(write_total_busy);
>
> +static DEVICE_ATTR_RO(write_nr_requests);
>
> +static DEVICE_ATTR_RO(write_req_latency_avg);
>
> +static DEVICE_ATTR_RO(write_req_latency_max);
>
> +static DEVICE_ATTR_RO(write_req_latency_min);
>
> +static DEVICE_ATTR_RO(write_req_latency_sum);
Can,
I like this series of patches, which can help me monitor UFS
performance online. I have a suggestion, how do you think that we add
this to ufs-debugfs. Then we don't need to poll each parameter one by
one, just one interface.
Bean
next prev parent reply other threads:[~2021-05-12 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1619058521-35307-1-git-send-email-cang@codeaurora.org>
2021-04-22 2:28 ` [PATCH v5 1/2] scsi: ufs: Introduce hba performance monitor sysfs nodes Can Guo
2021-05-12 20:21 ` Bean Huo [this message]
2021-05-13 1:15 ` Can Guo
2021-05-13 21:10 ` Bean Huo
2021-04-22 2:28 ` [PATCH v5 2/2] scsi: ufs: Add support for hba performance monitor Can Guo
2021-05-13 21:11 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb32c4e786ac73681b80b8af556543f08f076687.camel@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=satyat@google.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox