Re: [PATCH] KVM: Start populating /sys/hypervisor with KVM entries

Boris Ostrovsky
2018-10-09T16:22:03Z

On 10/9/18 6:41 AM, Christian Borntraeger wrote:
>
>
> On 10/09/2018 11:54 AM, Filippo Sironi wrote:
>> Start populating /sys/hypervisor with KVM entries when we're running on
>> KVM. This is to replicate functionality that's available when we're
>> running on Xen.
>>
>> Let's start with /sys/hypervisor/uuid, which users prefer over
>> /sys/devices/virtual/dmi/id/product_uuid as a way to recognize a virtual
>> machine, since it's also available when running on Xen HVM and on Xen PV
>> and, on top of that doesn't require root privileges by default.
>
> Can you make this an arch hook? On s390 it is possible to get the uuid with
> the stsi instruction.
> See
> https://git.kernel.org/pub/scm/virt/kvm/kvm.git/tree/arch/s390/kernel/sysinfo.c#n248
>
>
> We do use uuid_t, but we can certainly return a char*.

I would suggest having a top-level sys-hypervisor.c that will create
common files that all hypervisors should have (uuid, type, version, etc)
and then have hypervisor- and/or arch-specific hooks.

-boris