public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: All Linux <allinux@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.6.12-rc1, ./drivers/base/platform.c
Date: Mon, 21 Mar 2005 21:32:50 -0800	[thread overview]
Message-ID: <cb57165a050321213210961749@mail.gmail.com> (raw)

The latest prepatch, 2.6.12-rc1, introduced the following change.

--- a/drivers/base/platform.c   2005-03-17 17:35:04 -08:00
+++ b/drivers/base/platform.c   2005-03-17 17:35:04 -08:00
@@ -131,7 +131,7 @@
         pdev->dev.bus = &platform_bus_type;
 
         if (pdev->id != -1)
-                snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s%u",
pdev->name, pdev->id);
+                snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s.%u",
pdev->name, pdev->id);
         else
                 strlcpy(pdev->dev.bus_id, pdev->name, BUS_ID_SIZE);

It causes problem, as most platform files, for example,
arch/ppc/platforms/katana.c, still use the old name without ".". I do
not understand why bus_id "mpsc.0" is better than "mpsc0".
Please explain what is the benefit of introducing such a change,
before I can submit a patch for all those platform files to work with
this change.
Please CC me, as I am currently not in the list.

Thanks,

Lee

             reply	other threads:[~2005-03-22  5:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-22  5:32 All Linux [this message]
2005-03-22  6:04 ` [PATCH] 2.6.12-rc1, ./drivers/base/platform.c Dmitry Torokhov
2005-03-22 18:32 ` Brian Waite
2005-03-22 20:22   ` All Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb57165a050321213210961749@mail.gmail.com \
    --to=allinux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox