Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: tas2781: Add tas5832 support

Krzysztof Kozlowski
2026-03-02T08:58:30Z

On 02/03/2026 09:24, Xu, Baojun wrote:
>>>>
>>>>> MODULE_DEVICE_TABLE(i2c, tasdevice_id);
>>>>> @@ -144,6 +145,7 @@ static const struct of_device_id tasdevice_of_match[] = {
>>>>> { .compatible = "ti,tas5827" },
>>>>> { .compatible = "ti,tas5828" },
>>>>> { .compatible = "ti,tas5830" },
>>>>> + { .compatible = "ti,tas5832" },
>>>>
>>>> So it is fully compatible with tas5830 and most of the changes here are
>>>> not needed?
>>>
>>> Yes, it's fully compatible with tas5827/28/30.
>>
>> Then above hunk and many others are not needed.
>
> Hi, because those chips have different on the voltage, so the parameters
> is different, have to use different firmware binary, so we must identify
> every chip in the driver.

That would explain other ID tables (and should be briefly mentioned in
the commit msg), but not this one, because here you do not customize the
binary at all.

Best regards,
Krzysztof