Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: tas2781: Add tas5832 support

Xu, Baojun
2026-03-02T09:22:08Z

>
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 02 March 2026 16:58
> To: Xu, Baojun
> Cc: broonie@kernel.org; tiwai@suse.de; andriy.shevchenko@linux.intel.com; 13916275206@139.com; Ding, Shenghao; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; lgirdwood@gmail.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org; Yi, Ken; Lo, Henry; Chen, Robin; Wang, Will; jim.shil@goertek.com; toastcheng@google.com; chinkaiting@google.com
> Subject: Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: tas2781: Add tas5832 support
>
> On 02/03/2026 09:24, Xu, Baojun wrote:
> >>>>
> >>>>> MODULE_DEVICE_TABLE(i2c, tasdevice_id);
> >>>>> @@ -144,6 +145,7 @@ static const struct of_device_id tasdevice_of_match[] = {
> >>>>> { .compatible = "ti,tas5827" },
> >>>>> { .compatible = "ti,tas5828" },
> >>>>> { .compatible = "ti,tas5830" },
> >>>>> + { .compatible = "ti,tas5832" },
> >>>>
> >>>> So it is fully compatible with tas5830 and most of the changes here are
> >>>> not needed?
> >>>
> >>> Yes, it's fully compatible with tas5827/28/30.
> >>
> >> Then above hunk and many others are not needed.
> >
> > Hi, because those chips have different on the voltage, so the parameters
> > is different, have to use different firmware binary, so we must identify
> > every chip in the driver.
>
> That would explain other ID tables (and should be briefly mentioned in
> the commit msg), but not this one, because here you do not customize the
> binary at all.
>

Hi, we save the chip_id in the dev_name:
strscpy(tas_priv->dev_name, tasdevice_id[tas_priv->chip_id].name,
sizeof(tas_priv->dev_name));

And get firmware binary from this dev_name:
scnprintf(tas_priv->rca_binaryname, 64, "%sRCA%d.bin",
tas_priv->dev_name, tas_priv->ndev);

> Best regards,
> Krzysztof
>
>
>
Best Regards
Jim