From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458142BD00C for ; Thu, 7 May 2026 15:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168153; cv=none; b=p68M7UrU37gEXctRRjje4Acq2LnPHdvqcddyPdcu2Eq/jcbF1bC5wNafWLCUqTL33mQplifbYywQ9Wpma4hi8MKnlcbRkrNLdMX4Wz9+bBeh2sX17rkFHjguSPuw5881ZpD2s5xFEsvXI0oFCbJ9kUuOpGJeEL/JW7AxhMhNUsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168153; c=relaxed/simple; bh=U699BVNP9gGhnxD0EWJLGU9egJmal2n2/3dbQNE5Igg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=fZdoMhw+zQ0dIefzxNam5DVUfYKT0GfNE7HOB2ncamFDS1cLLawSOaBNB/eKBF35xgQSsYEvKY8Lc14eghJRE0UyZaOdMLBOsFde9DfYFpOGvuZOpZ1jDtrqm2mdJgirYGozFWX5VYMl4GMiEeyl1Y9vcmyGep3XaMF/VRMid8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ODUW4aqY; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ODUW4aqY" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-444826c16ffso946512f8f.1 for ; Thu, 07 May 2026 08:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168151; x=1778772951; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=4z5DD24RfTrdP45OX3nmt+xGieHCkU7CBzs7THghyBo=; b=ODUW4aqYdXpZXivv4ar2Yn8NMm3Mp13pp4Lh/FG+ehn0ZhpOBaNWHoTYY+YrvJp/2P t9oZmggk6kNAxsob3KGv6WiR5X9jdRg+i776aOUR5pCimYONP27pc/7n8rXBTNwQp0cZ tZmzXPjSOhcKl6oUmN60DnJ70plYEUPE79ytGQsulaR2zrIATAc3+Jdfile3/qnWsjJk EWcdliUDXUTUpEGaBeRIlvrg7Oc7Rtva1xWJuNcEioXRTxl3jyVtSHUrXWshLW5YAu59 aFGm2mYjcxjEbJjOW9F0mAAzc2Ih4+UF+2wVsxJSdLAjDchBTb+/Lb1tUrjeUvbFYcML mx1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168151; x=1778772951; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4z5DD24RfTrdP45OX3nmt+xGieHCkU7CBzs7THghyBo=; b=RyjW2xjBwshxanfr/Uqt31QU0ZybFmRk/sIn4ArrVO/Phe8oiu8w9vWOsglTfVkEM5 E2hQNGUg8Af1fJ72n7Zfa639QqOB7Chg1zwbI0bWC9/DRv5W8yb3NehQPERPtasLNP2m YDB9ymmOfw9KPM1+76XYDK0ySdpQC+E70jv9jHzrQ9KJAmCTo4oqW5u90vCmf/f/Gcj7 5j1Zztdl7DVOK/icIkA56gbk/ioNZKuUOjdPyqMkL6CT488yKlv6Z4c5tb/gv28UzUFH YvIStks4hmwBhPaRZh2rzz+fgRK2z/qoXSe+FCx9622HqnA4MJ8qTiy9L7j7juZEhCfp Ncug== X-Forwarded-Encrypted: i=1; AFNElJ++nKDI7vTanlyku3/fPykpcifT6ZrmrIhZngzRLgA5Oj/fhFzvHiqOsKR6917OwDt1Vetop18lJNX7+gY=@vger.kernel.org X-Gm-Message-State: AOJu0YyrfhUhTJXYYiGWiAdx/cULCx+3JVeaYbZaC8hVgT+9Cd1YTeM1 wM1BJ6oydgQuAACEAh/6OPjGAnmfH1CeZ9wpwsXoQ7DpKHGMT0/ODcFJ7nxDhHdbDso= X-Gm-Gg: AeBDieu9vaIfPK/eDtqj4J54IZlIrogxV9RENqweLG17Lsp63zqLHpsiyOIm404DCTW owdMq5kIvHCt9XJUPGkqWTrXc9ay9mNswhDWRx7us798adBmZJ8YKMzTQlmuriD4c8YMxeusTik 6CVAgKKocSjvOkwAzt9Kv4Sut8XikaRIPvGSX4mgArN+ZJtmm3JxNRhk4eRnI0Mw4KI3VYqyqDn Iql71A1JjYuDNGk9QKeXtAZ5biSVaQAq00Z1igHRtvol2dgUOdYesX8vfbyvFwcVOk14t0inzEn 0Js16aWoBgpzx817Km/l/Xu58mWEFCRn6B/Ffw/etTJDiD1zhsun4CWNuUe1iGMh74Lrxwtyldn tk2WmtEYO3u8FfIV0jDuNKfCfWITfIEkQ/u/LI5NBOJlRVg7lEz9bEbTqrEogjOnHVKYe1+Sqo4 iMGP+puXq8Py5s4nPZLnFwa7NST7lu5q5ei1Kq5hZU9LPZQlAijYLvUmn0qdKBrZsKrWA4/bZ8D +uEM4SFG4l2SaX2O2U2vHEsNn1k X-Received: by 2002:a05:600d:10:b0:488:e7e4:8425 with SMTP id 5b1f17b1804b1-48e51f4ea40mr114855745e9.23.1778168150443; Thu, 07 May 2026 08:35:50 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e53142043sm43689315e9.27.2026.05.07.08.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:35:49 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 17:35:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 05/10] drm/panel/ilitek-ili9806e: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-5-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-5-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > index be2cf14401553..53e25d1086db8 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c > @@ -78,9 +78,11 @@ int ili9806e_probe(struct device *dev, void *transport, > bool set_prepare_prev_first = false; > int ret; > > - ctx = devm_kzalloc(dev, sizeof(struct ili9806e), GFP_KERNEL); > - if (!ctx) > - return -ENOMEM; > + ctx = devm_drm_panel_alloc(dev, __typeof(*ctx), panel, > + funcs, connector_type); > + > + if (IS_ERR(ctx)) > + return PTR_ERR(ctx); > > dev_set_drvdata(dev, ctx); > ctx->transport = transport; > @@ -103,8 +105,6 @@ int ili9806e_probe(struct device *dev, void *transport, > return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), > "Failed to get reset-gpios\n"); > > - drm_panel_init(&ctx->panel, dev, funcs, connector_type); > - > ret = drm_panel_of_backlight(&ctx->panel); > if (ret) > return dev_err_probe(dev, ret, "Failed to get backlight\n"); > Reviewed-by: Neil Armstrong Thanks, Neil