From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E10381D432D for ; Tue, 13 Jan 2026 18:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768329536; cv=none; b=WXxm+CfIGFUt/lIYdvvp9F7Ks6EGN+aFQOghUPzY1I+jMHMryHfkKSLdaz5QAdCqAWtMMWzFrOfLHoSLOUBIFr8DqPjK+/fi5/SPuEZqxRh5TsBXDCydhZNbKjhwPzbkcBAuEQ46V91EB0tlPZ2TMhcgJNgLJ1UjwLLv8/ky+bo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768329536; c=relaxed/simple; bh=T3XklyHmi0zL6Hq6XVLpoC/iYJ/hpCdZU4WmsKgj6ws=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ngYnvQhrCjLI0afWPwYKuw1WHr1rMO5BES2jtJIeSoqdSFU7Z47VLbtBmtATQ+7sOe/9ZXPYhfKnxrvfgPMRzbkkWKBOlI5g8In8u66qy7xsfyxPA9tE1bp3gce/eWpEkuqCnaxPd1l0qSBmphc/ZeCRKXwgSikbvoqIMdpYg7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P41Uj5xK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P41Uj5xK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768329533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WYLQ9pb7mDbdjvW5qFhZLjZCZDcUydviJ4/haXg7EfY=; b=P41Uj5xK9J1hZGJH+55uFMyIe0zBZk8JSEJknVtuL1Pht4gdXwusN8tGKs3VG32TwRV5va ilcOvvkTgRcQ3W6whUrAkUi1nE2e0N1s7dw8JUQhxS/DuH1fV8QHZjYrAudeYoTTFU74yB 9zNJ3zUqoNsvBwGwFaJsvWkhXlbNS8w= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-M2IR8reHOdyts1QFqy7SpA-1; Tue, 13 Jan 2026 13:38:50 -0500 X-MC-Unique: M2IR8reHOdyts1QFqy7SpA-1 X-Mimecast-MFC-AGG-ID: M2IR8reHOdyts1QFqy7SpA_1768329528 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 556541800610; Tue, 13 Jan 2026 18:38:48 +0000 (UTC) Received: from [10.44.32.45] (unknown [10.44.32.45]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AEF1B30001A2; Tue, 13 Jan 2026 18:38:44 +0000 (UTC) Message-ID: Date: Tue, 13 Jan 2026 19:38:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 2/3] dpll: add dpll_device op to set working mode To: Vadim Fedorenko , netdev@vger.kernel.org Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Arkadiusz Kubalewski , Jiri Pirko , Prathosh Satish , Petr Oros , linux-kernel@vger.kernel.org, Michal Schmidt References: <20260113121636.71565-1-ivecera@redhat.com> <20260113121636.71565-3-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 1/13/26 6:47 PM, Vadim Fedorenko wrote: > On 13/01/2026 12:16, Ivan Vecera wrote: >> Currently, userspace can retrieve the DPLL working mode but cannot >> configure it. This prevents changing the device operation, such as >> switching from manual to automatic mode and vice versa. >> >> Add a new callback .mode_set() to struct dpll_device_ops. Extend >> the netlink policy and device-set command handling to process >> the DPLL_A_MODE attribute.  Update the netlink YAML specification >> to include the mode attribute in the device-set operation. >> >> Signed-off-by: Ivan Vecera >> --- >> v2: >> * fixed bitmap size in dpll_mode_set() > > [...] > >> +static int >> +dpll_mode_set(struct dpll_device *dpll, struct nlattr *a, >> +          struct netlink_ext_ack *extack) >> +{ >> +    const struct dpll_device_ops *ops = dpll_device_ops(dpll); >> +    enum dpll_mode mode = nla_get_u32(a), old_mode; >> +    DECLARE_BITMAP(modes, DPLL_MODE_MAX + 1) = { 0 }; > > this one breaks reverse xmas tree order. oops, my bad :-( > with this fixed: > Reviewed-by: Vadim Fedorenko will fix... thanks for pointing this out. Ivan