The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Krishnamoorthi M <krishnamoorthi.m@amd.com>
Cc: mario.limonciello@amd.com, Hans de Goede <hansg@kernel.org>,
	 Shyam-sundar.S-k@amd.com, perry.yuan@amd.com,
	 platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86/amd: hfi: Support for ranking table versions
Date: Mon, 11 May 2026 17:20:37 +0300 (EEST)	[thread overview]
Message-ID: <cb917e96-db3e-baf8-91a0-8bba4ba97208@linux.intel.com> (raw)
In-Reply-To: <20260507190926.1211726-1-krishnamoorthi.m@amd.com>

On Fri, 8 May 2026, Krishnamoorthi M wrote:

> Add changes to support new ranking table version. Version 2 of the
> heterogeneous ranking table provides static CPU rankings. Version 3 adds
> dynamic ranking table support on newer AMD platforms. These changes ensure
> that platforms still reporting version 2 continue to function with the
> existing static ranking path, avoiding regressions on older hardware
> that does not supply a dynamic ranking table.
> 
> Signed-off-by: Krishnamoorthi M <krishnamoorthi.m@amd.com>

Hi,

Don't we want to have Cc: stable@vger.kernel.org # 6.17 for this?

(I can add it if that's the case, no need to resubmit because of it.)

-- 
 i.

> ---
>  drivers/platform/x86/amd/hfi/hfi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
> index 83863a5e0fbc..e0ebcb0c4acd 100644
> --- a/drivers/platform/x86/amd/hfi/hfi.c
> +++ b/drivers/platform/x86/amd/hfi/hfi.c
> @@ -33,7 +33,8 @@
>  
>  #define AMD_HFI_DRIVER		"amd_hfi"
>  #define AMD_HFI_MAILBOX_COUNT		1
> -#define AMD_HETERO_RANKING_TABLE_VER	2
> +#define AMD_HETERO_RANKING_TABLE_MIN_VER	2
> +#define AMD_HETERO_RANKING_TABLE_MAX_VER	3
>  
>  #define AMD_HETERO_CPUID_27	0x80000027
>  
> @@ -158,7 +159,8 @@ static int amd_hfi_fill_metadata(struct amd_hfi_data *amd_hfi_data)
>  		dev_err(amd_hfi_data->dev, "invalid signature in shared memory\n");
>  		return -EINVAL;
>  	}
> -	if (amd_hfi_data->shmem->version_number != AMD_HETERO_RANKING_TABLE_VER) {
> +	if (amd_hfi_data->shmem->version_number < AMD_HETERO_RANKING_TABLE_MIN_VER ||
> +	    amd_hfi_data->shmem->version_number > AMD_HETERO_RANKING_TABLE_MAX_VER) {
>  		dev_err(amd_hfi_data->dev, "invalid version %d\n",
>  			amd_hfi_data->shmem->version_number);
>  		return -EINVAL;
> 

      parent reply	other threads:[~2026-05-11 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 19:09 [PATCH] platform/x86/amd: hfi: Support for ranking table versions Krishnamoorthi M
2026-05-07 19:25 ` Mario Limonciello
2026-05-08 10:11 ` Shyam Sundar S K
2026-05-11 14:20 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb917e96-db3e-baf8-91a0-8bba4ba97208@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=hansg@kernel.org \
    --cc=krishnamoorthi.m@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perry.yuan@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox