From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754568AbdJSS42 (ORCPT ); Thu, 19 Oct 2017 14:56:28 -0400 Received: from mout.web.de ([212.227.17.11]:58754 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbdJSS40 (ORCPT ); Thu, 19 Oct 2017 14:56:26 -0400 Subject: Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage() To: Joe Perches , kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org Cc: Jessica Yu , Rusty Russell , Wolfram Sang , LKML References: <20171019110824.wqkep7bpcx3dcw5w@redbean> <43c71898-82c3-215a-3176-e1a6d56ef10a@users.sourceforge.net> <1508412567.6806.36.camel@perches.com> <1dee801c-37b5-4d72-b33f-ebdc135b4f25@users.sourceforge.net> <1508413536.6806.38.camel@perches.com> From: SF Markus Elfring Message-ID: Date: Thu, 19 Oct 2017 20:56:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508413536.6806.38.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:9W1Y4MoxIacJS16HpZ26lJPnkd7KX4GOEGTJG03XTXTleOGr8SD 1aZqEub2N1nw7JVhwomt4ttZt0auOBItOa9FnaLCEQrGhyjNcbOSwy846TzXaAU1b1h6u43 8awhiSjo1ClDH2zYmAYnu3SikFZU2udqlV3Bv520yvxiG5QvT0y8J2lswV2dOvfAvSinDvX oY/g/zNMXisIKtfxNYsDA== X-UI-Out-Filterresults: notjunk:1;V01:K0:XmG4GfWek3g=:htGitKyfWdSl25kiF6X41X oeCi6uNfSoGUzHL/psvs2p2V0RP7gx9kMS2sHU2JgsC/sMvq9o/TwuCUbZpKWO3ndiZHf0cdN yC+UxJmsbz5YI0x0Bt2g3+yB7b5Kfz4AyPzUplE0yXkDJ7BfwVIvc/BynBwn/OIhIQM5pVtM8 lfAb6HGMJWbcARi5SU8KIDmXfddovgU+zCRcargY0AqXEvFx41o/6nIIK2nseNERrLo3nTxJJ E9b0iwUoONWVJSW52e24+w3c/X1xQWRp3g7C/eg2hp6kr+7+BtjDgwsuixjaDJaEo1KIGfKVi X+qU8sXXJ2mJD/fS9JIJJG4cKjLe4dsQNzvbc2CAzVPy0FXP5PckGGnvzgj/sPxfqMUm87bTO xH1BU2UicbpbWj/BzylDLXfDOVGLMawSHPNpy++3CD3Yn5RagwYcgJZY4BoiqbVAZ7eI3q8aj kfMUXX34u0LO34GzUa7FMl+pJNSwGtai0RoWluP1i9VoacCpY6B6IOtoF/u5rDg9O74r+1ujJ ZNUceIvK0b9dd7IBCpZWmJfyofe5YcTy4mkVCtb+41B6CdoUKvYmoYM1YupxckEsM7Mk0miNL ExDy0/kXf6bDx0+rQSxN2G5Qld40OThdCxnidSEhKE+1Hmt4hiDZYAHrpRuzKOmsWvJy3Gp6J q7GhKNwkmACfjxq3I6d0vON54/Ht1+hTXH6CfrVCtdLeUHGCCdOWhP4Oo+yR7JlhnEAQ3/Fne LiESDpDfSFggS6mBL3B7AV6EW5SUq5O0FK+QEEQA6MMNyAZtMMLjokLxfouhi1EAh9WfVkMMV V6ttWCdkk4SeD00ak69cOa6EsAW+k3j/xDJU2YcNwDUq5QYPow= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> Something like: >>> >>> "because there is a dump_stack() done on allocation failures >>> without __GFP_JNOWARN" >> >> How do you think about to convert such a description into a special format >> for further reference documentation? > > I think it's a bad idea if it's a "special" format. Will it be nice to represent corresponding details as a better “restructured text”? > Always write _why_ some code is being changed. > > People could read the commit descriptions and would not need > to take extra time to lookup external references. I would appreciate if I could copy a widely accepted explanation. > Maybe add something like > "see (commit or )" for additional details" Are there any related extensions possible besides other background information? Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Regards, Markus