[PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[Shivank Garg]

Remove the redundant kvm_gmem_getattr() implementation that simply calls
generic_fillattr() without any special handling. The VFS layer
(vfs_getattr_nosec()) will call generic_fillattr() by default when no
custom getattr operation is provided in the inode_operations structure.

This is a cleanup with no functional change.

Signed-off-by: Shivank Garg <shivankg@amd.com>
---
 virt/kvm/guest_memfd.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c
index b2aa6bf24d3a..7d85cc33c0bb 100644
--- a/virt/kvm/guest_memfd.c
+++ b/virt/kvm/guest_memfd.c
@@ -382,23 +382,12 @@ static const struct address_space_operations kvm_gmem_aops = {
 #endif
 };
 
-static int kvm_gmem_getattr(struct mnt_idmap *idmap, const struct path *path,
-			    struct kstat *stat, u32 request_mask,
-			    unsigned int query_flags)
-{
-	struct inode *inode = path->dentry->d_inode;
-
-	generic_fillattr(idmap, request_mask, inode, stat);
-	return 0;
-}
-
 static int kvm_gmem_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
 			    struct iattr *attr)
 {
 	return -EINVAL;
 }
 static const struct inode_operations kvm_gmem_iops = {
-	.getattr	= kvm_gmem_getattr,
 	.setattr	= kvm_gmem_setattr,
 };
 
-- 
2.34.1

Re: [PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[Ackerley Tng]

Reviewed-By: Ackerley Tng <ackerleytng@google.com>

Re: [PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[Sean Christopherson]

On Mon, Jun 02, 2025, Ackerley Tng wrote:
> 
> Reviewed-By: Ackerley Tng <ackerleytng@google.com>

Ackerley,

FYI, your mail doesn't appear to have made it to the lists, e.g. isn't available
on lore.  I don't see anything obviously wrong (though that means almost nothing).
Hopefully it's just a one-off glitch?

Re: [PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[Shivank Garg]

On 6/25/2025 1:27 AM, Sean Christopherson wrote:
> On Mon, Jun 02, 2025, Ackerley Tng wrote:
>>
>> Reviewed-By: Ackerley Tng <ackerleytng@google.com>
> 
> Ackerley,
> 
> FYI, your mail doesn't appear to have made it to the lists, e.g. isn't available
> on lore.  I don't see anything obviously wrong (though that means almost nothing).
> Hopefully it's just a one-off glitch?

Hi Sean,

I can find it on lore:
https://lore.kernel.org/all/diqzv7pdq5lc.fsf@ackerleytng-ctop.c.googlers.com

Thanks,
Shivank

Re: [PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[Gupta, Pankaj]

On 6/2/2025 7:23 PM, Shivank Garg wrote:
> Remove the redundant kvm_gmem_getattr() implementation that simply calls
> generic_fillattr() without any special handling. The VFS layer
> (vfs_getattr_nosec()) will call generic_fillattr() by default when no
> custom getattr operation is provided in the inode_operations structure.
> 
> This is a cleanup with no functional change.
> 
> Signed-off-by: Shivank Garg <shivankg@amd.com>

Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>

> ---
>   virt/kvm/guest_memfd.c | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c
> index b2aa6bf24d3a..7d85cc33c0bb 100644
> --- a/virt/kvm/guest_memfd.c
> +++ b/virt/kvm/guest_memfd.c
> @@ -382,23 +382,12 @@ static const struct address_space_operations kvm_gmem_aops = {
>   #endif
>   };
>   
> -static int kvm_gmem_getattr(struct mnt_idmap *idmap, const struct path *path,
> -			    struct kstat *stat, u32 request_mask,
> -			    unsigned int query_flags)
> -{
> -	struct inode *inode = path->dentry->d_inode;
> -
> -	generic_fillattr(idmap, request_mask, inode, stat);
> -	return 0;
> -}
> -
>   static int kvm_gmem_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
>   			    struct iattr *attr)
>   {
>   	return -EINVAL;
>   }
>   static const struct inode_operations kvm_gmem_iops = {
> -	.getattr	= kvm_gmem_getattr,
>   	.setattr	= kvm_gmem_setattr,
>   };
>   

Re: [PATCH] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation

[Sean Christopherson]

On Mon, 02 Jun 2025 17:23:18 +0000, Shivank Garg wrote:
> Remove the redundant kvm_gmem_getattr() implementation that simply calls
> generic_fillattr() without any special handling. The VFS layer
> (vfs_getattr_nosec()) will call generic_fillattr() by default when no
> custom getattr operation is provided in the inode_operations structure.
> 
> This is a cleanup with no functional change.
> 
> [...]

Applied to kvm-x86 generic, thanks!

[1/1] KVM: guest_memfd: Remove redundant kvm_gmem_getattr implementation
      https://github.com/kvm-x86/linux/commit/87d4fbf4a387

--
https://github.com/kvm-x86/kvm-unit-tests/tree/next