From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A2E629AB00 for ; Fri, 6 Feb 2026 06:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770358438; cv=none; b=CR784w4C53je0uo0ZYWU//KbHzW99SosUhuSTPUjyLwPVJOnXH8jFYfJnCO8rmnFdNZOdx9rhcnbdni1SDf4HK0Qgn2Tmz5KcGBdZDHYK/uSZRQsyAwQmljnCAe0wFCeBvyz4X3deUbWInDfpuTH0UfhZZFp2AVl1XZOjhHRAno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770358438; c=relaxed/simple; bh=YQZcsbIkMDeeqlGN/DppM+neQzqtF6hjMnlLeBiLaI0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pJ4fxKqj1xch9zSDjfOoijPBeH9DeesBoMb+n8UQh1W0zt/9n4i9qvw8pgUr2OB+oX9aMFQbMnG/2rOB+n+u/U8507XKz+SkBqZark9KlivUIo9g8muX+mn1JAQsYrwpV6rOT+VxE8EyLZgJVqoPSA2SCwws2XhcdoEZJSYt+50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dC/jcKtH; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dC/jcKtH" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770358426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f4dJ2KwSmRisMZ/4xd6+bG4Q7esCOyMfca25PcWP+cI=; b=dC/jcKtHfNMquOXuvapGfNJT6W1nn2qqoibSINRKajvM0TW82x5ygrDaisDNQCL1sOpKRb 2Iek+94Q6nTAH410kB+pam/JhF6U0VU9rOG6KsRRZh90nRYs6AGKXl7HpvTUhbSIzEJOTi PqcAcaDs4RZo9IVv8sPt/yUhOLquyhE= Date: Fri, 6 Feb 2026 14:13:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v4 24/31] mm: memcontrol: prepare for reparenting LRU pages for lruvec lock To: kernel test robot , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com Cc: oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng References: <202602052203.U8hxsh2N-lkp@intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: <202602052203.U8hxsh2N-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2/5/26 11:02 PM, kernel test robot wrote: > Hi Qi, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on next-20260204] > [cannot apply to akpm-mm/mm-everything brauner-vfs/vfs.all trace/for-next tj-cgroup/for-next linus/master dennis-percpu/for-next v6.19-rc8 v6.19-rc7 v6.19-rc6 v6.19-rc8] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Qi-Zheng/mm-memcontrol-remove-dead-code-of-checking-parent-memory-cgroup/20260205-170812 > base: next-20260204 > patch link: https://lore.kernel.org/r/e27edb311dda624751cb41860237f290de8c16ae.1770279888.git.zhengqi.arch%40bytedance.com > patch subject: [PATCH v4 24/31] mm: memcontrol: prepare for reparenting LRU pages for lruvec lock > config: nios2-allnoconfig (https://download.01.org/0day-ci/archive/20260205/202602052203.U8hxsh2N-lkp@intel.com/config) > compiler: nios2-linux-gcc (GCC) 11.5.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260205/202602052203.U8hxsh2N-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202602052203.U8hxsh2N-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > nios2-linux-ld: mm/swap.o: in function `__page_cache_release.part.0': > swap.c:(.text+0x4c): undefined reference to `lruvec_unlock_irqrestore' >>> swap.c:(.text+0x4c): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irqrestore' > nios2-linux-ld: mm/swap.o: in function `__folio_put': > swap.c:(.text+0x2ac): undefined reference to `lruvec_unlock_irqrestore' > swap.c:(.text+0x2ac): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irqrestore' > nios2-linux-ld: mm/swap.o: in function `folios_put_refs': > swap.c:(.text+0x384): undefined reference to `lruvec_unlock_irqrestore' > swap.c:(.text+0x384): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irqrestore' > nios2-linux-ld: mm/swap.o: in function `folio_batch_move_lru': > swap.c:(.text+0x4ac): undefined reference to `lruvec_unlock_irqrestore' > swap.c:(.text+0x4ac): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irqrestore' >>> nios2-linux-ld: swap.c:(.text+0x50c): undefined reference to `lruvec_unlock_irqrestore' > swap.c:(.text+0x50c): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irqrestore' > nios2-linux-ld: mm/swap.o: in function `folio_activate': > swap.c:(.text+0x21d8): undefined reference to `lruvec_unlock_irq' >>> swap.c:(.text+0x21d8): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irq' > nios2-linux-ld: mm/vmscan.o: in function `move_folios_to_lru': > vmscan.c:(.text+0xa4c): undefined reference to `lruvec_unlock_irq' >>> vmscan.c:(.text+0xa4c): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irq' >>> nios2-linux-ld: vmscan.c:(.text+0xaa4): undefined reference to `lruvec_unlock_irq' > vmscan.c:(.text+0xaa4): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irq' > nios2-linux-ld: vmscan.c:(.text+0xcac): undefined reference to `lruvec_unlock_irq' > vmscan.c:(.text+0xcac): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irq' > nios2-linux-ld: vmscan.c:(.text+0xd8c): undefined reference to `lruvec_unlock_irq' > vmscan.c:(.text+0xd8c): relocation truncated to fit: R_NIOS2_CALL26 against `lruvec_unlock_irq' > nios2-linux-ld: mm/vmscan.o: in function `shrink_active_list': > vmscan.c:(.text+0x11e0): undefined reference to `lruvec_lock_irq' > vmscan.c:(.text+0x11e0): additional relocation overflows omitted from the output > nios2-linux-ld: vmscan.c:(.text+0x12a0): undefined reference to `lruvec_unlock_irq' >>> nios2-linux-ld: vmscan.c:(.text+0x144c): undefined reference to `lruvec_lock_irq' > nios2-linux-ld: mm/vmscan.o: in function `check_move_unevictable_folios': > vmscan.c:(.text+0x15d4): undefined reference to `lruvec_unlock_irq' > nios2-linux-ld: vmscan.c:(.text+0x1958): undefined reference to `lruvec_unlock_irq' > nios2-linux-ld: mm/vmscan.o: in function `shrink_inactive_list': > vmscan.c:(.text+0x2f8c): undefined reference to `lruvec_lock_irq' > nios2-linux-ld: vmscan.c:(.text+0x307c): undefined reference to `lruvec_unlock_irq' > nios2-linux-ld: vmscan.c:(.text+0x31dc): undefined reference to `lruvec_lock_irq' > nios2-linux-ld: mm/vmscan.o: in function `folio_isolate_lru': > vmscan.c:(.text+0x48a4): undefined reference to `lruvec_unlock_irq' > nios2-linux-ld: mm/mlock.o: in function `__munlock_folio': > mlock.c:(.text+0x968): undefined reference to `lruvec_unlock_irq' > nios2-linux-ld: mm/mlock.o: in function `__mlock_folio': > mlock.c:(.text+0xe5c): undefined reference to `lruvec_unlock_irq' > nios2-linux-ld: mm/mlock.o: in function `mlock_folio_batch.constprop.0': > mlock.c:(.text+0x158c): undefined reference to `lruvec_unlock_irq' >>> nios2-linux-ld: mlock.c:(.text+0x1808): undefined reference to `lruvec_unlock_irq' Ouch, I move lruvec_lock_irq() and its firends to memcontrol.c to fix the compilation errors related to __acquires/__releases, but I forgot that memcontrol.c will only be compiled under CONFIG_MEMCG. Hi Shakeel, for simplicity, perhaps keeping lruvec_lock_irq() and its firends in memcontrol.h and drop __acquires/__releases would be a better option? Thanks, Qi >