From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA1B2E62B for ; Fri, 13 Dec 2024 18:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734113484; cv=none; b=py+IjaQeqzrnhhnR51ivQhApWMQgqRdolt2wFKiiilgAk7x1x4XIQU2ArvCLHXm+Tg4bznGO1lMocX0uB3pauHiUGXhHZReseZdeRHNeaBPTe1FyaqgzYxWYwZZF63NxlOV0qJqmmDY9hI+nIzVJ29ALnrfGjmXwafwYNgqgMkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734113484; c=relaxed/simple; bh=Zazdiqf3BoDx7pdYBQqW25qAyLtfY+qbL0ujaK4XYEs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=YX8RPeIM6StHcAAbxr+/qdspbqFL8UO1Q3hXowgqOF7lBNtziGdJrlV882bMgp2nNnBVE6c+OiSdYa/OPQKrS9sR8SMKzONDbNW9E1QOhVxwUixEa8gKLo72Wt3uuWdId8TCIdXHG+1evhW0iOvBA+TBIp2iqcFvy7LOXN2YkEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=SlTM7vNZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="SlTM7vNZ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BD9pb1P019094; Fri, 13 Dec 2024 18:11:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3vNEMKXncV3si7ZbhyB8SSwRVuWZ8Rf/Zsvrpshae8c=; b=SlTM7vNZypBShu90 t/kuGKpao5NfZF3Z1lz23Y/cDML9K0FOjfny0i2xxr95akOCpg7LueIxMaLuVNu0 O8Mov1X3skOI6Mth96Ia7iHGdb8LMtS9JUywfHMVSAE/0w/gsn26jjnqnVT+RAPQ Ge3GaaVxPbL2ArTCYUoNeJEVNiEbH5eaDhR9dRp5bSdacfnA6gtO0RhCQVnu4bM1 6bHSMwZmGt22KdHb6FGfEBj18wHaQbIU5tgvN5ws+c+DbkG3GU5Mj/pFGXRkxP3M N/t/pmU/AWE2k8B+hoMqXGsmqnUgZ4kk4obZX/yKQT5OC46QUNDHqkhalfqkhBgP M7wOdg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43gjnb1axe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Dec 2024 18:11:14 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BDIB1k8015982 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Dec 2024 18:11:01 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 13 Dec 2024 10:11:00 -0800 Message-ID: Date: Fri, 13 Dec 2024 11:11:00 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers Content-Language: en-US To: Lizhi Hou , Arnd Bergmann , Min Ma , Oded Gabbay CC: Arnd Bergmann , Narendra Gutta , , References: <20241213090259.68492-1-arnd@kernel.org> <828570ae-1ff6-4bef-4bb8-51da9237e63e@quicinc.com> <6d4267db-922d-8c01-f76a-6b796422c24d@quicinc.com> From: Jeffrey Hugo In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: JwwyZN5NVlYlWnI9SCLbGeMutYpKhZis X-Proofpoint-GUID: JwwyZN5NVlYlWnI9SCLbGeMutYpKhZis X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412130129 On 12/13/2024 10:57 AM, Lizhi Hou wrote: > > On 12/13/24 09:49, Jeffrey Hugo wrote: >> On 12/13/2024 10:41 AM, Lizhi Hou wrote: >>> >>> On 12/13/24 09:07, Jeffrey Hugo wrote: >>>> On 12/13/2024 2:02 AM, Arnd Bergmann wrote: >>>>> From: Arnd Bergmann >>>>> >>>>> The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause >>>>> a build >>>>> warning when CONFIG_PM is disabled: >>>>> >>>>> drivers/accel/amdxdna/amdxdna_pci_drv.c:343:12: error: >>>>> 'amdxdna_pmops_resume' defined but not used [-Werror=unused-function] >>>>>    343 | static int amdxdna_pmops_resume(struct device *dev) >>>>>        |            ^~~~~~~~~~~~~~~~~~~~ >>>>> drivers/accel/amdxdna/amdxdna_pci_drv.c:328:12: error: >>>>> 'amdxdna_pmops_suspend' defined but not used [-Werror=unused-function] >>>>>    328 | static int amdxdna_pmops_suspend(struct device *dev) >>>>>        |            ^~~~~~~~~~~~~~~~~~~~~ >>>>> >>>>> Change these to the modern replacements. >>>>> >>>>> Signed-off-by: Arnd Bergmann >>>> >>>> Looks sane to me. >>>> >>>> Lizhi, can you verify that this works as expected for you? I'd hate >>>> to accidentally break something. >>> >>> Verified suspend/resume. It works fine. >> >> Excellent.  Would you like to give a reviewed-by and/or a tested-by? > > Reviewed-by: Lizhi Hou > > Tested-by: Lizhi Hou Thanks! Pushed to drm-misc-next -Jeff