From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E3BC4332F for ; Tue, 20 Dec 2022 07:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233333AbiLTHlp (ORCPT ); Tue, 20 Dec 2022 02:41:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232678AbiLTHln (ORCPT ); Tue, 20 Dec 2022 02:41:43 -0500 X-Greylist: delayed 579 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 19 Dec 2022 23:41:42 PST Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64D22F72 for ; Mon, 19 Dec 2022 23:41:42 -0800 (PST) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id AEEBC5C03AF; Tue, 20 Dec 2022 08:32:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1671521520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/z0MB0ZIFP6aeujFH0p44anRHbnTFFLRrIGfOtCkCsA=; b=wgXLk1fPwI5tusswIE/FVXABCqdMsTd4Ewelb8wZZfeqOiyccCdgwwMycuAL9xayASQ5OP NPl6uRIVPAqWR3ncZNOHxYkBz9ZHZQJKSUf2V1sxdsTKuqrAAmgiWFIEth433dZFi6IG9F 84bJ8jwNDilNZ+t8o29aIl5LA+nVjVU= MIME-Version: 1.0 Date: Tue, 20 Dec 2022 08:32:00 +0100 From: Stefan Agner To: Deepak R Varma Cc: Alison Wang , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Saurabh Singh Sengar , Praveen Kumar Subject: Re: [PATCH] drm/fsl-dcu: Remove redundant error logging In-Reply-To: References: Message-ID: X-Sender: stefan@agner.ch Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-12-11 11:27, Deepak R Varma wrote: > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its return > value in the caller is redundant and should be removed. The clean up > also makes if condition block braces unnecessary. Remove that as well. > > Issue identified using platform_get_irq.cocci coccicheck script. > > Signed-off-by: Deepak R Varma Reviewed-by: Stefan Agner -- Stefan > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > index 8579c7629f5e..1ba7d95e1956 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > @@ -272,10 +272,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) > } > > fsl_dev->irq = platform_get_irq(pdev, 0); > - if (fsl_dev->irq < 0) { > - dev_err(dev, "failed to get irq\n"); > + if (fsl_dev->irq < 0) > return fsl_dev->irq; > - } > > fsl_dev->regmap = devm_regmap_init_mmio(dev, base, > &fsl_dcu_regmap_config); > -- > 2.34.1