From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "hch@lst.de" <hch@lst.de>,
Saranya Muruganandam <saranyamohan@google.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"tj@kernel.org" <tj@kernel.org>,
"yukuai1@huaweicloud.com" <yukuai1@huaweicloud.com>
Subject: Re: [PATCH] block: Fix BLKRRPART regression
Date: Tue, 16 Apr 2024 09:10:10 +0000 [thread overview]
Message-ID: <cbcf7378-e889-489a-92d2-1feb112cff58@nvidia.com> (raw)
In-Reply-To: <zvmwp3n3yx55ogzb5gtfe2xdmsg53y3umgnezcwd4weq5vloru@w6qi7lfvezls>
On 4/12/2024 12:12 AM, Shinichiro Kawasaki wrote:
> On Apr 10, 2024 / 23:39, Saranya Muruganandam wrote:
>> The BLKRRPART ioctl used to report errors such as EIO before we changed
>> the blkdev_reread_part() logic.
>>
>> Add a flag and capture the errors returned by bdev_disk_changed()
>> when the flag is set. Set this flag for the BLKRRPART path when we
>> want the errors to be reported when rereading partitions on the disk.
>>
>> Link: https://lore.kernel.org/all/20240320015134.GA14267@lst.de/
>> Suggested-by: Christoph Hellwig <hch@lst.de>
>> Tested: Tested by simulating failure to the block device and will
>> propose a new test to blktests.
>> Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part")
>> Reported-by: Saranya Muruganandam <saranyamohan@google.com>
>> Signed-off-by: Saranya Muruganandam <saranyamohan@google.com>
>
> The change looks good to me. I also confirmed the fix with the new,
> corresponding blktests test case.
>
> Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
which patch is the final one ? Is it this one or the one posted with
title :-
"block: propagate partition scanning errors to the BLKRRPART ioctl" ?
Please clarify so I can make sure to run some tests at my end.
-ck
next prev parent reply other threads:[~2024-04-16 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 1:42 [PATCH] block: Fix BLKRRPART regression Saranya Muruganandam
2024-04-05 6:53 ` Christoph Hellwig
2024-04-06 4:46 ` Saranya Muruganandam
2024-04-10 5:04 ` Shinichiro Kawasaki
2024-04-10 23:39 ` Saranya Muruganandam
2024-04-12 7:12 ` Shinichiro Kawasaki
2024-04-16 9:10 ` Chaitanya Kulkarni [this message]
2024-04-16 10:46 ` Shinichiro Kawasaki
2024-04-16 15:02 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbcf7378-e889-489a-92d2-1feb112cff58@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saranyamohan@google.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox