Re: [PATCH net-next v3 0/7] bcm63xx_enet: major makeover of driver

Florian Fainelli
2021-01-06T17:04:44Z

On 1/6/21 6:42 AM, Sieng Piaw Liew wrote:
> This patch series aim to improve the bcm63xx_enet driver by integrating the
> latest networking features, i.e. batched rx processing, BQL, build_skb,
> etc.
>
> The newer enetsw SoCs are found to be able to do unaligned rx DMA by adding
> NET_IP_ALIGN padding which, combined with these patches, improved packet
> processing performance by ~50% on BCM6328.
>
> Older non-enetsw SoCs still benefit mainly from rx batching. Performance
> improvement of ~30% is observed on BCM6333.
>
> The BCM63xx SoCs are designed for routers. As such, having BQL is
> beneficial as well as trivial to add.
>
> v3:
> * Simplify xmit_more patch by not moving around the code needlessly.
> * Fix indentation in xmit_more patch.
> * Fix indentation in build_skb patch.
> * Split rx ring cleanup patch from build_skb patch and precede build_skb
> patch for better understanding, as suggested by Florian Fainelli.

Thanks for addressing the feedback given, for patches that have not
changed, please carry forward any tag you have been given (Reviewed-by,
Acked-by, etc.) such that we don't have to reply to those patches again.
--
Florian