From: Shuah Khan <skhan@linuxfoundation.org>
To: Adrien Reynard <reynard.adrien.08@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 5/5] docs: fix repeated word 'at' in journalling.rst
Date: Fri, 8 May 2026 11:34:29 -0600 [thread overview]
Message-ID: <cbee6599-a092-467d-bd98-b6ec8d909405@linuxfoundation.org> (raw)
In-Reply-To: <20260508163807.16284-1-reynard.adrien.08@gmail.com>
On 5/8/26 10:38, Adrien Reynard wrote:
Missing change log
> Signed-off-by: Adrien Reynard <reynard.adrien.08@gmail.com>
> ---
> Documentation/filesystems/journalling.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/journalling.rst b/Documentation/filesystems/journalling.rst
> index 863e93e623f7..2825f6c030c2 100644
> --- a/Documentation/filesystems/journalling.rst
> +++ b/Documentation/filesystems/journalling.rst
> @@ -93,7 +93,7 @@ easily as on jbd2_journal_start().
>
> Try to reserve the right number of blocks the first time. ;-). This will
> be the maximum number of blocks you are going to touch in this
> -transaction. I advise having a look at at least ext4_jbd.h to see the
I don't think there is an extra "at" here - the second one "at least"
is in here to emphasize the need to look at ext4_jbd.h
It could be re-written as:
"I advise understanding the basis on which ext4 uses to make these decisions
which is detailed in ext4_jbd.h"
> +transaction. I advise having a look at least ext4_jbd.h to see the
> basis on which ext4 uses to make these decisions.
>
> Another wriggle to watch out for is your on-disk block allocation
With these suggested changes made:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
prev parent reply other threads:[~2026-05-08 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 16:38 [PATCH 5/5] docs: fix repeated word 'at' in journalling.rst Adrien Reynard
2026-05-08 17:34 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbee6599-a092-467d-bd98-b6ec8d909405@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reynard.adrien.08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox