From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: arnd@arndb.de, tiwai@suse.de, linux-kernel@vger.kernel.org,
liam.r.girdwood@linux.intel.com, vinod.koul@intel.com,
broonie@kernel.org, torvalds@linux-foundation.org
Subject: Re: [alsa-devel] [RFC PATCH 6/7] ASoC: Intel: boards: align Kconfig configurations for HiFi2
Date: Mon, 20 Nov 2017 10:27:19 -0600 [thread overview]
Message-ID: <cc11a11c-9bdf-6df5-f48b-07cfa1ddcbcd@linux.intel.com> (raw)
In-Reply-To: <1511024900.25007.315.camel@linux.intel.com>
On 11/18/2017 11:08 AM, Andy Shevchenko wrote:
> On Fri, 2017-11-17 at 18:02 -0600, Pierre-Louis Bossart wrote:
>> Make sure all the configs are aligned
>> Also add the missing dependencies on SOC_ACPI stuff used to fix
>> DAI names based on HID.
>>
>> FIXME: not sure why X86_INTEL_LPSS is needed in a machine
>> driver config, should it be back to X86 everywhere?
>>
> X86_INTEL_LPSS makes sense only for Haswell, Broadwell, BayTrail and
> CherryTrail (more precisely for PCH inside those SoCs).
>
> Basically it enables few peripheral drivers in case they are enumerated
> via ACPI (SPI, I2C, UART, PWM, SDHCI) on SoCs listed above.
>
> Hope this would help how to deal with the option in ASoC case.
>
Yes, and my proposal would be to move this dependency where applicable
in the sound/soc/intel Kconfig. the board-level dependency should only
be I2C or SPI - or both in some cases, there is no reason to have
something SoC-dependent at the machine level, and those cases would be
filtered out anyway.
next prev parent reply other threads:[~2017-11-20 16:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 0:01 [RFC PATCH 0/7] Fix Intel audio Kconfig issues Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Pierre-Louis Bossart
2017-11-18 16:49 ` Takashi Iwai
2017-11-20 16:18 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-21 17:07 ` Takashi Iwai
2017-11-21 21:31 ` Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 2/7] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart
2017-11-18 16:53 ` Andy Shevchenko
2017-11-18 16:55 ` Shevchenko, Andriy
2017-11-20 16:23 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-20 16:58 ` Alan Cox
2017-11-21 12:05 ` Andy Shevchenko
2017-11-20 15:23 ` Alan Cox
2017-11-18 0:01 ` [RFC PATCH 3/7] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart
2017-11-21 17:09 ` [alsa-devel] " Takashi Iwai
2017-11-21 21:32 ` Pierre-Louis Bossart
2017-11-18 0:01 ` [RFC PATCH 4/7] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart
2017-11-18 0:02 ` [RFC PATCH 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart
2018-01-08 16:22 ` Applied "ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell" to the asoc tree Mark Brown
2017-11-18 0:02 ` [RFC PATCH 6/7] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart
2017-11-18 17:08 ` Andy Shevchenko
2017-11-20 16:27 ` Pierre-Louis Bossart [this message]
2017-11-18 0:02 ` [RFC PATCH 7/7] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart
2017-11-18 17:14 ` Andy Shevchenko
2017-11-18 0:09 ` [RFC PATCH 0/7] Fix Intel audio Kconfig issues Linus Torvalds
2017-11-18 9:25 ` Takashi Iwai
2017-11-20 13:28 ` Arnd Bergmann
2017-11-21 17:10 ` Takashi Iwai
2017-11-21 21:36 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-22 11:54 ` Mark Brown
2017-11-27 14:40 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc11a11c-9bdf-6df5-f48b-07cfa1ddcbcd@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).