From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
p.zabel@pengutronix.de, dmitry.baryshkov@linaro.org,
quic_nsekar@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes
Date: Mon, 3 Feb 2025 17:30:32 +0100 [thread overview]
Message-ID: <cc1c34f0-0737-469d-a826-2df7f29f6cf3@kernel.org> (raw)
In-Reply-To: <20250128062708.573662-7-quic_varada@quicinc.com>
On 28/01/2025 07:27, Varadarajan Narayanan wrote:
>
> @@ -479,6 +519,230 @@ frame@b128000 {
> status = "disabled";
> };
> };
> +
> + pcie1: pcie@18000000 {
> + compatible = "qcom,pcie-ipq5332", "qcom,pcie-ipq9574";
> + reg = <0x00088000 0x3000>,
So as Konrad pointed out now, this was never tested. It's not we who
should run tests for you. It's you.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-03 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 6:27 [PATCH v9 0/7] Add PCIe support for Qualcomm IPQ5332 Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 1/7] dt-bindings: phy: qcom,uniphy-pcie: Document PCIe uniphy Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 2/7] phy: qcom: Introduce PCIe UNIPHY 28LP driver Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574 Varadarajan Narayanan
2025-02-03 16:44 ` Bjorn Helgaas
2025-01-28 6:27 ` [PATCH v9 4/7] arm64: dts: qcom: ipq9574: Reorder reg and reg-names Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller Varadarajan Narayanan
2025-01-28 7:27 ` Krzysztof Kozlowski
2025-01-28 6:27 ` [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes Varadarajan Narayanan
2025-02-03 16:30 ` Krzysztof Kozlowski [this message]
2025-02-05 10:49 ` Varadarajan Narayanan
2025-02-05 13:47 ` Krzysztof Kozlowski
2025-02-05 15:35 ` Varadarajan Narayanan
2025-02-05 15:53 ` Krzysztof Kozlowski
2025-02-05 15:54 ` Krzysztof Kozlowski
2025-02-06 6:19 ` Varadarajan Narayanan
2025-02-06 7:37 ` Krzysztof Kozlowski
2025-01-28 6:27 ` [PATCH v9 7/7] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc1c34f0-0737-469d-a826-2df7f29f6cf3@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox